From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128506 invoked by alias); 1 Dec 2017 12:43:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 128496 invoked by uid 89); 1 Dec 2017 12:43:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 01 Dec 2017 12:43:16 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CDCA07CBA0; Fri, 1 Dec 2017 12:43:14 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7CD885D6A9; Fri, 1 Dec 2017 12:43:07 +0000 (UTC) Subject: Re: [PATCH v4] Add support for the readnever concept To: Sergio Durigan Junior References: <1467838463-15786-1-git-send-email-brobecker@adacore.com> <20171130002529.10592-1-sergiodj@redhat.com> <6765d36f-8603-9cd3-0476-801a5bfe0865@redhat.com> <87shcvgj55.fsf@redhat.com> Cc: GDB Patches , Joel Brobecker , Yao Qi , Eli Zaretskii From: Pedro Alves Message-ID: Date: Fri, 01 Dec 2017 12:43:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <87shcvgj55.fsf@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-12/txt/msg00022.txt.bz2 On 12/01/2017 04:35 AM, Sergio Durigan Junior wrote: >> If readnever_symbol_files is set, then it'll have been propagated to >> objfile->flags before we get here, no? > > Hm, I think so, yes. I mean, assuming that objfile != NULL when we call > the readers, then yes; Certainly you can assume that. A reader's job is to read in the passed in objfile. The very first line of elf_symfile_read would immediately crash otherwise, for example. Thanks, Pedro Alves