From: Tom de Vries <tdevries@suse.de>
To: Andreas Schwab <schwab@linux-m68k.org>,
Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [pushed] [gdb/testsuite] Handle attributes.h for remote host
Date: Sat, 18 Mar 2023 11:34:43 +0100 [thread overview]
Message-ID: <d932e2ff-2d84-fb25-9eba-dccd0da1363a@suse.de> (raw)
In-Reply-To: <87lejuz7uq.fsf@igel.home>
On 3/18/23 11:12, Andreas Schwab wrote:
> On Mär 18 2023, Tom de Vries via Gdb-patches wrote:
>
>> +set flags {}
>> +lappend flags debug
>
> aka set flags debug
>
Hi,
yes, though I prefer the form I'm using, for instance because it allows
me to do:
...
set flags {}
-lappend flags debug
+#lappend flags debug
...
while this:
...
-set flags debug
+#set flags debug
...
breaks the test-case because flags is no longer set.
Besides, for readability I prefer that each flag is added individually,
and in the same way, so not:
...
set flags {opt-a opt-b opt-c}
...
and not:
...
set flags opt-a
lappend flags opt-b
lappend flags opt-c
...
but:
...
set flags {}
lappend flags opt-a
lappend flags opt-b
lappend flags opt-c
...
Thanks,
- Tom
prev parent reply other threads:[~2023-03-18 10:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-18 9:17 Tom de Vries
2023-03-18 10:12 ` Andreas Schwab
2023-03-18 10:34 ` Tom de Vries [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d932e2ff-2d84-fb25-9eba-dccd0da1363a@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).