From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 7E7B838BD241 for ; Mon, 12 Dec 2022 12:44:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7E7B838BD241 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670849095; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JHj4LTbKkeLND7x0Dr6k0Ps93utWKEFEvEVZDDyuiT4=; b=WixLeRhVzkTE+o6D9K41DDe/8n26CnINTXJkLTyuWU2Y6uykQxzid9bMbGkcp1dkuP5Vh+ dPnbZ6kCQ21WR5lwP3givdurzt1uEngZRspb8uQE6nZOCnCfcEH9Fb+TY/VjptNgy+kACx QnVAVEhads5yf2axs/Z+TqBD4dfxAec= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-551-tVhvJGgnNV2OAYGyfTYGmA-1; Mon, 12 Dec 2022 07:44:52 -0500 X-MC-Unique: tVhvJGgnNV2OAYGyfTYGmA-1 Received: by mail-ed1-f70.google.com with SMTP id r12-20020a05640251cc00b00463699c95aeso4992181edd.18 for ; Mon, 12 Dec 2022 04:44:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JHj4LTbKkeLND7x0Dr6k0Ps93utWKEFEvEVZDDyuiT4=; b=gGedbqmBpnemcO5f2RxTNYvmiEe90E6KVTcbxRL+OkXPKHEejOmq4EP/ylQNpOUV0m dauQCtJxk0P3URLTIbYc5epME6thYCbnpQJ+90EYACjWughvnxQiz1P1x3dp3jOMgl8N G9gIfB/o2VpMX2pMlyivIhltq8MMWSFxOQlE79GZVC1aHPiWd82ZyQ6XmFqcLqP3qGba o4N3kHSxWUmIxVjAvY0wsWOaNIyueOkADZsdMWedN1DNZq6Gl7l5PrzOh3qP/vsVVIOT YrPRjdc6LNk1XpPWeUxn6hNZSi3La8J6968Vgi6hZHUOGyrbGX9x7DQuHSq8mQwifVfy EjEQ== X-Gm-Message-State: ANoB5pliwd5V9jw5sdp+QySilfzsLEOiAKZi/S0EebDv0qSC1Ygpl5N0 Ai2QmO1faNNJmwSvZNTyTS6qsgM9NC/4+C4bELMySl3F01cUsMkt2avR7WZg2T2Rqg7Jw/cBtaH 47xmLuJYd9PuAEE8drJBlbg== X-Received: by 2002:a17:906:4e9a:b0:7c0:b292:e56b with SMTP id v26-20020a1709064e9a00b007c0b292e56bmr11982105eju.68.1670849089931; Mon, 12 Dec 2022 04:44:49 -0800 (PST) X-Google-Smtp-Source: AA0mqf7PGuBzveq0buv5xfO1nDdlrvdqugq7moGf975woNqcnkaH5Oya0coqjzjPZgxSxA6mj2Ep4A== X-Received: by 2002:a17:906:4e9a:b0:7c0:b292:e56b with SMTP id v26-20020a1709064e9a00b007c0b292e56bmr11982093eju.68.1670849089756; Mon, 12 Dec 2022 04:44:49 -0800 (PST) Received: from [10.43.2.105] (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id a19-20020a170906469300b007c0f217aadbsm3228266ejr.24.2022.12.12.04.44.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Dec 2022 04:44:48 -0800 (PST) Message-ID: Date: Mon, 12 Dec 2022 13:44:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH] gdb/testsuite: add untested message to skip_debuginfod_tests To: Enze Li , gdb-patches@sourceware.org Cc: enze.li@gmx.com References: From: Bruno Larsen In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 09/12/2022 12:56, Enze Li via Gdb-patches wrote: > When running the fetch_src_and_symbols.exp, I see the following output > which looks weird. I even don't know whether the execution was successful. > ====== > Running /home/lee/dev/binutils-gdb/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp ... > testcase /home/lee/dev/binutils-gdb/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp > completed in 0 seconds > > === gdb Summary === > > ====== > > It is the fact that there's not enough feedback provided during the > skip_debuginfod_tests procedure. Fix this by adding some untested > messages to the skip_debuginfod_tests procedure to clarify the output. > > With this patch applied, I get: > ====== > Running /home/lee/dev/binutils-gdb/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp ... > UNTESTED: gdb.debuginfod/fetch_src_and_symbols.exp: cannot find debuginfo > testcase /home/lee/dev/binutils-gdb/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp > completed in 0 seconds > > === gdb Summary === > > # of untested testcases 1 > ====== > > I also modernized the form of 'if' with 'if {} {}' in > skip_debuginfod_tests. Good catch! Reviewed-By: Bruno Larsen -- Cheers, Bruno > Tested on x86_64-linux. > --- > gdb/testsuite/lib/debuginfod-support.exp | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/gdb/testsuite/lib/debuginfod-support.exp b/gdb/testsuite/lib/debuginfod-support.exp > index ceecf9071110..c1a2bb900dce 100644 > --- a/gdb/testsuite/lib/debuginfod-support.exp > +++ b/gdb/testsuite/lib/debuginfod-support.exp > @@ -18,11 +18,13 @@ > # Return true if the debuginfod tests should be skipped, otherwise, return > # false. > proc skip_debuginfod_tests {} { > - if [is_remote host] { > + if { [is_remote host] } { > + untested "does not work on remote host" > return true > } > > if { [which debuginfod] == 0 } { > + untested "cannot find debuginfo" > return true > } > > @@ -39,6 +41,7 @@ proc skip_debuginfod_tests {} { > if { [string first "with-debuginfod" \ > [eval exec $::GDB --quiet $::INTERNAL_GDBFLAGS \ > --configuration]] == -1 } { > + untested "GDB was not configured with debuginfod" > return true > } > > > base-commit: cd3866b6d07b37258eb840443537baa163877e24