From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2088.outbound.protection.outlook.com [40.107.22.88]) by sourceware.org (Postfix) with ESMTPS id 04A69385625E for ; Tue, 24 May 2022 07:56:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 04A69385625E ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=CVOMhH9+wZMXPY5WeTEAEMejtF2d+ePznmgaSypOrHUrioGT7Ct+aOdNjutkHf5it1qsUglMezOc8MKdCl6s2UQ6t0XKwZKzlnf4GwiCSAFITAfyKOXfAW55bHeyfKMdjEdos/JGyjZ7xhaiUX6KfkbmQrt+AFmtiECszW2o7cJt218H1M49Ss7KGZlBLZXi0XivxXlcgfxDHjb7iaF/oMlfC6KIMXzMGOqo8FKjdX9SNhsy/5+QOVQY8l7KKyVSsasXlwO/QDIdGzEEqSzl5Xvgdt7CGRGkfb7X9G3lm9ztFMJz6o/x7ipx7Az9oDk7O3kJKyumgnx/n2mF079EAw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kzDYbkKhSNei0LBq+V5+r//LtcH4xW1QA6mpD7aQPhI=; b=OSGDVDAt6Fpv9bx8vAsHDU9E4sBVqhPEp4k9S+n/jhxaKSqS9wiJSgzCDpbRrZWz2jSNkL3IAYnFEOV6RDeK0MJkVTpwr+pvjktEceUne0eTqCfokov+eV+sfX4NBAbxn2XtXk8DUXgGE2J69I9CcDp30Zzd5TpgGTEqwdw+XOb9yESdDikfQs4hHzhImU7y6cODEQG6XT7xJmaiUa4FxuzL0Xj0VRqECpiWJBjfx3G13oNSY9CuWnVnpjbzbABqaJSOIRjn7JTJvl6Ac+bFjm2i1ST0yfWMAyx49mEH3tqPzOgbz5GzY4AN/IqGdPTTvI1zpjOHZw8/DDHHGu0GlQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from DB7PR02CA0017.eurprd02.prod.outlook.com (2603:10a6:10:52::30) by DBAPR08MB5687.eurprd08.prod.outlook.com (2603:10a6:10:1b1::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.16; Tue, 24 May 2022 07:55:56 +0000 Received: from DBAEUR03FT060.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:52:cafe::9) by DB7PR02CA0017.outlook.office365.com (2603:10a6:10:52::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.23 via Frontend Transport; Tue, 24 May 2022 07:55:56 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT060.mail.protection.outlook.com (100.127.142.238) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Tue, 24 May 2022 07:55:56 +0000 Received: ("Tessian outbound 32b886dfa5b9:v119"); Tue, 24 May 2022 07:55:56 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: d76080ba22f77828 X-CR-MTA-TID: 64aa7808 Received: from d98c69db3535.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0C9090B3-3C07-48DE-8B3A-87D4645CBE71.1; Tue, 24 May 2022 07:55:49 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d98c69db3535.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 24 May 2022 07:55:49 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yks8svJlWHpuvpqRqhcwEyF2uTvNcmmSW8JwGJ4+kVrXeVwXcp1OYHcuX0+HEpmOp7fiGwGFFDQFoecNFzi2YJC9fLIL+W/yOV9gnOHdhSmlfwZv2bQpbMaWzI07gBemaG+jOeZLCmGbh9yGDmOx0XznqbudirXCUTT6p5ochDns6Whx4E+VhXf05+zenUu4sPKd9YF/8BDnV7fzMHiu1eKkHHbBec9MGUKbbmxe6I3aPfIa5+TBHacAzI3jEkmborTvD7qimEVbtHy9VuhVhLXa0qeB0Y0GTy9ZJNGI30QoeuU9Qv7Jw2r4M27iwy0myHeb91j9ATsHhar4kUeSNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kzDYbkKhSNei0LBq+V5+r//LtcH4xW1QA6mpD7aQPhI=; b=JqLVjWIczvffeKyzmvQ1i4gzXMDdAQOsxwrDKw8rruRA95iJU1sXXCchYcpKfSHLQ5iFIYhSvKjBAWcvx4cI17uK6+IwMC6lnMESKy762PrA4pB82q1piBSmi9h5opJeDwISX6BszpDOBPYVn4fRplFHjo8gSzNxboeeGpcXn2MFLiM4MqIgPLDQ9X1hOTLtVNIq5n7clVVNKAd7v3dP9aiOVN9BXVlZpttS5xbscF6019KZ2z8AmTk4sO47AUR2dXrAcwb1ua2Zza/wBfh4PQdNxFD/aVQha/vA/EijD7O/MwMLACRf/Lh2s3RaqhpmcGY7iEI0IOOB/IIgM3LT0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3694.eurprd08.prod.outlook.com (2603:10a6:803:b6::26) by VI1PR08MB5327.eurprd08.prod.outlook.com (2603:10a6:803:13b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Tue, 24 May 2022 07:55:47 +0000 Received: from VI1PR08MB3694.eurprd08.prod.outlook.com ([fe80::1916:206:dd8b:6a91]) by VI1PR08MB3694.eurprd08.prod.outlook.com ([fe80::1916:206:dd8b:6a91%4]) with mapi id 15.20.5273.023; Tue, 24 May 2022 07:55:47 +0000 Message-ID: Date: Tue, 24 May 2022 09:55:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 2/2] AArch64: add support for DFP (Decimal Floating point) Content-Language: en-US To: gdb-patches@sourceware.org, Luis Machado References: <20220520090619.90409-1-christophe.lyon@arm.com> <20220520090619.90409-2-christophe.lyon@arm.com> From: Christophe Lyon In-Reply-To: <20220520090619.90409-2-christophe.lyon@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0370.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a3::22) To VI1PR08MB3694.eurprd08.prod.outlook.com (2603:10a6:803:b6::26) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: e5974362-a69b-4297-14c3-08da3d5ad5a3 X-MS-TrafficTypeDiagnostic: VI1PR08MB5327:EE_|DBAEUR03FT060:EE_|DBAPR08MB5687:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: HBglGA3QAElnru2LTJM9aOV7Hcpq3aKF23ozv1YJqX+xEFteR/ytRLgelppMwYftcv3zTALVyMPuWXQzbs4IYwDj56PsEDMs3rMrR2VW2E5MVBzqZ8ngXW37IEMNpZnieZ+8TAis5IL8XIxGuJ61di8ftJKI85h4fqyLsekYO6/wKrblUvK1XkyJeljNEi3nulnFF4pUbtvgSZqdLGUmcottTBIwq2qwZAk3LsDfhRafY7ddsQXbpUcZPVKKzDjM2HyML7FbecyuFpK26KT3PaVcBg7G83k9uyqCalWBhrZDkKbE7Zv4zgNlrK99HGNnB/d7QB+otGaAhs8AQ5R/3kRJPt3FVsuAQrjg6kKat8MuiM0wEP25UDXQ/sTwThBOGxvamuPt5m9qDQTl7rtBvJ3nMnmkqHmxVTg/pCzqgMKnEct6YcbVnm6u1PbV21DOMzs6GH2Ye1Q8bD0uG6aUm58leKhFdItWCi6y26UNdfiCnudRN2gcpBouVKtGlVWO47QV5CKanengEOSnHhEB0erz14LkZXwM/IQx/3gCbJpy5yonCiFiA5yH3w3KVqQ2sVSYwxA8i30dw+OwQo5oBU7dhkx5seh+Shqj7pCpBhiHBlX42dwzWRIe5AguIZeis/s1W8ZN4vjs0dy/Dnrly/QYK6iN+MzxW1qhai9nEp4Y/ZdtN46B6PEDS618EDQp6re7007dWrLuqZbPaYllWrf0pemTzo2Vil5Z6MgFHHXg6Gl+F3peLk3XwPIBpTRKTHBoEYZSH7Jq5Yhwej66YYekBmBAcV9vuTqeiVPTUtQEWoAAZmTmOyTcaIbBk9L9 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3694.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(6862004)(66556008)(31696002)(66946007)(86362001)(66476007)(8676002)(37006003)(36756003)(6636002)(84970400001)(508600001)(6486002)(316002)(186003)(8936002)(53546011)(38100700002)(26005)(6506007)(2616005)(5660300002)(31686004)(44832011)(2906002)(6512007)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5327 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a5f7fdec-6457-42f3-e151-08da3d5acfe2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4+NtCfEmOW+DwPjNaCxervVbQ+MxVXsOke/wcUrfhallw7NkI4EsT2sRSBEBKDacQJuI+PU0haSbPRQ8ON14sv6N+cgXm5gZXbT1ZHwCb1BgKN6P5LE0Y9A1TrL6CK60GTRdB0bDsm+Kz7i2o7vxOA9k19YQUKZQyzXAGxgNWCXjiANL7ssvSb4g9dwf+xfg5etngoe+oxkOqYOZxM7m79ZT7sSGUMQ/8gnqpKsT6az6YgyxdIF2rW0NwUXYx4PrZZYkVIpqcI78VNW6yS2F5iYm5hBz1ZN83xVcLjC+lshrb4xOlTxKEBjVtoQd4PzMoKFSJD3luyL9RZslhGFJpj9boDg351rQtVPztW+gJDjhgFoGlWKeoSpQz5JhsOmdR5RsfG7Vwe8thkErXfd/28E265n30tAJnsXI4QBuLGx4rm814p2CNtBzFrFX2VYaL9vIZCoc3wUHptcJ7wFGkD59x73MvWtEvMyBzUom1TQtv1hAWsNkIW9vt8ngdGhkzq812mdeN3BVET/0XdpZuKRT85XhxJ7ahSfFy0TysZN2TNJeQ35oIIGDO3IaHo/ox/tAEen6Iy74RC1kLemrItIhV+x1uHj3UA7C9/u7r5aURpA5JZ20dX44YV2fwA/gZ3PRk6akWpExM1YT4AnsYvIo7A0W7fQeOqydd5j3a8tWUpUIkdrEN13NEpbzgy6EDqAiFWnKzXksVd215QNk4UBYyQ+72Eas5cdvLBxAgYn8xVSCHiflpeRVvFZqLGWthiWuPBoaF1bmTeMVnG0HREn51jr/uZHcdXX3AS92sl8= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(6636002)(86362001)(31696002)(31686004)(36860700001)(8936002)(2906002)(53546011)(47076005)(44832011)(36756003)(26005)(336012)(8676002)(6506007)(356005)(82310400005)(508600001)(316002)(186003)(70586007)(6862004)(6486002)(2616005)(84970400001)(40460700003)(5660300002)(81166007)(37006003)(6512007)(70206006)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2022 07:55:56.6932 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e5974362-a69b-4297-14c3-08da3d5ad5a3 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5687 X-Spam-Status: No, score=-15.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 May 2022 07:56:02 -0000 On 5/20/22 11:06, Christophe Lyon wrote: > This small patch adds support for TYPE_CODE_DECFLOAT in > aapcs_is_vfp_call_or_return_candidate_1 and pass_in_v_vfp_candidate, > so that GDB for AArch64 knows how to pass DFP parameters and how to > read DFP results when calling a function. > > Tested on aarch64-linux-gnu, with a GCC with DFP support in the PATH, > all of GDB's DFP tests pass. More precisely, patch 1/2 has a side-effect of enabling the GDB DFP tests, some of which fail without this patch 2/2: gdb.base/dfp-test.exp: Call function with many _Decimal128 arguments. gdb.base/dfp-test.exp: Call function with many _Decimal32 arguments. gdb.base/dfp-test.exp: Call function with many _Decimal64 arguments. gdb.base/dfp-test.exp: Call function with many mixed decimal float arguments. gdb.base/dfp-test.exp: Call function with mixed decimal float arguments TEST. gdb.base/dfp-test.exp: Call function with mixed decimal float arguments. gdb.base/dfp-test.exp: backtrace function with correct _Decimal128 arguments. gdb.base/dfp-test.exp: backtrace function with correct _Decimal32 arguments. gdb.base/dfp-test.exp: backtrace function with correct _Decimal64 arguments. OK? Christophe > --- > gdb/aarch64-tdep.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c > index e35c083454d..67a3f96e1a7 100644 > --- a/gdb/aarch64-tdep.c > +++ b/gdb/aarch64-tdep.c > @@ -1470,6 +1470,7 @@ aapcs_is_vfp_call_or_return_candidate_1 (struct type *type, > switch (type->code ()) > { > case TYPE_CODE_FLT: > + case TYPE_CODE_DECFLOAT: > if (TYPE_LENGTH (type) > 16) > return -1; > > @@ -1780,6 +1781,7 @@ pass_in_v_vfp_candidate (struct gdbarch *gdbarch, struct regcache *regcache, > switch (arg_type->code ()) > { > case TYPE_CODE_FLT: > + case TYPE_CODE_DECFLOAT: > return pass_in_v (gdbarch, regcache, info, TYPE_LENGTH (arg_type), > value_contents (arg).data ()); > break;