From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2060.outbound.protection.outlook.com [40.107.105.60]) by sourceware.org (Postfix) with ESMTPS id 3A20D3857C4F for ; Tue, 7 May 2024 15:56:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3A20D3857C4F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3A20D3857C4F Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.105.60 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1715097424; cv=pass; b=Sz8tf9ieohtg5Rv4bL/ZRCx4rz7gmIkB8iP8hpVuiJ16WVMBlUTkfiq893PrwXh0+rNZl1CqF5JTjAAZZlq2vC5cvC1fNdMVSUrUhPxd6bfcYb/Mrp08/3lsN594MFDXCmXYLHKNI4DsCAFmnVupaq+dVkCkbKC3KjG3dR6mVK4= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1715097424; c=relaxed/simple; bh=F1KSMy/4S+Gf2QCpIMeSSJe5vLZ31oIetodBnRguUgU=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=wTtja42EmPKhZGtHQ/3nLQaItUA/jiTGyXcVhoKLpNtvr9vT1FVOrG902DiCkp88VN2xarxC2MwX6Cz59Zkjl7YnJGkau/22ml7rpLWm7ANjg33IJgVJ/rT0WRSSWbr7dtwQhTs1tIusGHCfIoITUUwfyGO0vIKWPHZl+nyXzto= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=WYEoAD1eS+4lnAGoebl7yw2azJJnvz7V0JTW3KZj+ujPSUJhlKoWf4+s4OAmc68In1oA2cCVsVdNvl4gFfAvvuq+GrdIp0XWxZKqttXoV/HlM5MGEYaRByUptC/sGvjgPWgFrhaTG4b7BJ+3tlYPsGx3Gi/D+g8gfXp7aT5eOwgp2dcKqUG26GHp4GK2K+TpV/yRdrdesAhvDDGtqaiBDvYiwxl1XuR5RaPyFR1j8k5c6stKj/QjaAdE0Km4Mz8oof0XJVLkaOeGPPg7oJ4kEAij/dhHv1vFhPtzzCgYKpNIkGJRAA5qEn1bm83QdbBNgnk6ty4OK8L9juM8Ruz9zw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QzFSGJTH/hLQteYbUHgPAlDVevTt6DC9axTrj2IpmRM=; b=bViAUuMMX6w12wByotznJEI96K1DGzVWmFrRlGR4i0fiXB0549se0A7uWDG09pMMC5JHFW3ym7X5s924kR1L4G/z9npAiUBg7QEvfKERw4TeTt+KI5ahHp8XwO3DWQ26hjZ2VZm+tPcI6OYJ2M/gxSiedAv47KIVEFzsHV88GikDfgR76Pw7u0UvmgrlRtb8ArHZ8aNOwwXoofNBO1XTwDW00irg6mP5hS4PEF3rCd50aYsu9KZNgFFOzoB/n98AOKhW2zsUn/Q6SLNmMrIqywoR25fh0dyynnop1vgKArXeNhteZ4ZFa74jk1pqxqGgwxKuVKfFgw0VNVmZqPSx0Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QzFSGJTH/hLQteYbUHgPAlDVevTt6DC9axTrj2IpmRM=; b=rgMLECeK94yGi9VecsuR5gzYoNpw7Pjt46J0SmrztqBv6x5SEO1yJZOhZTw3HabNRkM0TJDi6+Di+NpKLSO8UATdTYqCeEb6J70ccftQa4epyfw4+/UAZaFRDZg7YlpgRgiYBBvlvJWx3c4xC85FtnwaovZPZKXe8UXuopP0D/w= Received: from AS8PR04CA0192.eurprd04.prod.outlook.com (2603:10a6:20b:2f3::17) by DB4PR08MB9359.eurprd08.prod.outlook.com (2603:10a6:10:3f1::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.41; Tue, 7 May 2024 15:56:53 +0000 Received: from AM1PEPF000252DD.eurprd07.prod.outlook.com (2603:10a6:20b:2f3:cafe::9e) by AS8PR04CA0192.outlook.office365.com (2603:10a6:20b:2f3::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.41 via Frontend Transport; Tue, 7 May 2024 15:56:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM1PEPF000252DD.mail.protection.outlook.com (10.167.16.55) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.7544.18 via Frontend Transport; Tue, 7 May 2024 15:56:52 +0000 Received: ("Tessian outbound e46bb127ed3d:v315"); Tue, 07 May 2024 15:56:52 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: fc9a2adbc665bf2b X-CR-MTA-TID: 64aa7808 Received: from 984b5da910cf.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id EABDB4C4-0770-45BF-8DBD-9B8B5DAD8A40.1; Tue, 07 May 2024 15:56:45 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 984b5da910cf.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 07 May 2024 15:56:45 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jvp3IPx7cGSK0CJ6YSaKyd0Und8mIM3zr9lgSLmPfS87GXtgHrREXgpv2fdjoy3T97wwycABKzSf7wIm0lbnQ+tdDDXHMKRc5HSYgAsCysvdnxcVWGlgBWjgryA9WMX3E6nsH9QAWpAaBqPiJDVukoBhRFNdCE3cLFQIaGBLsn82uezztSAI3LM65Ov6eK4brB+DcqSqrfaukjKHwj+HcvtGBJBvtFnhZCnHgtIePPWlT1XJvsx3KmAO1+jHQ/tiO8q8AXEDgDViSv17uzk9cZy5eHRFK4406wBc7dJpe7kU4xQ6+0kYfnN2U5YtP6Mw2oS0ZM7lLpCbbHl0xIT+zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QzFSGJTH/hLQteYbUHgPAlDVevTt6DC9axTrj2IpmRM=; b=TdJt105xdQO3u3u9UDnBUuyb/QTOsgF2AMAfzls7ijd1cgA2yT7TWkskc7JWIzb2p84jT4L0NvfSZD2IKSrRn4mRiW0wwqYDQCJDSLC8ZXFc+NUbnXc4cRt69k12oro+CIiU4YQ+35qvbc59VtnzghrcZ5agK2E3ktJwaRYFdYarBFNX67XC6joNgsUL2EKpnUzLMwCgxANh3v17gShTndjrYEr2sjTcCv/RnFM1s4xVlipy7npioeA3U6wMgl/iBcbxn+T+6BBXzR3AYOR3GvCKevPNklKHXwIcBOOC+WBUohqJjD0bCEM+4yNiG71OWExuHYmdn+VYbYDiK7kpWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QzFSGJTH/hLQteYbUHgPAlDVevTt6DC9axTrj2IpmRM=; b=rgMLECeK94yGi9VecsuR5gzYoNpw7Pjt46J0SmrztqBv6x5SEO1yJZOhZTw3HabNRkM0TJDi6+Di+NpKLSO8UATdTYqCeEb6J70ccftQa4epyfw4+/UAZaFRDZg7YlpgRgiYBBvlvJWx3c4xC85FtnwaovZPZKXe8UXuopP0D/w= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AM7PR08MB5461.eurprd08.prod.outlook.com (2603:10a6:20b:10e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.42; Tue, 7 May 2024 15:56:42 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::77d4:d040:b19d:6472]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::77d4:d040:b19d:6472%4]) with mapi id 15.20.7544.041; Tue, 7 May 2024 15:56:41 +0000 Message-ID: Date: Tue, 7 May 2024 16:56:39 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv5 05/11] gdbserver/x86: move no-xml code earlier in x86_linux_read_description Content-Language: en-US To: Andrew Burgess , "Willgerodt, Felix" , "gdb-patches@sourceware.org" Cc: John Baldwin References: <6e7440d3bb04135432f9f18e0630ee1bca23e4d6.1714143669.git.aburgess@redhat.com> <9e95c677-b640-43af-903b-b01a48d5ac67@arm.com> <87h6f9tyop.fsf@redhat.com> From: Luis Machado In-Reply-To: <87h6f9tyop.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0189.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:311::15) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|AM7PR08MB5461:EE_|AM1PEPF000252DD:EE_|DB4PR08MB9359:EE_ X-MS-Office365-Filtering-Correlation-Id: 50017a08-4db3-4393-1b59-08dc6eae5035 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0;ARA:13230031|366007|376005|1800799015; X-Microsoft-Antispam-Message-Info-Original: =?utf-8?B?alh5d3RlOUxMMVA5bEhCbVBFVTBRTXdQUlpoeHBtWEVZdGEwY0pObHBGSWdJ?= =?utf-8?B?TUhPMnNjUVVOZ045eERoV0FPdnpwMC9NTVFqOGU2alFXaXZPMTI0REJnM0g3?= =?utf-8?B?YUFGVW9lT202bmtYMjExSlF3a2Vwd05uNTJ2RDhkRzJhQWlDak1aSXlScFp5?= =?utf-8?B?eEFtbjhKdWJDeEV1YUthS240cGJ1M3Y0Qyt1cXg2TnR0dFVSSHlpL2pkU2Iw?= =?utf-8?B?Z2wzWGVKVkxxc0Q5M0N2SjdSaHg5cTE1SnVVUTVzcW5VM2k5ZnBUQnRGS2lG?= =?utf-8?B?YmVQV2x2VXNpays3clVWTm5jc09kcjF1NGc1NHUrYk1GWjVJRWEvL3JjRmhZ?= =?utf-8?B?K1NUMzlpR2JiMVNWdUZGRjJHeTJmeVovYWFxRUVydU1DLzRhV3ozWE0rZUVK?= =?utf-8?B?Q3A3d0k0T2VZVllnRVRGTm9SWG14UXN2ZlFhYlVWWWpscEV2cUVEM20yNE1W?= =?utf-8?B?YmtaOXhOZFNpcU1Obk1LaGtUdDBYczhpMFhvc2RkdGxGNDE5eGVzMU5KdVYv?= =?utf-8?B?ZlZoMjEwOCtNRjYzK3JqSUR4MW40WW5JaC9mcUpVZnFUdS83VkhDaXlrYlEz?= =?utf-8?B?clpsMFBhQmM4MVRYYXY5WHhrcHZZMjhMaFR0LzZsUDFueXBQV0xxNDc0T0oy?= =?utf-8?B?bDlxeno4RXRzNFFYV3l0Zi9BazhXWWpLMS93VGNNVVYwZ2pIcHYrenIyVzNq?= =?utf-8?B?RE95RnAvc1JTekx4R2dNMUpyZ0RRU3ZaQ1YzY2MrclhQSkRPZjlqb0hGQ2gx?= =?utf-8?B?WnVZcjBVZGpZVFdkbUc2WFRuaDRDRFFWdHpSY0o0K2tVVVFoUHd1MmNSd04x?= =?utf-8?B?Q2VXa1d6SDN0NnQ4WG85TFJ6Ry93OU5VWlpQdktLMzh3WDdiVjI5MUFSQUZh?= =?utf-8?B?Q3ZBYmQyV3hxY29vRWlJVlQ0UklKaW9ROTc5cEI5RVZQb0wrNmd4eFdVM0l5?= =?utf-8?B?SDRpTEJ0c0VHZTVaMTFSbjIyTUIrZ1FCZ3lFSjNidVBDQS9oMUJjdWRrL0Zu?= =?utf-8?B?cjRqYmRBZGVMY3pYWThLZjk2UXRzUnpFV0p4czF3NkpXeDZhc0c3amVWWmE4?= =?utf-8?B?a1o3dTIrcDRtMFNQYUNPUFlTQVE0MUFGWitUeFJzRmlvelVYNE9KbFcwK21x?= =?utf-8?B?OVdHK21Lcm8zd3VBMVFrUlgzQm54TjE0dHhNVWl4eU5pdGZtdDlJdURhYmJP?= =?utf-8?B?RVE4T0RwSFRTN1lSd2VveWw1TnBUS05MYU80MVJVNElKQkJEL1NWLzVOc3Ev?= =?utf-8?B?RGRvTVF5RDhCZmxncEp6RGk1NEZVUmJqOUV4U20vY3N4VW5sZlRTZDJDdzBD?= =?utf-8?B?L3NobGE2MFBKUzhlTzNzQ1JJNnF3dmlIbFVuNG5rdkZ1NEhCNTBaRVhOTGYr?= =?utf-8?B?LzJMUXNGR1F2ajZXaFY4K0tLc2htVkh5R09uc1pmSW11S3MxNEZndmNvdGdr?= =?utf-8?B?em5WaGtoN2dCMzh1SDd6ZmhVMnJSaUxHMmdoeFlYOTJkK1NQdndjdVUvMENw?= =?utf-8?B?dDZWOVBhNHpDdGVwaTdVQTRmZ2FIbTRPQldLN0F6ZE5DSGUwSVY5RWQweGZl?= =?utf-8?B?ckUyeHZJZmJpL0dEMnRnVENmem0vWmpwb1MyOG5qc3h5d3hHLzJLdW4xS1Nn?= =?utf-8?B?NDVqMktUejNiSmp5MWV5aXI0MkVRQkszRXFDTHgrZTVBUjFGb3RJa3d5MXJ3?= =?utf-8?B?YTR1U3UwbDRTQXUyY0p6M3pHNENZNXZYWVNNQkVCb21SRjgwQVZUWk1nPT0=?= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(376005)(1800799015);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5461 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM1PEPF000252DD.eurprd07.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 092b5068-0063-4093-0040-08dc6eae497b X-Microsoft-Antispam: BCL:0;ARA:13230031|36860700004|82310400017|35042699013|1800799015|376005; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dDRIYWw1SW5zY3dwNVVaRVJRMzdPeTBuRHRLSWpyOVV4Z0xKaml0YXVqam9C?= =?utf-8?B?ckg0ZDZRR2tNSUQySlV4eEplY21TYk9FcU56OUhrNmtaeXNteENyOC90WjEr?= =?utf-8?B?Y0pyNUhhcHhLQ1J1b0YrVHVCL216WUkyb1c1MGNvay9BYkY2OEpOUnl2RXJ6?= =?utf-8?B?eEJMR0dvL1djcTV5Wk5IUTlaZWxqNHE4SDJqOVBTL1ZhcitvY3p1QjRIT3Y2?= =?utf-8?B?ODBMd29ZcmlHb2ZZTnlnSnR6aFVWREEvQmpUQ05zQW1zbW04OUVFaHRmY3dB?= =?utf-8?B?cDJZT3pWNkdzNXROU2JaaXpKcXdWMjJUam1YQS9jZUZrUENjTmRQRXRUeG1h?= =?utf-8?B?NkpaMEUvSzhmYXFRd0pHaXdMZm1adVBrS3pEYVgzWDF2dG5SbFZhejBXTHJ5?= =?utf-8?B?OHd5eWtkWjByVm1NTVo5ZWZWZCs1S2FsdGx5OUxmOGdSd3JOR0tINUxZU2VP?= =?utf-8?B?ekxnUEtWaDVxOGc0U2hES29PclBGZjlpdnp2dEhOZCtiN2c0ZDdJb0RHMS9I?= =?utf-8?B?R2o2d0phK1A5R3ZRVzk4ZWwzblp0bTFlc1JaRW5hK2duUit6MHhwcTFGdXdJ?= =?utf-8?B?UXF3Mzc1SE1Pdi83N2ZseW1oMGJrRysybWdHVG55K1k2Q2FablI4L2hWRlZi?= =?utf-8?B?UmdpZUdxTWZmbm9Cb3VLaG9RbEVwNXprbWRhWkpKazZNb1ZtU2tSbndtc3RO?= =?utf-8?B?V29wTHVGVXJYSzQxQXlrNTc5WXFYeFVpeUVvVWlCU3Y4TWNpL1JIWi8yM3g3?= =?utf-8?B?aFY1R0h5ZTdxcFZuQWJNZlVFblhSRyt2NXR2VDQ2MWRXN081MDZFaEpXMUFu?= =?utf-8?B?NHE0T3dwUndjc2R3T2tLRGg2ZDE1eTB3WmI4WjVHKzIrb1F6c2RjU2QxS3Rl?= =?utf-8?B?cUtHK0R2U0VFdWVRSHF1VXJjN3I1RFE3Yno3dGsrOVhwMUlMOWZIay9yVE9u?= =?utf-8?B?TitNamJjSWtrcDdZc1NZUms3RmtHOWFzbldCNzdHbWYyRUxFZ29VTERmNTNt?= =?utf-8?B?eU91TDlYUHpFblBMZjUwR1hmaHhqK0l2aXJUQjVKaktHaXJYNHJoK3A5SHJG?= =?utf-8?B?TWJnVW53M1pHN0tFSDRXeHhXdFZtaHgzRlhwQitFSWRDY3BZRllHWWZlclp4?= =?utf-8?B?NkN4N1VaVE5FTnk1eldZYzBsMDFPMGo0Qk9wS3pUY0lqSUlvZXg2QmNiaTNF?= =?utf-8?B?WDNkcno3ZXFvU2lBVUloczJGME1hSW9hZTNGZ0FGeVVzQklzVjVpaStKcXJz?= =?utf-8?B?a0xhVVBPc0p3QmNVL3MraFRmWTh4cVBHTTFEdnpobWJFY2l5TldwVjJ2aWFm?= =?utf-8?B?NWFhSWd6OFhxSnN2bW9hb0gwT2NRaXQzVUhvMWhWMFlUaHd3b200RWFiOXk5?= =?utf-8?B?dC9IOWVOM3JGWWk1d1l3ditTK0pIM0JmY3BUU2ZyZStRdjd4VUhmbEhOWUJy?= =?utf-8?B?VWtpazd1Q3NDaDNQNExkNTZEZ3NKV1kvMFNjOTM3NHQySGoyeG1raVd2WURX?= =?utf-8?B?M3dRdG4xQ2VaYXBlQUFEMjlkZkpBaXhzMTFYZHN6Ti9EUzMyZXBUelNaNUg4?= =?utf-8?B?TXBDR255cHVNdjk5STdKV2V0eHJXcXk5U215bW8rV3BJcm9Idk9uN0lEalFy?= =?utf-8?B?bkxwbGJoNlYxMW9JZHN2VjRPRTJVdkpmQkt5dms4NVRhU3JlTnZ3MkhXcmRY?= =?utf-8?B?WjVUeFoxVkhXakFMZXQ3K2dUanZ3bXB0ZUR5M2tuRG9rMU16RDMwRzBnWjAv?= =?utf-8?B?bGdqZ3VSQmpzT0JMWTNlNzJuMm81aE9KUW5ZZFBTQmRnNWZWRjEvbCtHcEVq?= =?utf-8?B?VkRtK2dGczZvRG9VQSt1K1o4R0VSWGZSNlhYOUNndXhYWmNwRVNUdktrRjln?= =?utf-8?Q?wwEQLx5bjP9HK?= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(36860700004)(82310400017)(35042699013)(1800799015)(376005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2024 15:56:52.8165 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 50017a08-4db3-4393-1b59-08dc6eae5035 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM1PEPF000252DD.eurprd07.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB9359 X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/7/24 16:43, Andrew Burgess wrote: > Luis Machado writes: > >> On 4/29/24 15:34, Willgerodt, Felix wrote: >>>> -----Original Message----- >>>> From: Andrew Burgess >>>> Sent: Freitag, 26. April 2024 17:02 >>>> To: gdb-patches@sourceware.org >>>> Cc: Andrew Burgess ; Willgerodt, Felix >>>> ; John Baldwin >>>> Subject: [PATCHv5 05/11] gdbserver/x86: move no-xml code earlier in >>>> x86_linux_read_description >>>> >>>> This commit is part of a series that aims to share more of the x86 >>>> target description reading/generation code between GDB and gdbserver. >>>> >>>> There are a huge number of similarities between the code in >>>> gdbserver's x86_linux_read_description function and GDB's >>>> x86_linux_nat_target::read_description function, and it is this >>>> similarity that I plan, in a later commit, to share between GDB and >>>> gdbserver. >>>> >>>> However, one thing that is different in x86_linux_read_description is >>>> the code inside the '!use_xml' block. This is the code that handles >>>> the case where gdbserver is not allowed to send an XML target >>>> description back to GDB. In this case gdbserver uses some predefined, >>>> fixed, target descriptions. >>>> >>>> First, it's worth noting that I suspect this code is not tested any >>>> more. I couldn't find anything in the testsuite that tries to disable >>>> XML target description support. And the idea of having a single >>>> "fixed" target description really doesn't work well when we think >>>> about all the various x86 extensions that exist. Part of me would >>>> like to rip out the no-xml support in gdbserver (at least for x86), >>>> and if a GDB connects that doesn't support XML target descriptions, >>>> gdbserver can just give an error and drop the connection. GDB has >>>> supported XML target descriptions for 16 years now, I think it would >>>> be reasonable for our shipped gdbserver to drop support for the old >>>> way of doing things. >>> >>> Interesting. I for one would +1 this. Slightly related: >>> I wonder if anyone really builds GDB without libexpat anymore and >>> if we couldn't even think of making it mandatory. (Which doesn't >>> mean dropping the ball on supporting stubs without XML.) >> >> I'd support making xml descriptions mandatory for some targets. AArch64 and >> 32-bit Arm both rely heavily on xml description for feature discovery. > > I might be wrong, but I don't think Felix was even suggesting we need to > go that far. I think the suggestion was just that GDB itself should > require libexpat, which would mean we have the potential to read XML > target descriptions. Sorry, I might've read too much into it. But making libexpat a requirement for gdb would be a good move in my opinion, nonetheless. Cross-building gdb sometimes yields a gdb with no libexpat and that is not very useful for AArch64/Arm debugging for instance. > > This wouldn't mean that targets would be required to send XML target > descriptions.> > My comment was specifically that x86 gdbserver should drop its no XML > support, and if a user tries to connect with a no XML GDB then gdbserver > would reject the connection. Understood. > > Moving to make libexpat a requirement would help in this case as a user > would no longer be able to build a GDB which couldn't connect to an x86 > gdbserver. > >> Off the top of my head, I think very old probes and the Linux Kernel's kgdb don't >> support xml. I'm not sure how often kgdb gets used though, but falling back to a >> default description should work for AArch64 and 32-bit Arm. > > I don't believe building GDB with libexpat support breaks the ability to > connect to a target which doesn't support XML descriptions (if it does > then that's a bug), so hopefully nobody else would be > inconvenienced... except for those folk who are building GDB without > libexpat support. Makes sense. Thanks for clarifying. > > I've added making these changes to my todo list, but I don't want to add > them to this series. > > Thanks, > Andrew >