From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id CC9523858D35 for ; Fri, 12 Jan 2024 08:43:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CC9523858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CC9523858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705048996; cv=none; b=I6NQasJ6jq+4//H5FPiMSUn+8x/a0r8ETrYRIjy+cVb0lKwZzobufmwcuRHBNN2IZPLqY6+IjYZCPm/lZC4tpWjVGnFVRO5/MPgNxvDMucnZSiK+FRT1hiTC/WMOMACQGNWrySMzZu6FwnuFYTMbFgd4/lkV56zSBdgkHIv9GmQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705048996; c=relaxed/simple; bh=yPkV1HkJAyeuYCO5sMMwu2lyYXsr7/o4Wy81V7kga5Q=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=WeX4UBp8+CDLC7pKntahLtsMJbVznVdVTsAOGfkCye6xD+etc2clarHboyNmG9YApNFK2qWoRRkC9ooEaYxUWqY2Rzy0N7/oEmPj1PRzxcnWEwLiKvwIC+7lLNxgHBKqhLRM+0caiRmowg1Z2yI7ELdcjRwCJ7MFQQfP2K1hyeQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705048992; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Kp3QqOxyZ9kp6EuPqmEGLUMiGx3Ql8koO7TimbKfnOc=; b=BKdid+JyHSxEAntT7YJc9tlUdQfhzfqAQXb9sFE+fQNqo30kMjiVPFjCqhJof3xhsMMQpr 8bm2H5A6SmYkLaCzvvkLQgPFHbKeNxgIvYfFSasg0BgGolWVOOEZuqstNorfrIWHPLCK/7 ANejwJKghAXY6Dz6P6lZJVKwSK1BN/8= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-300-WVlcvwU1OZCMFoXoSlJYfQ-1; Fri, 12 Jan 2024 03:43:07 -0500 X-MC-Unique: WVlcvwU1OZCMFoXoSlJYfQ-1 Received: by mail-ed1-f70.google.com with SMTP id 4fb4d7f45d1cf-558b84a7eeeso451000a12.0 for ; Fri, 12 Jan 2024 00:43:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705048986; x=1705653786; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Kp3QqOxyZ9kp6EuPqmEGLUMiGx3Ql8koO7TimbKfnOc=; b=AN6bKLQovtU9gHXZsAmeinOPDbSzrsl0DHSlI8XbFUWnPYBe7jCeFSPtT6kGG5gQgM dOyRDORmg942NluisdN3XaClBrJSRjV9WChx2dy32jEZziaNhWRvbMowxGKx9A90laoK INKMYMa0IGyrdt2CvO/ShsLkvEmIifES5lArWCSCvLA6/vJuZ6OZtco+XQ+Txm0n6z60 Dt3jzvAISLjYDkjP8Lf2yy/C/PXmylfFEfW36I+UmYufoKAuSfHK0bLDFWEIqlcxjpQK u4OFh10d+5H0Pm7OQQRfSOooej2YYXlVQTP1Gcjts+Efhww1307J+Mdc25CURm5NNoZK kgKw== X-Gm-Message-State: AOJu0YwD2VqQskZN4mvBnjUafAdCj6a4FtMVeV614HR5dyZQuWs/RW2X qNOsAuB/TvJsUuywPLg49RG3AIR3/t9UkSiqDAd8hN3jY06h4VMJZ1KMAqz7juIpmm04BhiK7fY SZktOrEaQgrs3WbEMzLuI6ie05OULSQ== X-Received: by 2002:a05:6402:2319:b0:557:6516:289e with SMTP id l25-20020a056402231900b005576516289emr458137eda.29.1705048986749; Fri, 12 Jan 2024 00:43:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IEherpwhsj8gmNYqhxaQR71R35Q+F65BdlEBs8ttayeeghmfGYfTMRhNI94bC+1fEYZzJJ7mQ== X-Received: by 2002:a05:6402:2319:b0:557:6516:289e with SMTP id l25-20020a056402231900b005576516289emr458133eda.29.1705048986448; Fri, 12 Jan 2024 00:43:06 -0800 (PST) Received: from [192.168.0.129] (ip-94-112-227-180.bb.vodafone.cz. [94.112.227.180]) by smtp.gmail.com with ESMTPSA id da22-20020a056402177600b00556a9b663c8sm1555740edb.36.2024.01.12.00.43.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Jan 2024 00:43:06 -0800 (PST) Message-ID: Date: Fri, 12 Jan 2024 09:43:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] gdb: RISC-V: Refine lr/sc sequence support To: Palmer Dabbelt , liuyang22@iscas.ac.cn, Andrew Burgess Cc: tom@tromey.com, gdb-patches@sourceware.org, simon.marchi@polymtl.ca References: From: Guinevere Larsen In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/01/2024 07:39, Palmer Dabbelt wrote: > On Thu, 11 Jan 2024 22:27:32 PST (-0800), liuyang22@iscas.ac.cn wrote: >> On 2024/1/12 02:09, Tom Tromey wrote: >> >>>>>>>> Yang Liu writes: >>>> A gentle reminder: this patch has been approved for some time now, but >>>> I've noticed it hasn't been merged into the codebase. Has it been >>>> overlooked? >>> I don't really know the status of this, but if you have copyright >>> papers >>> in place, we can arrange for write-after-approval access. >>> >>> If you don't then I suspect we will need them, because this patch is >>> over the size limit. >> >> I'm an employee of ISCAS (Institute of Software Chinese Academy of >> Sciences), we've signed the copyright papers to binutils-gdb. Please >> help arrange this. > > As far as I can tell the ISCAS copyright assignment includes GDB. > Maybe Andrew just reviewed it thinking you guys had commit access?  > I'm not exactly sure what "Approved-By" means. You got it right on what "Approved-By" means. Once Yang gets added to the write-after-approval list, she is free to push this commit to the master branch when her patch gets that tag. (Or, a maintainer can merge her patch in without giving that access if Yang thinks she won't contribute further). For the complete explanation of the tags, a patch was merged recently explaining how they work in the gdb/MAINTAINERS file. For convenience, here's a link to the final version of the text: https://inbox.sourceware.org/gdb-patches/20231207173415.2311804-2-blarsen@redhat.com/ > > It looks generally reasonable to me, so > > Reviewed-by: Palmer Dabbelt > > if that helps any... Hopefully this goes in soon! -- Cheers, Guinevere Larsen She/Her/Hers > >> >> Thanks, >> >> Yang Liu >