From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 0C35B3851510 for ; Thu, 27 Oct 2022 13:17:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0C35B3851510 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666876653; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KATy0kpZy308Wk6oJwFTCnlv77J/nzmxBIMdWzxGawM=; b=au4zA80kOEcir5nA+xXLlnZNfrLMWd4q0ej5CgnRLi8luoYYedS0PCq9L5PWEJcj7WNYMl nRaFYaIu7tNAV4ov/A9WONsL58isXVu6Q6YhmkwVlvZtCDhJn+2zg6VZCtLZkRWuIXiIjo qypHzdkDnY1ZF9t+g6cRvM1qI5gCwEQ= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-675-fuLR8B5YPoyHkVzyCfJw3Q-1; Thu, 27 Oct 2022 09:17:32 -0400 X-MC-Unique: fuLR8B5YPoyHkVzyCfJw3Q-1 Received: by mail-ed1-f72.google.com with SMTP id i17-20020a05640242d100b0044f18a5379aso1096991edc.21 for ; Thu, 27 Oct 2022 06:17:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KATy0kpZy308Wk6oJwFTCnlv77J/nzmxBIMdWzxGawM=; b=2cukuCOs7FD6ebggLs3epydTe7l9QoHCIzVr74u8JPXcABnPD95r1Q0t0E86Suk3oV Y0m1nCB38VwDlxiEhYoO/lNSZP2Oy7RH5YSyaI+ugGCkjbYWUY+e3qPf9o6fswPt0Hm7 YNQTcgW6cOFl3ITfw2Sn39HuPeFjSHikmKCz3wcL9km2VnZLY3OnJIx+dqPKkxDaUdQm nkrxbDD6iBMIPlWzxwlKbGMd7n2iu1T3mhQYIFAmcb7cv9Nsql1LRvq+L9DRunEuaws3 QOsjWIYW8w2mxbSJYx1/M7idG3BZXugw3o8mMhg7rPPP7kN+qGRwTucRWIHJzWKK9hs1 78YQ== X-Gm-Message-State: ACrzQf2kgn5buB17T65Eh6z1rfvxh3+TDme426q3JBsHBX6Ik3jN5Xoh 9ubWWI4hXe8aSlQS/u/KxBL3pUyGiiqbl1iUuQeuDOb/AmerCWrN/Wqd9gQqpgKJwHF5XWwAHc0 g8HnqHDv4eacJW3m7pgy2CQ== X-Received: by 2002:a05:6402:51c8:b0:462:3e90:aef with SMTP id r8-20020a05640251c800b004623e900aefmr9853467edd.225.1666876651265; Thu, 27 Oct 2022 06:17:31 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4WG5IoGd03JhtEeV2BCbgETAXZm4sE01rDgjMNI1WsW17wgIrnLq3f1hku5xesfpNkmNVJ9Q== X-Received: by 2002:a05:6402:51c8:b0:462:3e90:aef with SMTP id r8-20020a05640251c800b004623e900aefmr9853449edd.225.1666876651000; Thu, 27 Oct 2022 06:17:31 -0700 (PDT) Received: from [10.43.2.105] (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id hp21-20020a1709073e1500b007919ba4295esm808161ejc.216.2022.10.27.06.17.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Oct 2022 06:17:30 -0700 (PDT) Message-ID: Date: Thu, 27 Oct 2022 15:17:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 06/11] gdb/testsuite: add XFAIL to gdb.cp/ptype-flags.exp when using clang To: Andrew Burgess , gdb-patches@sourceware.org References: <20221004170747.154307-1-blarsen@redhat.com> <20221004170747.154307-8-blarsen@redhat.com> <8735ba7k4b.fsf@redhat.com> From: Bruno Larsen In-Reply-To: <8735ba7k4b.fsf@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 26/10/2022 16:08, Andrew Burgess wrote: > Bruno Larsen via Gdb-patches writes: > >> When running gdb.cp/ptype-flags.exp using clang, we get an unexpected >> failure when printing the type of a class with an internal typedef. This >> happens because clang doesn't add accessibility information for typedefs >> inside classes (see https://github.com/llvm/llvm-project/issues/57608 >> for more info). To help with clang testing, an XFAIL was added to this >> test. >> --- >> gdb/testsuite/gdb.cp/ptype-flags.exp | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/gdb/testsuite/gdb.cp/ptype-flags.exp b/gdb/testsuite/gdb.cp/ptype-flags.exp >> index f88c83e03ce..e8d3f285803 100644 >> --- a/gdb/testsuite/gdb.cp/ptype-flags.exp >> +++ b/gdb/testsuite/gdb.cp/ptype-flags.exp >> @@ -30,11 +30,18 @@ if ![runto_main] then { >> return >> } >> >> +if {[test_compiler_info {clang-*-*}]} { >> + set using_clang true >> +} else { >> + set using_clang false >> +} > Missing the language for the test_compiler_info call. Looks good with > that fixed. Great! Can I add an Approved-by tag to the patch? Cheers, Bruno > Thanks, > Andrew > >> + >> gdb_test_no_output "set language c++" "" >> gdb_test_no_output "set width 0" "" >> >> proc do_check_holder {name {flags ""} {show_typedefs 1} {show_methods 1} >> {raw 0}} { >> + global using_clang >> >> set contents { >> { base "public Base" } >> @@ -49,6 +56,11 @@ proc do_check_holder {name {flags ""} {show_typedefs 1} {show_methods 1} >> } >> >> if {$show_typedefs} { >> + # Clang does not add accessibility information for typedefs: >> + # https://github.com/llvm/llvm-project/issues/57608 >> + if {$using_clang} { >> + setup_xfail "clang 57608" *-*-* >> + } >> lappend contents { typedef public "typedef Simple > Z;" } >> } >> >> -- >> 2.37.3