From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2062.outbound.protection.outlook.com [40.107.94.62]) by sourceware.org (Postfix) with ESMTPS id A72533858D3C for ; Wed, 30 Mar 2022 12:54:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A72533858D3C ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jbIaTHCoOHsBtZqPsR/jW37isViwycRy48XHJy4R2P+uSvSjdREYoS0/KXADoQdp/uyRuCW8qHdbZo34It9StY4Zat5tZBaba4qxJ4X8ENygQY12VTiCgUE8hHDK791tz7Y5XJDZOhJABRkCXTwRgE77k6FvUhcyQfurvM4eXJyD5Gzq+83eIvBPzAgzEbcyQYGDV2C1Vn6P9Zh8jg8ZA/ApoCDNACj7oStIQHQ0SiQW7JLv290VpSuShNvheJJ9kTJXvqxY1KWbjKxwb+q5yMoy5quj729h/uwpUkWN84k/usHjWaSrs7/LX6TMdUfoLnkhCpIQFzNQyBydaloP5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6Tu0i3fx8cDO3p4Fyfyexa1ldcNfZXI5MmE1e8Yl8JM=; b=KnX683wLO5UBtI3ZcGLSkVIWPUyFa6c9owByruUNjr3V9eoxUz53ncjsXMNqwLmJJH5rMcIIPQVnWIA75gM5ApD7sB5bqmYhw7imZrLFi10mx+kvfY12gBMpa2nxhmZHL+6STRx2a463KjdCYmt0reiGI0AN6m4MLystq5SXOJzieaw/7onVnz2n85Tri7eSyI0TaLKThHP5JDo80I/Us4gOJvJd49p7iggymGM6EQfGTj2Zs/+mq+ei0gqZt3JBBnxTv6vTbnTp3YuIJNUu9g20uYwjT0U0OqKJr95Q5t3rqAriNKGlVikq14xwsWoQMfZc+5bcXjVgjKB7Pg/uSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from PH0PR12MB5452.namprd12.prod.outlook.com (2603:10b6:510:d7::16) by MN2PR12MB4439.namprd12.prod.outlook.com (2603:10b6:208:262::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5102.18; Wed, 30 Mar 2022 12:54:22 +0000 Received: from PH0PR12MB5452.namprd12.prod.outlook.com ([fe80::a98f:62e2:7ee6:7440]) by PH0PR12MB5452.namprd12.prod.outlook.com ([fe80::a98f:62e2:7ee6:7440%7]) with mapi id 15.20.5123.021; Wed, 30 Mar 2022 12:54:22 +0000 Message-ID: Date: Wed, 30 Mar 2022 13:54:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2 2/2] gdb: Add support for DW_LNS_set_prologue_end in line-table Content-Language: en-US To: Eli Zaretskii Cc: gdb-patches@sourceware.org, lsix@lancelotsix.com References: <20220330093458.148497-1-lancelot.six@amd.com> <20220330093458.148497-3-lancelot.six@amd.com> <838rsr8w3s.fsf@gnu.org> From: Lancelot SIX In-Reply-To: <838rsr8w3s.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8P189CA0014.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:31f::34) To PH0PR12MB5452.namprd12.prod.outlook.com (2603:10b6:510:d7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 55d13530-52e1-4edb-b3d2-08da124c6955 X-MS-TrafficTypeDiagnostic: MN2PR12MB4439:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: y3bBFMHcCKxdyR89FugT7KdzfFmVAXsVUNsvQszLm9rogXraUBEJ+u/lQBvoN1EnRU7aqsJ2hb8AmV//2OfCvpq3mh4BHuZfdgwxbSdF8o91HufBr0D6sOuLc5s0DJ0KBVBb88OUJm1TWx/NnRQStQTTpxIcweGgTBRn2pjQOt8GML2/nKv0uBId9fpBPsexFB845lPHol/v8KwPeqfKLtmtgcjfQWi8waoH+YoYon/CF3E5K62i0Gxw7YxfP8WZuQtRZbOIz+zyLZihRZl5UX/3bzN7DgSglo5gMZPR6DybNAVXNRco+UWJxmDl9z6PaXC2xWInMc5WQjbxdfIaYE8i3Nrj6IDMDORoIub4WhgnOnOr7A/H+9GF8070m9Bj+BnCIbi8tDTUhgldKzMawj0k1ql4BW7JmKFmDzX6djXfMIIfb0LXNbstx/tqHkcm/UqdNAzROayXAz8hAcpX+6QtpFlSVicoh9b6/9eD1zIJsceFYpCv1PXPFjN5vu5tSnzM+Z1OSj8ss8UTpXzxQOdA1S8ghQymUwSrJVxAvsbg6JCl+c9+zYu8b6JCJc12qW4XJye8RCzOH+ECXQ58KyGnyMnwESLm+we4u9dHKlvw4kg6UyfMK1PIeJX7InDli0tkJf8R2wTwZq2ity75b0qUqCCvs1deHtAzmc6mlXryDnQrYEREb/OH74Grqx1lhF8tNOhzM+QAYZNnSfi1427xLi4+Ri8xuIcQ0iBQP5M= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR12MB5452.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(6666004)(186003)(316002)(2616005)(8676002)(4744005)(66946007)(4326008)(508600001)(6486002)(66476007)(66556008)(2906002)(31696002)(38100700002)(6512007)(8936002)(6916009)(6506007)(31686004)(36756003)(86362001)(5660300002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y1RwZzMwdlJ1MU1OcUZGY1BtYjBvZENaeFBuSTViSVA0SUpraGRBOUl0UWt6?= =?utf-8?B?a2VMRE5HblFTUFRYVzF6dkVtbElKTXBlMnFOWllRTHd2a0RobS9SNzVyZStI?= =?utf-8?B?RkRtNjc4MUl6a2RyT0JPUEl1bW1Ra0VHSnk3OEhzUitBWEYyR0ZscFAxTjRh?= =?utf-8?B?S1NnNG5yY0R2UDZJeGFtcnIreTNIMTVsZ1F6cGZmR0dFakxOc0RtQjQyMXBK?= =?utf-8?B?RWpMUC8zb21hQ3g0OTAvU2FYTXNvOWdkNmwyMDhuNWZkZmI2MnBrL2srYlVs?= =?utf-8?B?d2xuSHRvMWowS1ZZL1kzS1VFVnVlZlF5aEtpK1l0WFNDZGtBUzJzZEZoaGJZ?= =?utf-8?B?TmlmUGdRUXZjZDdzejVNR3UrTVFZQWF0b0VocEJvbzdvOGdFVWZ5b0Y3SUha?= =?utf-8?B?OHIzVVp5Nm10alFzTk9US1RyODJSRVUvZXNGWDZSeTJpbE1zSlAxZ3JxM0M4?= =?utf-8?B?cERpY0htMEtqTlQvdTd6OG55NnZ1OFNWSlVtMVMyVXRIS01YQll1UlEvL3NK?= =?utf-8?B?UFBCU0hPNWx2V3dmS2tVd2R5UlcvbGpXQktzUFJFcUlxTTY5SXFicW41Mjc0?= =?utf-8?B?RGx3cTB6RXNvZDlvbFIrVTV2OFZDU04wd3l6aGp3M0tPek1GSzV1Tm1BclNl?= =?utf-8?B?YXFOYmxYR01vZi9KcUNNa2lHSDI1K3pvQjB6eUY1UnFEMWZtdzJCZ0FpSUFw?= =?utf-8?B?c2pMdGZ0V0xUUk15dHkvRG1SMmRqWldvelhxOFVuK3N0dDQ3eFBIck5jWFVD?= =?utf-8?B?Q0pQU2J5bGdKV2JzRWVlYXpQTkZJOVdqRWJyekdkRU1ZMUlHUWs4M1k2S05M?= =?utf-8?B?MWJGSHBNbUFhSE5ESjFwdjBwM0lPeVUxYytQTG5jNld6N3ZEekJxOGJ5ZElp?= =?utf-8?B?THRTaEwrUDVOSFJjUmVBMDdvNC9JL3laR24xNWZ3b0xRVzA3Qitna0NVRml2?= =?utf-8?B?WGljMkJJSjlSRitCVHExUTlla0hCRG9sZ1N1dVpSTWk1Z1lVQ1ZMSThSbjN0?= =?utf-8?B?OUJPSndHZlU2aFJWaktEVlBGQ0l6Mm5sWk1ZWGNQTm4wRVFrQ2t6OTUwbjRv?= =?utf-8?B?SmdlQU1JRkxNMmNIekdyMkdCSUJhN3NmREVIOUtlWFNQZEM3VkVDQzhUTjBI?= =?utf-8?B?NVlDQjN1WFpnUFUvUFh3dFBkN2NERWx4bGl5T3dDcGZXSmVwZytsOVpZRFJD?= =?utf-8?B?Z2hYWnB5VnN4dlRTMmhMR0VvN01vYWRJS3dpeVZCZ1JwWTB5ZE4yMEF0SG1i?= =?utf-8?B?R1UyOUlILzNHVmFlYkxPMWFaWDZBYU1wbkZDNzZzaVZvdEp3RG00c3VSRXNK?= =?utf-8?B?WUVMdDFGYmgwY3pscE10RkEzTnF4a1RlT1krc1hiL2liTXg2T29WdVpmU0hX?= =?utf-8?B?NXhxbUNnaU05V3JrZG9JQTFsUURBTWZkOGR1T3cvY0dpWUhYYnpJbnRsdVFm?= =?utf-8?B?ZlFGa283eDJZK282MTloRHJGOEs5aEgyT2hISkUwWXRwaWpjYTRFSGlQVXd1?= =?utf-8?B?RFZORzRQbkJoY0x2RnIyRUpjd21kQncvaytzekR3RUpzdDVoRFNvbzU4L0k3?= =?utf-8?B?TWJFUENILzVvMVp3S1NWUEJYMU9VVW1OQ2wwRlRzcnpTT2hJYXZRYTIzM1c4?= =?utf-8?B?T1JwdjVXVTNKeFF2NTQzd0p5MFpZbXZEb2VzaFZRTGFNQ2I4M2pCMG05MXRO?= =?utf-8?B?YjdnYkhET3l2R3p0SXNBK2F2bFJoWTJiWkNic3lHUHBQc0l0ZDRrV1pjMGtv?= =?utf-8?B?dGNJVWhkV3duOHl6SjZUOHp2ckh4RXNPK3RSSTdZVXRqT01TcDJCU1plY2hZ?= =?utf-8?B?djUreTAwTjJtZHFOM2lleVJTWVQ4L091ODJTdzdCbUVCdmg1QTdPUkV5UkM3?= =?utf-8?B?R0h6c3hpckJpRm45bFZyYjg3R3VZWmpWekk4V2xPKyt2QWs1ZFJpR3JFVTJX?= =?utf-8?B?NFdaOWFrNHMrSTZ5MCtudUpCWTQxRmo3UkFnd2xOYkRtOEJ3dWxtaGdVV09a?= =?utf-8?B?NW53YXh3NGcyK0oyUnZzdlY4RFpjd0F3R2dQTTRyVElMeUtlSXZtMm0vd2RS?= =?utf-8?B?N21sSlJQelcrTm8zeG8vM1JOZklYOTlhUGxwQnY0c3FqdldML3U4eG05MnR3?= =?utf-8?B?V2ltaUZ5TVRJdk04dklpV1RUekVvaDlEbGhUcUdaSHNzeThCL2lQVkdoUE5h?= =?utf-8?B?RG90THA1OG92VlJVQytTNWxUcWh4Sm9zb3JDMmxGYVJCOHFpaEs4eFRWSlFE?= =?utf-8?B?UzBseUxWQlJCelV2Q0QwMzBvdFBkQWpuWFJXYnF6Z3AzeGhaYXFqaDFPY1ZC?= =?utf-8?B?QlBPSTJhcFJCc0VGOERVZ3hsTXhGL3ZKVFVsSXNseTY3SzlneFJleVNOWkhY?= =?utf-8?Q?Xyy6H/94ZHMO7t138246Y6hl1esLcUJVpeXb+?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 55d13530-52e1-4edb-b3d2-08da124c6955 X-MS-Exchange-CrossTenant-AuthSource: PH0PR12MB5452.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2022 12:54:22.4290 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CyszDDrPJoVkAYIufipy58p0P7xChL2puttzqLj7PFn06jgPA+WNe9qux6QuRpdADG3Y5p/Zo2J0IPJmtR2FHQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4439 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Mar 2022 12:54:27 -0000 Hi, > > This is also OK, but please fix this: > >> +The @samp{IS-STMT} column indicates if the address is a recommended breakpoint >> +location to represent a line or a statement. The @samp{PROLOGUE-END} column >> +indicates that a given address is an adequate to place a breakpoint at the > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > That should be "is an adequate place to set a breakpoint". > > Thanks. Thanks for catching this. I fixed it locally. Best, Lancelot.