From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84073 invoked by alias); 28 Nov 2017 01:42:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 84058 invoked by uid 89); 28 Nov 2017 01:42:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=LCD, lcd X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 28 Nov 2017 01:42:56 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E7CE9C04AC53 for ; Tue, 28 Nov 2017 01:42:54 +0000 (UTC) Received: from theo.uglyboxes.com (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AEF165D756; Tue, 28 Nov 2017 01:42:54 +0000 (UTC) Subject: Re: [PATCH v2 1/3] Handle custom completion match prefix / LCD To: Pedro Alves , gdb-patches@sourceware.org References: <1511802824-643-1-git-send-email-palves@redhat.com> <1511802824-643-2-git-send-email-palves@redhat.com> From: Keith Seitz Message-ID: Date: Tue, 28 Nov 2017 01:42:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1511802824-643-2-git-send-email-palves@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00715.txt.bz2 On 11/27/2017 09:13 AM, Pedro Alves wrote: > In v2: > > - Addresses Keith's review. The main change is that it adds a > convenience method to completion_match_result to set both regular > match and the match for LCD. This is the new > completion_match_result::set_match method. That looks okay to me. Thanks! Keith