From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cstnet.cn (smtp81.cstnet.cn [159.226.251.81]) by sourceware.org (Postfix) with ESMTPS id 701F03858D35 for ; Fri, 12 Jan 2024 09:07:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 701F03858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=iscas.ac.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 701F03858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=159.226.251.81 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705050448; cv=none; b=KRZz9utx3gBihJTn5cEXs66PDe5q+roXsYuugfrJzOheKF4ias6qzeTWtoDKttZrMpSuBKgsg7UZqQhEQdglasdliAa65Y/IF9Ty+1+6gxzUdFwmeAxOJqHSyGqNYEi5A+Dt7ikw6YHK1hp+trlw6RSGkJIxMmOZ4ROs+FZZZxc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705050448; c=relaxed/simple; bh=qkHYU7L1EMMR1lagVcYVrb3T5EWD4QmF0wqmoOWY2NM=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=EUoy1E/hYKqLhCM3W2GnVUQaIH0jM4xJpELqjIrnaW4rFQY7wCCmCTcHXl714JcGItaFXQHxhSV4ViYh63Rf6z97UQlPFu6lvz/fagC+ROd+Uqz06sDwk69oMGpKJZjUXqjxkTUTr58q8XqDESZ+rEHWGQU8Mr84zdqDGuKd49o= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.38.1.122] (unknown [113.120.165.111]) by APP-03 (Coremail) with SMTP id rQCowACn2cA3AaFlXT2SBQ--.20107S2; Fri, 12 Jan 2024 17:07:05 +0800 (CST) Message-ID: Date: Fri, 12 Jan 2024 17:07:03 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] gdb: RISC-V: Refine lr/sc sequence support To: Guinevere Larsen , Palmer Dabbelt , Andrew Burgess , Eli Zaretskii Cc: tom@tromey.com, gdb-patches@sourceware.org, simon.marchi@polymtl.ca, Eli Zaretskii References: From: Yang Liu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CM-TRANSID:rQCowACn2cA3AaFlXT2SBQ--.20107S2 X-Coremail-Antispam: 1UD129KBjvJXoWxJr1rtw4rWFW5CF1kAFyrJFb_yoW8Zry7pF WxKF1IkF4kJr4IyFs2gwn8X3WUKa13Kry7Wr1Yqw4093Z0qrySqrWxtw1YkFZrZryvgw4j vrW5Xas7uw13taDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUkIb7Iv0xC_Kw4lb4IE77IF4wAFF20E14v26r4j6ryUM7CY07I2 0VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rw A2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xII jxv20xvEc7CjxVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwV C2z280aVCY1x0267AKxVW0oVCq3wAac4AC62xK8xCEY4vEwIxC4wAS0I0E0xvYzxvE52x0 82IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGw Av7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcVAKI48JMxAI w28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr 4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0EwIxG rwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8Jw CI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2 z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7IU5qeHPUUUUU== X-Originating-IP: [113.120.165.111] X-CM-SenderInfo: 5olx5tdqjsjq5lvft2wodfhubq/ X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2024/1/12 16:43, Guinevere Larsen wrote: > On 12/01/2024 07:39, Palmer Dabbelt wrote: >> On Thu, 11 Jan 2024 22:27:32 PST (-0800), liuyang22@iscas.ac.cn wrote: >>> On 2024/1/12 02:09, Tom Tromey wrote: >>> >>>>>>>>> Yang Liu writes: >>>>> A gentle reminder: this patch has been approved for some time now, >>>>> but >>>>> I've noticed it hasn't been merged into the codebase. Has it been >>>>> overlooked? >>>> I don't really know the status of this, but if you have copyright >>>> papers >>>> in place, we can arrange for write-after-approval access. >>>> >>>> If you don't then I suspect we will need them, because this patch is >>>> over the size limit. >>> >>> I'm an employee of ISCAS (Institute of Software Chinese Academy of >>> Sciences), we've signed the copyright papers to binutils-gdb. Please >>> help arrange this. >> >> As far as I can tell the ISCAS copyright assignment includes GDB. >> Maybe Andrew just reviewed it thinking you guys had commit access?  >> I'm not exactly sure what "Approved-By" means. > > You got it right on what "Approved-By" means. Once Yang gets added to > the write-after-approval list, she is free to push this commit to the > master branch when her patch gets that tag. (Or, a maintainer can > merge her patch in without giving that access if Yang thinks she won't > contribute further). I'll probably contribute more to gdb. By the way, I go by he/him pronouns. ;) > For the complete explanation of the tags, a patch was merged recently > explaining how they work in the gdb/MAINTAINERS file. For convenience, > here's a link to the final version of the text: > https://inbox.sourceware.org/gdb-patches/20231207173415.2311804-2-blarsen@redhat.com/ > >> >> It looks generally reasonable to me, so >> >> Reviewed-by: Palmer Dabbelt >> >> if that helps any... > Hopefully this goes in soon! Thank you all for the explanations and sorting this out! Yang Liu