On 2/2/23 16:08, Simon Marchi via Gdb-patches wrote:

>
> On 1/25/23 12:03, Simon Marchi via Gdb-patches wrote:
>>
>> On 1/5/23 15:02, Simon Marchi wrote:
>>> This is the v2 of:
>>>
>>>    https://inbox.sourceware.org/gdb-patches/20221206135729.3937767-1-simon.marchi@efficios.com/
>>>
>>> I pushed patches 5, 7, 8 and 9, since I considered them good chances even
>>> outside of this series.
>>>
>>> Most other preparatory patches have been reviewed and LGTM'ed by Andrew
>>> Burgess, but they are not really useful on their own, so they are still
>>> in this series.  There are no changes in them, except a typo fix in
>>> patch 3.
>>>
>>> The only preparatory patch which was not reviewed is "gdb/solib-svr4:
>>> don't disable probes interface if probe not found".
>> Ping.
>>
>> I plan to push the series in a week from now, if there are no more
>> comments on this.  Note that this code has been heavily scrutinized by
>> Pedro and Lancelot, so I am confident that it is in good shape already.
>>
>> Simon
> I pushed the series.
>
> Simon


Hi,

as I mentioned earlier to Lancelot off-list, I'm now seeing:

...

Running /data/vries/gdb/src/gdb/testsuite/gdb.rocm/simple.exp ...
gdb compile failed, 
/data/vries/gdb/src/gdb/testsuite/gdb.rocm/simple.cpp:18:10: fatal 
error: hip/hip_runtime.h: No such file or directory
#include "hip/hip_runtime.h"
          ^~~~~~~~~~~~~~~~~~~
compilation terminated.
...

Thanks,

- Tom