From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id D32E13858D1E for ; Mon, 6 Feb 2023 11:48:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D32E13858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0E6953F410; Mon, 6 Feb 2023 11:48:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1675684102; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ffj4HrEhZq5mp2abPvIumBJ2axqIRD4CDvEeTY6tpaA=; b=wjh8efyz4TCKuy6Dz2M/Jnegz0UyrXGWfF+qShTR6M3NpSKeg2PPLrF/FMyu4ey6AixzE8 jFJlHaq6dmT3iZL2s2PXa7mcEVQIdweOvZOskTJhr3vz0BwAJyIuIFjaFa7DeNfnD5yZXh X3PHjqcHhZbxx9CBMgLB5GRn9+y9qGI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1675684102; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ffj4HrEhZq5mp2abPvIumBJ2axqIRD4CDvEeTY6tpaA=; b=GMO1/mD79dtQ2w/QBD2lEMN/uF1SjHnJ9enT9z+pUZ50diy8E9KZzb0nWMzx1dVeKQCNXA RBdjBjfNzYXXUjDA== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id DADE313334; Mon, 6 Feb 2023 11:48:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id V5xSNAXp4GP9OQAAGKfGzw (envelope-from ); Mon, 06 Feb 2023 11:48:21 +0000 Content-Type: multipart/alternative; boundary="------------QgcFNNAmVedPJBVFNrnSHixn" Message-ID: Date: Mon, 6 Feb 2023 12:47:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 0/8] Initial support for ROCm platform (AMD GPU) debugging To: Simon Marchi , Simon Marchi , gdb-patches@sourceware.org, Lancelot SIX References: <20230105200237.987771-1-simon.marchi@polymtl.ca> <5f28702a-53a9-1e8c-88d2-85e020e3b3f2@polymtl.ca> Content-Language: en-US From: Tom de Vries In-Reply-To: X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------QgcFNNAmVedPJBVFNrnSHixn Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/2/23 16:08, Simon Marchi via Gdb-patches wrote: > > On 1/25/23 12:03, Simon Marchi via Gdb-patches wrote: >> >> On 1/5/23 15:02, Simon Marchi wrote: >>> This is the v2 of: >>> >>> https://inbox.sourceware.org/gdb-patches/20221206135729.3937767-1-simon.marchi@efficios.com/ >>> >>> I pushed patches 5, 7, 8 and 9, since I considered them good chances even >>> outside of this series. >>> >>> Most other preparatory patches have been reviewed and LGTM'ed by Andrew >>> Burgess, but they are not really useful on their own, so they are still >>> in this series. There are no changes in them, except a typo fix in >>> patch 3. >>> >>> The only preparatory patch which was not reviewed is "gdb/solib-svr4: >>> don't disable probes interface if probe not found". >> Ping. >> >> I plan to push the series in a week from now, if there are no more >> comments on this. Note that this code has been heavily scrutinized by >> Pedro and Lancelot, so I am confident that it is in good shape already. >> >> Simon > I pushed the series. > > Simon Hi, as I mentioned earlier to Lancelot off-list, I'm now seeing: ... Running /data/vries/gdb/src/gdb/testsuite/gdb.rocm/simple.exp ... gdb compile failed, /data/vries/gdb/src/gdb/testsuite/gdb.rocm/simple.cpp:18:10: fatal error: hip/hip_runtime.h: No such file or directory #include "hip/hip_runtime.h"          ^~~~~~~~~~~~~~~~~~~ compilation terminated. ... Thanks, - Tom --------------QgcFNNAmVedPJBVFNrnSHixn--