From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 19B003858400 for ; Tue, 25 Jan 2022 16:27:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 19B003858400 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 20PGRAXH030425 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 Jan 2022 11:27:15 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 20PGRAXH030425 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 35FC51EE18; Tue, 25 Jan 2022 11:27:10 -0500 (EST) Message-ID: Date: Tue, 25 Jan 2022 11:27:09 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] gdb/python: allow Value.format_string to return styled output Content-Language: en-US To: Andrew Burgess Cc: gdb-patches@sourceware.org References: <20220125105005.333575-1-aburgess@redhat.com> <20220125160730.GA425591@redhat.com> From: Simon Marchi In-Reply-To: <20220125160730.GA425591@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 25 Jan 2022 16:27:10 +0000 X-Spam-Status: No, score=-3033.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Jan 2022 16:27:18 -0000 On 2022-01-25 11:07, Andrew Burgess wrote: > * Simon Marchi via Gdb-patches [2022-01-25 07:56:52 -0500]: > >> LGTM, just two small comments: >> >>> @@ -725,6 +728,7 @@ valpy_format_string (PyObject *self, PyObject *args, PyObject *kw) >>> return NULL; >>> if (!copy_py_bool_obj (&opts.static_field_print, static_members_obj)) >>> return NULL; >>> + bool styling_p = (styling_obj != nullptr) && PyObject_IsTrue (styling_obj); >> >> Can styling_obj actually be nullptr? > > Sure, the new 'styling' argument is optional, after the "|" in the > gdb_PyArg_ParseTupleAndKeywords call, so if 'styling' isn't given > styling_obj will be left as it's default value, which is nullptr. > > I guess I could initialise styling_obj to Py_False, maybe that would > be nicer? Either way, what you have is fine. It's just that I read the doc for the "O" specifier, and it says "The pointer stored is not NULL.". But that's only if the value is present. I never remember that part. Simon