public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tiezhu Yang <yangtiezhu@loongson.cn>
To: Tom Tromey <tom@tromey.com>
Cc: Hui Li <lihui@loongson.cn>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2 RESEND] gdb/elfread.c: Add plt symbol check for _PROCEDURE_LINKAGE_TABLE_
Date: Fri, 19 May 2023 09:34:25 +0800	[thread overview]
Message-ID: <db2632b8-78aa-58f5-cce6-d95af4132b10@loongson.cn> (raw)
In-Reply-To: <87v8gpplgz.fsf@tromey.com>



On 05/19/2023 02:01 AM, Tom Tromey wrote:
>>>>>> Tiezhu Yang <yangtiezhu@loongson.cn> writes:
>
>> This patch is mainly related with LoongArch and no side effects
>> on the other archs, pushed.
>
> Please don't do this in the future.  It's not ok to touch generic code
> like this under the aegis of supporting some random port.
>
> Tom
>

OK, sorry for that. For generic code, Reviewed-By or Approved-By
is necessary before pushing, I will be careful and wait more time
to receive the tags, thank you.

Thanks,
Tiezhu


      reply	other threads:[~2023-05-19  1:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-10 12:30 Hui Li
2023-04-27 11:44 ` [PING][PATCH " Hui Li
2023-05-11 11:35 ` [PATCH " Tiezhu Yang
2023-05-18 14:38   ` Tiezhu Yang
2023-05-18 18:01     ` Tom Tromey
2023-05-19  1:34       ` Tiezhu Yang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=db2632b8-78aa-58f5-cce6-d95af4132b10@loongson.cn \
    --to=yangtiezhu@loongson.cn \
    --cc=gdb-patches@sourceware.org \
    --cc=lihui@loongson.cn \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).