From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id EEC5D3858438 for ; Sun, 20 Feb 2022 01:27:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EEC5D3858438 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 21K1RLip028697 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 19 Feb 2022 20:27:26 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 21K1RLip028697 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 324441EE1A; Sat, 19 Feb 2022 20:27:21 -0500 (EST) Message-ID: Date: Sat, 19 Feb 2022 20:27:20 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 1/2] gdb: make use of std::string in dbxread.c Content-Language: en-US To: Andrew Burgess , gdb-patches@sourceware.org References: <854b644e7c6943d0668aee665203265557156a15.1645300222.git.aburgess@redhat.com> From: Simon Marchi In-Reply-To: <854b644e7c6943d0668aee665203265557156a15.1645300222.git.aburgess@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sun, 20 Feb 2022 01:27:21 +0000 X-Spam-Status: No, score=-3033.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Feb 2022 01:27:32 -0000 On 2022-02-19 14:51, Andrew Burgess via Gdb-patches wrote: > While taking a look through dbxread.c I spotted a couple of places > where making use of std::string would remove the need for manual > memory allocation and memcpy. > > There should be no user visible changes after this commit. LGTM. It's not really related, but there is the exact same code that could be changed in the exact same way in xcoffread.c, it would be nice to change it as well. Simon