From: Ulrich Weigand <Ulrich.Weigand@de.ibm.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"will_schmidt@vnet.ibm.com" <will_schmidt@vnet.ibm.com>,
"cel@us.ibm.com" <cel@us.ibm.com>
Subject: Re: [PATCH] PowerPC: Make test gdb.arch/powerpc-power10.exp Endian independent.
Date: Wed, 18 May 2022 20:29:33 +0000 [thread overview]
Message-ID: <dbab272b13102a20627b60ad4f34bd90f8e2bea3.camel@de.ibm.com> (raw)
In-Reply-To: <30abfbfb2c60a879b7235468dd31cbc736b9cad9.camel@vnet.ibm.com>
will schmidt <will_schmidt@vnet.ibm.com> wrote:
>On Tue, 2022-05-17 at 10:13 -0700, Carl Love wrote:
> >Please let me know if this patch is acceptable for
> >mainline. Thanks.
>I'd prefer this be rearranged a bit, something like " Use multiple
>.long statements to represent the 64-bit instructions so the
>instructions are properly represented in the machines native byte
>order. ... "
Agreed with Will's wording suggestions.
Otherwise, the patch is OK.
Thanks,
Ulrich
prev parent reply other threads:[~2022-05-18 20:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 17:13 Carl Love
2022-05-17 18:09 ` will schmidt
2022-05-18 20:29 ` Ulrich Weigand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbab272b13102a20627b60ad4f34bd90f8e2bea3.camel@de.ibm.com \
--to=ulrich.weigand@de.ibm.com \
--cc=cel@us.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=will_schmidt@vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).