From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id B02D23834E45 for ; Wed, 22 Jun 2022 15:11:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B02D23834E45 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 25MEFxcV006097 for ; Wed, 22 Jun 2022 15:11:55 GMT Received: from ppma01wdc.us.ibm.com (fd.55.37a9.ip4.static.sl-reverse.com [169.55.85.253]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3gv4pq9fk8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 22 Jun 2022 15:11:55 +0000 Received: from pps.filterd (ppma01wdc.us.ibm.com [127.0.0.1]) by ppma01wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 25MF6kQx010873 for ; Wed, 22 Jun 2022 15:11:54 GMT Received: from b01cxnp23034.gho.pok.ibm.com (b01cxnp23034.gho.pok.ibm.com [9.57.198.29]) by ppma01wdc.us.ibm.com with ESMTP id 3gv5cjr0dx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 22 Jun 2022 15:11:54 +0000 Received: from b01ledav002.gho.pok.ibm.com (b01ledav002.gho.pok.ibm.com [9.57.199.107]) by b01cxnp23034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 25MFBrCK33227194 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 22 Jun 2022 15:11:53 GMT Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 637D4124053; Wed, 22 Jun 2022 15:11:53 +0000 (GMT) Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E897D124052; Wed, 22 Jun 2022 15:11:52 +0000 (GMT) Received: from li-e362e14c-2378-11b2-a85c-87d605f3c641.ibm.com (unknown [9.211.68.56]) by b01ledav002.gho.pok.ibm.com (Postfix) with ESMTP; Wed, 22 Jun 2022 15:11:52 +0000 (GMT) Message-ID: Subject: [PING] [PATCH] Fix for gdb.base/stap-probe.c From: Carl Love To: gdb-patches@sourceware.org, will schmidt , Ulrich Weigand Date: Wed, 22 Jun 2022 08:11:52 -0700 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: PYNFyw41Gawal0jEp0Q0fbT-U7M8_1_c X-Proofpoint-GUID: PYNFyw41Gawal0jEp0Q0fbT-U7M8_1_c Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-06-22_04,2022-06-22_03,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 spamscore=0 clxscore=1015 adultscore=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 mlxscore=0 mlxlogscore=999 priorityscore=1501 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2206220075 X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jun 2022 15:11:57 -0000 Ping? On Tue, 2022-06-14 at 16:54 -0700, Carl Love wrote: > GDB maintainers: > > The gdb.base/stap-probe.exp test fails on Power 10 with a compile > error > due to a missing include file. The include file provides the > definition for ATTRIBUTE_NOCLONE. The following patch add the > missing > include file. > > The test now runs on Power 10 with 98 expected passes and 4 > unsupported > tests. > > Please let me know if this patch is acceptable for mainline. > > Carl Love > > --------------------------------------------------------------------- > Fix for gdb.base/stap-probe.c > > On PowePC, the test fails on a compile error: > > /../binutils-gdb-current/gdb/testsuite/gdb.base/stap-probe.c:107:1: > error: expected '=', ',', ';', > 'asm' or 'attribute' before 'use_xmm_reg' > 107 | use_xmm_reg (int val) > | ^~~~~~~~~~~ > > Where the source code for stap-probe.c is: > > ... > static const char * __attribute__((noinline)) ATTRIBUTE_NOCLONE > use_xmm_reg (int val) <-- line 107 > { > ... > > The issue is the ATTRIBUTE_NOCLONE is not defined as an attribute as > expected. The #define for ATTRIBUTE_NOCLONE can be found in > ../lib/attributes.h. > > This patch adds the missing include statement for the definition of > ATTRIBUTE_NOCLONE. > > The patch has been tested and verified on a Power10 system. > --- > gdb/testsuite/gdb.base/stap-probe.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/gdb/testsuite/gdb.base/stap-probe.c > b/gdb/testsuite/gdb.base/stap-probe.c > index d1482c35caf..527f7e187eb 100644 > --- a/gdb/testsuite/gdb.base/stap-probe.c > +++ b/gdb/testsuite/gdb.base/stap-probe.c > @@ -15,6 +15,8 @@ > You should have received a copy of the GNU General Public License > along with this program. If not, see < > http://www.gnu.org/licenses/>. */ > > +#include "../lib/attributes.h" > + > #if USE_SEMAPHORES > > #define _SDT_HAS_SEMAPHORES