From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 56473 invoked by alias); 9 Jul 2018 15:11:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 45324 invoked by uid 89); 9 Jul 2018 15:10:24 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=0.0 required=5.0 tests=none autolearn=unavailable version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Jul 2018 15:06:50 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8C0B783207; Mon, 9 Jul 2018 15:06:41 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0F8AD111DD04; Mon, 9 Jul 2018 15:06:40 +0000 (UTC) Subject: Re: [PATCH] gdb: Use add_setshow_zuinteger_unlimited_cmd in remote.c To: Andrew Burgess , gdb-patches@sourceware.org References: <20180702221146.20201-1-andrew.burgess@embecosm.com> From: Pedro Alves Message-ID: Date: Mon, 09 Jul 2018 15:11:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180702221146.20201-1-andrew.burgess@embecosm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00215.txt.bz2 Hi Andrew, Noticed a typo below. On 07/02/2018 11:11 PM, Andrew Burgess wrote: > @@ -21161,16 +21161,24 @@ > @anchor{set remote hardware-breakpoint-limit} > @item set remote hardware-watchpoint-limit @var{limit} > @itemx set remote hardware-breakpoint-limit @var{limit} > -Restrict @value{GDBN} to using @var{limit} remote hardware breakpoint or > -watchpoints. A limit of -1, the default, is treated as unlimited. > +Restrict @value{GDBN} to using @var{limit} remote hardware watchpoints > +or breakpoints. The @var{limit} can be set to 0 to disable hardware > +watchpoints or breakpoints, and @code{unilmited} for unlimited > +watchpoints or breakpoints. Typo: "unilmited" -> unlimited > Set the maximum length (in bytes) of a target hardware watchpoint."), _("\ > Show the maximum length (in bytes) of a target hardware watchpoint."), _("\ > -Specify a negative limit for unlimited."), > - NULL, NULL, /* FIXME: i18n: The maximum > - length (in bytes) of a target > - hardware watchpoint is %s. */ > +Specify \"unlimited\" to allow unlimited sized watchpoints."), While at it, a nit, shouldn't "unlimited sized" be hyphenated, being a compound adjective: unlimited-sized watchpoints. (in contrast with allowing an unlimited number of "sized watchpoints", whatever that would be.) Maybe this would be clearest: Specify \"unlimited\" to allow watchpoints of unlimited size." Thanks, Pedro Alves