From: Andrew Burgess <aburgess@redhat.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@adacore.com>,
Simon Farre <simon.farre.cx@gmail.com>,
Andrew Burgess <aburgess@redhat.com>
Subject: [PATCH] gdb/testsuite: fix race condition in gdb.python/py-thread-exited.exp
Date: Mon, 14 Aug 2023 21:58:23 +0100 [thread overview]
Message-ID: <dbfd185a6e4b6cda45034df243803c1ae1acf509.1692046670.git.aburgess@redhat.com> (raw)
I ran into a test failure on gdb.python/py-thread-exited.c. The test
creates two threads and then catches the thread exits in Python. The
test expects the threads to exit in a specific order.
As the test is currently written, it is _likely_, but not guaranteed,
that the threads will exit in the same order they are created, which
is what the test expects.
When running on a loaded system I ran into a case where the threads
exited in the reverse creation order, which caused the test to fail.
I could fix this by having the .exp file not care about the thread
order, or by changing the C file to force the order. I chose the
later, and added a pthread_barrier_t to ensure the threads exit in the
correct order.
There should be no change in what is tested after this commit.
---
gdb/testsuite/gdb.python/py-thread-exited.c | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/gdb/testsuite/gdb.python/py-thread-exited.c b/gdb/testsuite/gdb.python/py-thread-exited.c
index d62133ba59e..4df6b587935 100644
--- a/gdb/testsuite/gdb.python/py-thread-exited.c
+++ b/gdb/testsuite/gdb.python/py-thread-exited.c
@@ -24,14 +24,25 @@ pthread_t thread3_id;
void* do_thread (void* d)
{
+ if (d != NULL)
+ {
+ pthread_barrier_t *barrier = (pthread_barrier_t *) d;
+ pthread_barrier_wait (barrier);
+ }
+
return NULL; /* In thread */
}
int main (void)
{
+ /* We want the threads to exit in a known order. Use a barrier to ensure
+ the second thread doesn't exit until the first has been joined. */
+ pthread_barrier_t barrier;
+ pthread_barrier_init (&barrier, NULL, 2);
pthread_create (&thread2_id, NULL, do_thread, NULL);
- pthread_create (&thread3_id, NULL, do_thread, NULL);
+ pthread_create (&thread3_id, NULL, do_thread, &barrier);
pthread_join (thread2_id, NULL);
+ pthread_barrier_wait (&barrier);
pthread_join (thread3_id, NULL);
return 12; /* Done */
}
base-commit: 86dfe011797b3e442622d427e9abd1e0f70f3a62
--
2.25.4
next reply other threads:[~2023-08-14 20:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 20:58 Andrew Burgess [this message]
2023-08-15 13:36 ` Tom Tromey
2023-08-16 14:04 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbfd185a6e4b6cda45034df243803c1ae1acf509.1692046670.git.aburgess@redhat.com \
--to=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.farre.cx@gmail.com \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).