From: Luis Machado <lgustavo@codesourcery.com>
To: John Baldwin <jhb@FreeBSD.org>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/4] Use mips_regnum instead of constants for FreeBSD/mips register operations.
Date: Thu, 13 Apr 2017 16:31:00 -0000 [thread overview]
Message-ID: <dc38aade-39d3-7ec0-2252-6984ec89465d@codesourcery.com> (raw)
In-Reply-To: <20170412183727.22483-3-jhb@FreeBSD.org>
On 04/12/2017 01:37 PM, John Baldwin wrote:
> gdb/ChangeLog:
>
> * mips-fbsd-tdep.c (MIPS_PC_REGNUM): Remove.
> (MIPS_FP0_REGNUM): Remove.
> (MIPS_FSR_REGNUM): Remove.
> (mips_fbsd_supply_fpregs): Use mips_regnum.
> (mips_fbsd_supply_gregs): Likewise.
> (mips_fbsd_collect_fpregs): Likewise.
> (mips_fbsd_collect_gregs): Likewise.
> ---
> gdb/ChangeLog | 10 ++++++++++
> gdb/mips-fbsd-tdep.c | 29 ++++++++++++++++-------------
> 2 files changed, 26 insertions(+), 13 deletions(-)
This one looks correct to me. I have no comments.
next prev parent reply other threads:[~2017-04-13 16:31 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-12 18:37 [PATCH 0/4] Cleanups for MIPS registers (mostly FreeBSD-specific) John Baldwin
2017-04-12 18:37 ` [PATCH 1/4] Cleanups to FreeBSD/mips native register operations John Baldwin
2017-04-13 15:48 ` Luis Machado
2017-04-14 18:02 ` John Baldwin
2017-04-12 18:37 ` [PATCH 2/4] Use mips_regnum instead of constants for FreeBSD/mips " John Baldwin
2017-04-13 16:31 ` Luis Machado [this message]
2017-04-12 18:37 ` [PATCH 3/4] Consistently use fprintf_filtered when displaying MIPS registers John Baldwin
2017-04-13 16:29 ` Luis Machado
2017-04-27 16:05 ` Pedro Alves
2017-04-28 16:52 ` John Baldwin
2017-04-12 18:45 ` [PATCH 4/4] Don't throw an error in 'info registers' for unavailable MIPS GP registers John Baldwin
2017-04-13 16:37 ` Luis Machado
2017-04-14 18:02 ` John Baldwin
2017-04-15 16:02 ` Maciej W. Rozycki
2017-04-15 17:36 ` John Baldwin
2017-04-15 22:07 ` Maciej W. Rozycki
2017-04-17 18:27 ` John Baldwin
2017-04-18 21:33 ` Maciej W. Rozycki
2017-04-18 22:19 ` John Baldwin
2017-04-25 21:02 ` John Baldwin
2017-04-27 0:49 ` Maciej W. Rozycki
2017-04-27 15:50 ` Pedro Alves
2017-04-27 19:38 ` Maciej W. Rozycki
2017-04-28 13:51 ` Pedro Alves
2017-04-28 16:52 ` John Baldwin
2017-05-05 19:51 ` John Baldwin
2017-05-05 20:08 ` Maciej W. Rozycki
2017-06-12 18:47 ` John Baldwin
2017-06-15 23:50 ` Maciej W. Rozycki
2017-06-16 16:17 ` John Baldwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc38aade-39d3-7ec0-2252-6984ec89465d@codesourcery.com \
--to=lgustavo@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=jhb@FreeBSD.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).