From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 34E373952490 for ; Mon, 5 Dec 2022 21:38:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 34E373952490 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [172.16.0.64] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 7DEF41E112; Mon, 5 Dec 2022 16:38:14 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1670276294; bh=XTM781u+OXkdBHFQ3e9M+mNuQ6Ie5QAoS7tRGEp1ilU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=oyWxPUzMarRHbkqr2iqFuZEev6xNw9gyH8AqiXHYq2jQerm1ejSf50yybly3Pp5vQ 0HLDl1PxwAkmYAFRwwdw9W0PnaHV9Vb3S7QJHKnIqtz3EqBJomeDZleH5SA8e480XK 3qZFpyj3pTUgiZ8aIWu5BPYNwx3n0YQ8iZMUEUvU= Message-ID: Date: Mon, 5 Dec 2022 16:38:13 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PP?] Re: [PATCH] gdb/testsuite: remove perror calls when failing to run Content-Language: fr To: Tom Tromey , Simon Marchi via Gdb-patches Cc: Simon Marchi References: <20221129213931.108445-1-simon.marchi@efficios.com> <87h6y9k1mn.fsf@tromey.com> From: Simon Marchi In-Reply-To: <87h6y9k1mn.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/5/22 15:59, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi via Gdb-patches writes: > > Simon> The problem is that arrayptr.exp calls perror when failing to run to > Simon> main, then returns. perror makes it so that the next test (as in > Simon> pass/fail) will be recorded as UNRESOLVED. However, here, the next test > Simon> (as in pass/fail) is in the next test (as in .exp). Hence the spurious > Simon> UNRESOLVED in assign_1.exp. > > Simon> These perror when failing to run to X are not really useful, especially > Simon> since runto records a FAIL on error, by default. Remove all the > Simon> perrors on runto failure I could find. > > Thanks for doing this. I didn't read the patch, but the idea seems > sensible to me. Thanks, I pushed it. > From the dejagnu description of perror, I wonder if the gdb test suite > should ever call it: > > Declares a severe error in the testing framework itself. I don't reallt understand the point of perror. If we find a severe error, why keep running the tests (marking them as UNRESOLVED). Just throw an error / abort. > Simon> I thought of adding a check ran between test (in gdb_finish > Simon> probably) where we would emit a warning if errcnt > 0, meaning a test > Simon> quit and left a perror "active". However, reading that variable would > Simon> poke into the DejaGNU internals, not sure it's a good idea. > > Perhaps dejagnu itself should be doing this. Indeed, that would make sense. I have enough things on my plate though, I won't pursue this :). Simon