From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by sourceware.org (Postfix) with ESMTPS id A348238323E6 for ; Mon, 13 Nov 2023 14:12:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A348238323E6 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A348238323E6 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699884730; cv=none; b=SdmPBTwIjd/yKescKktigT8gmWwesZsHtH1shpO+IQHpnvr4lcvDyme+/pkNTX5twZgz1sCKQmuBUg4HrLKjX9/4B7H/vwpT0NxeUNl/hNgystCs7PbMUC0ULRZ0dYb0Ck33NJQeQXgVKfsCbCJ7Z2grA5fXw8b3gta8Pj/X7oU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699884730; c=relaxed/simple; bh=c0kjLdORjxCfs+EftDukGNlnnslpLO7MD+ULAmRurMo=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=t1hA9IsOG0O5cP+4/vCEnpBseJ2w+QMJIKofjQd8calEWhD2cmsnx4SepXE0GcovySiF5fL9hGZNb84tOHP8OsieKYnfg/LlURqNbhq9kXozE5xhnUmdTxkvlUaQHFzVefVznr8CoJD8rjezIDnKGZtnBjoAaYd+Ok64HwUGq0c= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-40839807e82so26038485e9.0 for ; Mon, 13 Nov 2023 06:12:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699884728; x=1700489528; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=D0JyLtruXSFOIB1m7f/P0jxSCNXpXzwX1ds8vBkWJio=; b=gzwGPZdT/ZIPX7puIwdVIg57RWkf9AovsmEIktRtMn8vyJkRNlpqoEw90Vqyf4umNJ dIQyyjI2VQnTFX3Vp8qxzy9TdVOfx8OqWA3Z6aY44qgD+SpqyPmsU7dkQK5J+sX8SS9b wwrcbQGLdsCkuAA8CiFZ9xi/4LGj6zHVE24uau4WyMrydS8bbH+xShECBQo9JbHvUi0d diwlDjNbWXgf2RolGDT2lofzDo3bcTON9HWV2SgZkatJ0vIAyMjY1A3hUwzCR2xZjdaH WwGn/c7MkuTfCiS+UpxYJ6q+wy5H6DtGIWKpILvbgoAOoRpetitEJ9jvD7Fsew10URkx abHw== X-Gm-Message-State: AOJu0YyIMPnWMa+12fJIFclTREZlLxkeU3tlLr8n2U6fS6+YipK/c9is A6QTWs9eVb3yZkrspAAy8YPOSfz4qC8= X-Google-Smtp-Source: AGHT+IE3rSiRRmoR6FvwAjYugh3+S7q7ovG3GUGQIsQNazxGIJWU4UYWn6T/4TgC0PWobQKpG5jpig== X-Received: by 2002:a05:600c:468a:b0:405:19dd:ad82 with SMTP id p10-20020a05600c468a00b0040519ddad82mr5852604wmo.16.1699884728155; Mon, 13 Nov 2023 06:12:08 -0800 (PST) Received: from ?IPV6:2001:8a0:f91e:1a00:8060:1e54:fb28:9635? ([2001:8a0:f91e:1a00:8060:1e54:fb28:9635]) by smtp.gmail.com with ESMTPSA id he9-20020a05600c540900b0040a48430837sm9830701wmb.13.2023.11.13.06.12.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Nov 2023 06:12:07 -0800 (PST) Message-ID: Date: Mon, 13 Nov 2023 14:12:07 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 21/31] stop_all_threads: (re-)enable async before waiting for stops Content-Language: en-US To: Andrew Burgess , gdb-patches@sourceware.org References: <20221212203101.1034916-1-pedro@palves.net> <20221212203101.1034916-22-pedro@palves.net> <87a5xaymwh.fsf@redhat.com> From: Pedro Alves In-Reply-To: <87a5xaymwh.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-06-08 16:49, Andrew Burgess wrote: > Pedro Alves writes: >> + #11 - Since the remote target is not async (disabled in #9), >> + wait_one doesn't wait on it, so it won't see the expected >> + stops, and instead returns no-resumed directly. >> + >> + #12 - stop_all_threads still haven't seen all the stops, so it >> + does another pass. goto #b, looping forever. > > s/#b/#11/ > Fixed. > Otherwise, LGTM. > > Reviewed-By: Andrew Burgess > Thanks!