From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82831 invoked by alias); 19 Jan 2018 16:48:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 82364 invoked by uid 89); 19 Jan 2018 16:48:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=remind, surround, Surround X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 19 Jan 2018 16:48:57 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4B5C7C0587C0; Fri, 19 Jan 2018 16:48:56 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 70C5D600C2; Fri, 19 Jan 2018 16:48:55 +0000 (UTC) Subject: Re: [PATCH 2/2] gdb: Add missing #ifdef USE_THREAD_DB to gdbserver To: James Clarke , gdb-patches@sourceware.org References: <20171215000434.47315-1-jrtc27@jrtc27.com> <20171215000434.47315-2-jrtc27@jrtc27.com> From: Pedro Alves Message-ID: Date: Fri, 19 Jan 2018 16:48:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171215000434.47315-2-jrtc27@jrtc27.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-01/txt/msg00402.txt.bz2 On 12/15/2017 12:04 AM, James Clarke wrote: > gdb/ChangeLog: > * gdbserver/linux-low.c (handle_extended_wait): Surround call to > thread_db_notice_clone with #ifdef USE_THREAD_DB. > --- > [Originally erroneously sent to the binutils mailing list] Looks OK, but could you remind me what goes wrong if we don't do this? Does gdbserver fail to link? Thanks, Pedro Alves