From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109538 invoked by alias); 11 Apr 2016 19:26:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 109524 invoked by uid 89); 11 Apr 2016 19:26:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=H*UA:Roundcube, H*u:Roundcube, H*r:112, H*u:1.1.3 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 11 Apr 2016 19:26:32 +0000 Received: by simark.ca (Postfix, from userid 112) id B5C961E89F; Mon, 11 Apr 2016 15:26:29 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 2079B1E03B; Mon, 11 Apr 2016 15:26:28 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 11 Apr 2016 19:26:00 -0000 From: Simon Marchi To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 4/4] Fix solib-display.exp remote check In-Reply-To: <570BECA8.3050801@redhat.com> References: <1459912543-15328-1-git-send-email-simon.marchi@polymtl.ca> <1459912543-15328-4-git-send-email-simon.marchi@polymtl.ca> <570BECA8.3050801@redhat.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.1.3 X-SW-Source: 2016-04/txt/msg00221.txt.bz2 On 2016-04-11 14:27, Pedro Alves wrote: > On 04/06/2016 04:15 AM, Simon Marchi wrote: > >> The test uses "run" > > Does it have to? Can't we use "kill" followed by runto_main > again, instead of gdb_start_cmd ? I'll check. > Why did you move the check to within the loop? I thought one > could check [target_info exists use_gdb_stub] at the top? > I'd find the patch OK with that. It'd be nicer to avoid > gdb_start_cmd in the first place, but use_gdb_stub is still > an improvement. You're right, I didn't think to check [target_info exists use_gdb_stub] directly. The global variable use_gdb_stub is only available after having spawned gdb, which is why I moved it.