From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] More const-correctness in cooked indexer
Date: Fri, 27 Jan 2023 15:11:00 -0500 [thread overview]
Message-ID: <dcd7985b-f20a-a292-a06d-69f603c18962@simark.ca> (raw)
In-Reply-To: <20230127162205.4125816-1-tromey@adacore.com>
On 1/27/23 11:22, Tom Tromey via Gdb-patches wrote:
> I noticed that iterating over the index yields non-const
> cooked_index_entry objects. However, after finalization, they should
> not be modified. This patch enforces this by adding const where
> needed.
I think you could constify these methods at the same time (it would help
me for my dump patch):
- cooked_index::wait
- cooked_index::all_entries
- cooked_index_vector::wait
- cooked_index_vector::all_entries
Otherwise, LGTM.
Simon
next prev parent reply other threads:[~2023-01-27 20:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 16:22 Tom Tromey
2023-01-27 20:11 ` Simon Marchi [this message]
2023-01-27 21:11 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dcd7985b-f20a-a292-a06d-69f603c18962@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).