public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: George Barrett <bob@bob131.so>, gdb-patches@sourceware.org
Subject: Re: [PATCH v3] guile: stop procedures on invalid breakpoints
Date: Wed, 25 Aug 2021 21:38:39 -0400	[thread overview]
Message-ID: <dcf0a7b2-e97f-2c28-14a0-2f9cec9c64ba@polymtl.ca> (raw)
In-Reply-To: <&mr9pm79twbmfxhnjpgw3f5d7fia0/vpu&msv32ihkw74tae&vx&@mail.bob131.so>

> diff --git a/gdb/testsuite/gdb.guile/scm-breakpoint.exp b/gdb/testsuite/gdb.guile/scm-breakpoint.exp
> index be898cacaa7..6964066dd34 100644
> --- a/gdb/testsuite/gdb.guile/scm-breakpoint.exp
> +++ b/gdb/testsuite/gdb.guile/scm-breakpoint.exp
> @@ -383,10 +383,45 @@ proc_with_prefix test_bkpt_eval_funcs { } {
>  	"= 4" \
>  	"check non firing same-location breakpoint eval function was also called at each stop 2"
>  
> +    # Check that stop funcs can be manipulated on invalid Scheme-created
> +    # breakpoints.
> +
> +    delete_breakpoints
> +    gdb_test "guile (print (breakpoint-valid? eval-bp1))" "= #f" \
> +	"check Scheme-created breakpoint is invalid"
> +    gdb_scm_test_silent_cmd "guile (set-breakpoint-stop! eval-bp1 (const 'test!))" \
> +	"check setting stop procedure on invalid Scheme-created breakpoint"
> +    gdb_test "guile (print ((breakpoint-stop eval-bp1)))" "= test!" \
> +	"check stop procedure on invalid Scheme-created breakpoint was successfully set"
> +
> +    # Check that stop funcs can be manipulated on breakpoint wrappers.
> +
> +    gdb_breakpoint "main"
> +    gdb_scm_test_silent_cmd "guile (define bp-wrapper (car (breakpoints)))" \
> +	"get breakpoint wrapper"
> +    gdb_test "guile (print (breakpoint-valid? bp-wrapper))" "= #t" \
> +	"check breakpoint wrapper is valid"
> +    gdb_scm_test_silent_cmd "guile (set-breakpoint-stop! bp-wrapper (const 'test!))" \
> +	"check setting stop procedure on breakpoit wrapper"

breakpoit -> breakpoint

Ok to push with that fixed, thanks.

Simon

      parent reply	other threads:[~2021-08-26  1:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-28 23:16 George Barrett
2021-08-25 18:07 ` [PING] " George Barrett
2021-08-26  1:38 ` Simon Marchi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dcf0a7b2-e97f-2c28-14a0-2f9cec9c64ba@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=bob@bob131.so \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).