From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 491E43858D3C for ; Thu, 26 Aug 2021 01:38:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 491E43858D3C Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 17Q1cef1007575 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 25 Aug 2021 21:38:45 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 17Q1cef1007575 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 513821EDF0; Wed, 25 Aug 2021 21:38:40 -0400 (EDT) Subject: Re: [PATCH v3] guile: stop procedures on invalid breakpoints To: George Barrett , gdb-patches@sourceware.org References: <&mr9pm79twbmfxhnjpgw3f5d7fia0/vpu&msv32ihkw74tae&vx&@mail.bob131.so> From: Simon Marchi Message-ID: Date: Wed, 25 Aug 2021 21:38:39 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <&mr9pm79twbmfxhnjpgw3f5d7fia0/vpu&msv32ihkw74tae&vx&@mail.bob131.so> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 26 Aug 2021 01:38:40 +0000 X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Aug 2021 01:39:00 -0000 > diff --git a/gdb/testsuite/gdb.guile/scm-breakpoint.exp b/gdb/testsuite/gdb.guile/scm-breakpoint.exp > index be898cacaa7..6964066dd34 100644 > --- a/gdb/testsuite/gdb.guile/scm-breakpoint.exp > +++ b/gdb/testsuite/gdb.guile/scm-breakpoint.exp > @@ -383,10 +383,45 @@ proc_with_prefix test_bkpt_eval_funcs { } { > "= 4" \ > "check non firing same-location breakpoint eval function was also called at each stop 2" > > + # Check that stop funcs can be manipulated on invalid Scheme-created > + # breakpoints. > + > + delete_breakpoints > + gdb_test "guile (print (breakpoint-valid? eval-bp1))" "= #f" \ > + "check Scheme-created breakpoint is invalid" > + gdb_scm_test_silent_cmd "guile (set-breakpoint-stop! eval-bp1 (const 'test!))" \ > + "check setting stop procedure on invalid Scheme-created breakpoint" > + gdb_test "guile (print ((breakpoint-stop eval-bp1)))" "= test!" \ > + "check stop procedure on invalid Scheme-created breakpoint was successfully set" > + > + # Check that stop funcs can be manipulated on breakpoint wrappers. > + > + gdb_breakpoint "main" > + gdb_scm_test_silent_cmd "guile (define bp-wrapper (car (breakpoints)))" \ > + "get breakpoint wrapper" > + gdb_test "guile (print (breakpoint-valid? bp-wrapper))" "= #t" \ > + "check breakpoint wrapper is valid" > + gdb_scm_test_silent_cmd "guile (set-breakpoint-stop! bp-wrapper (const 'test!))" \ > + "check setting stop procedure on breakpoit wrapper" breakpoit -> breakpoint Ok to push with that fixed, thanks. Simon