From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2053.outbound.protection.outlook.com [40.107.22.53]) by sourceware.org (Postfix) with ESMTPS id 80D59395C07E for ; Thu, 17 Nov 2022 10:08:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 80D59395C07E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pHTZfOy2SoBukKKmDzI6P0IzzFvYsCCaBIKqI6SN+OE=; b=tWbzRd1awCcK4fjAOkX5WijbjrPQkAVhosDPeSyTYKa2IkhrdlNHaJSn4QWTi/oG/Cd8grNsjq08FubWpILzrELShlYM7iH03ZpyEas/1mbDvVrOqr6Dc0musuq74ZugjRnNVYmcQUhSX+YzOZC73LfNiWaQS1zdjFmcNeUfndc= Received: from AM5PR0201CA0018.eurprd02.prod.outlook.com (2603:10a6:203:3d::28) by DU0PR08MB9274.eurprd08.prod.outlook.com (2603:10a6:10:41a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.6; Thu, 17 Nov 2022 10:08:43 +0000 Received: from AM7EUR03FT047.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:3d:cafe::ae) by AM5PR0201CA0018.outlook.office365.com (2603:10a6:203:3d::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.14 via Frontend Transport; Thu, 17 Nov 2022 10:08:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT047.mail.protection.outlook.com (100.127.140.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Thu, 17 Nov 2022 10:08:42 +0000 Received: ("Tessian outbound f394866f3f2b:v130"); Thu, 17 Nov 2022 10:08:42 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 8cfe518f624fbeab X-CR-MTA-TID: 64aa7808 Received: from 5b809da94751.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 80CBEDD2-8F98-458B-87B0-7BCD4F316C2D.1; Thu, 17 Nov 2022 10:08:34 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 5b809da94751.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 17 Nov 2022 10:08:34 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pl1aUlCbG4pRN1jT9zGW74ERK+64ZWniPABhV5Q9gmLOlEuJhixnAkdc+WH21x5Rm3IStbLOJbRSnZi/Fzr+kDSHDZXVWWasfofFJ/PB+UWRLcgZ8+hipD4n9Fbpz57IqeW2hirSMozf7GLuqOb46rnQMwDA8l/jVwLV6Pjq296CH5U2WRsk0l/sY6c74sqyx4OTUOf9O159/kqxwGL3z6yovW9FsxKnPq4jUzy8baCJdMZAaQfAjDjj7lrc8bIwTr756ruJxchUdjaXGPE+ORl/xp/B5JffD/ydljYZnU9OWx7cXOKu0BclhiLeaqiUEnPJwiyHkprdFaoz2u4tIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pHTZfOy2SoBukKKmDzI6P0IzzFvYsCCaBIKqI6SN+OE=; b=bATpI9AHVToXUPcCIX3JnfE9u62R9Cgs1raAJy1qWhAfzSV8P6emdV6dMHA1cYJY3+m0nOn+NGocUpb2lTRp2gJ2XT1K65I3W3wTKsZWzqaV/FHVj9iFM9W/YfyXqGGPKlL9uEMTbaz16mjm3mFpriJH25AnoE1pnERl0fgwiUXLuCyCufafQdQYKJ2rDkoNWr8LTIrZ73onH76OYed5Gyx1uYe52kcj8+gWDIwCjUNyyyn+TS0VVtOWuX3eBMfB/SDH7F4E2wIxUfBpVJgELIhAlHJA3P6dI60TfnN4qm5I1KkSOBcja77oigjzt9p0Td2pONMqEYP9Uy2JN5qUVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pHTZfOy2SoBukKKmDzI6P0IzzFvYsCCaBIKqI6SN+OE=; b=tWbzRd1awCcK4fjAOkX5WijbjrPQkAVhosDPeSyTYKa2IkhrdlNHaJSn4QWTi/oG/Cd8grNsjq08FubWpILzrELShlYM7iH03ZpyEas/1mbDvVrOqr6Dc0musuq74ZugjRnNVYmcQUhSX+YzOZC73LfNiWaQS1zdjFmcNeUfndc= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AS8PR08MB10025.eurprd08.prod.outlook.com (2603:10a6:20b:630::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Thu, 17 Nov 2022 10:08:32 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::f9e6:599b:e673:801]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::f9e6:599b:e673:801%5]) with mapi id 15.20.5834.009; Thu, 17 Nov 2022 10:08:31 +0000 Message-ID: Date: Thu, 17 Nov 2022 10:08:23 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] Fix various procfs.c compilation errors Content-Language: en-US To: Rainer Orth Cc: gdb-patches@sourceware.org References: <65dc9aec-b868-5988-e9b5-5f460d38f6d2@arm.com> From: Luis Machado In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SA9PR10CA0026.namprd10.prod.outlook.com (2603:10b6:806:a7::31) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|AS8PR08MB10025:EE_|AM7EUR03FT047:EE_|DU0PR08MB9274:EE_ X-MS-Office365-Filtering-Correlation-Id: 2c73cb5d-b639-4b12-849a-08dac883b4e7 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: oKRsL1XEMhB6KoX1VpUO4lS03VVtH3dQUYt3T3vNKlHL1SX7gAW121rmm3N6CDdOuHsmG7PXlJBinikZ4XF8r+UyFXSJm4FyleAL/TvLH1JaaPJn5wOgGJm5a2FwbMHwUR95nAjKiYZvb1MvDiTsnL0n36l9qar9n6y+cta2aVBqwe3C65yqwUW+m4QMyxaWSr7+zvraMmy7GAtMPovOflynVbPE9kE+1b+nEDmQ2qJBJRMSfZFnSxFwFoWl5saaxuOVV1sQss12rw7KwulL7jk7Fv3IgE+7iLQX4y84SdnIouWSbQO1fxk0/1UwCgegVL2HT7+HRvzvN9kxadTFI49Md88zLqJDZJOUYUsaPKgq8arw1syDTh3fHz+JuYKTqc1R1Eq5OOK8UDPO7IY1z/1hu4z0ESZesdElPd5S3PhTselocFhiRz8WoGcbUoksbrSMWqeqaYi3uK3km88lWn2UnvaAfuDhjJ2wsDWvZknh2XDxXRuBKumYLYqmwnjcD6sMXV2ANVjQ918/Q1GIm/eUAE/UmbdEB8zzpKMYhvJ9WsPm9rTvvdF0IObsc4iMdlDoh2+bq9+yZ4ylcnos240kNo5ybTLdzJdUIidTLrIN44n88DAUfEsmamR+794l+36XYEP1Xa0e6y9nqJeESQudZnLGFedNUDWssmUQFMgDLQH+jMCq8BwZCniecN/UpKm9azBvIn6gvr02SiLNqbde7sYAavwPbKB4e1tVIrw= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(136003)(376002)(346002)(396003)(39860400002)(451199015)(6506007)(2906002)(2616005)(83380400001)(44832011)(186003)(26005)(38100700002)(8936002)(53546011)(5660300002)(4326008)(6666004)(8676002)(41300700001)(6916009)(6512007)(66476007)(478600001)(66946007)(316002)(66556008)(6486002)(36756003)(31696002)(86362001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB10025 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a0299814-f175-4693-8f3f-08dac883ad95 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OQFYcOrvMoeB7lNgfQq8sZE42BsaAr6ymkMAefXNtLhVd4PTtMFyMrTi+ynQoe9p7GocKWxITq0Vzm3BY4DP1E+frVq+0FZqRme4qDYbj5hjRwqrGpbSUco1WAUreO75cuu2T+PDZ244z9Z8ohRg9k63pFZ3XYe/Q06thZHnkEXNGjmHppjm0YgjqnreN35rqvUhkHwtZRQea+K3amMXIQSORNjtdLC+h0t8oCNaA6HC63yKto0ucZ4dAudFpwybQBWp3wgfWxseEwPqq8Fz53+HmJJEX0izkZhto+buf+OJ0J/qdsFWo0AB818HL8S82MXS/CQ6MrY52+8yBOfYaPJueEq9CYBVLAVosuSOBNJvVqITJY100HXDRauHvYZq547V6dZ92Wokle5XPyiIv69NLUMaLD2XOztcMJU2ETA4dtO5vaZ6PR2CgbM3s7a/cH0HImdGo7PghRSJK7LGXCth1JY8XbnZYofRnNewnUJG77Z4KI0CklE6QdGy6ZPUYCg3cqtm4eTucXCBpvxf8se+Ptra83WLKt62fQ8MUstOqe3U/CDZB+ZlFKLRhfiXGgbtcsNFvlFC2H3IzZ9U6S0FTSSps7Wb03+PaIxmI5BX1llbh9Ikd54dgYoAEn6lzBLBV2hmzPh1XypFV3C3rgZ6esPqsIXhXTJaWFXo+jufTWoYisZDxYdTq3t0P4LGeMzBh5pJXqu6pUaEPZSQNsUTtZNQvWJWNfzsQOrEEmk= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(346002)(39860400002)(396003)(451199015)(36840700001)(46966006)(40470700004)(70586007)(83380400001)(2906002)(36860700001)(44832011)(4326008)(41300700001)(70206006)(8676002)(6862004)(5660300002)(8936002)(40460700003)(40480700001)(36756003)(81166007)(82740400003)(86362001)(31696002)(356005)(82310400005)(478600001)(6486002)(6512007)(53546011)(47076005)(31686004)(26005)(6506007)(6666004)(186003)(316002)(2616005)(336012)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 10:08:42.7064 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2c73cb5d-b639-4b12-849a-08dac883b4e7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9274 X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_ASCII_DIVIDERS,KAM_DMARC_NONE,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/17/22 09:50, Rainer Orth wrote: > Hi Luis, > >>> * find_memory_regions_callback fails with >>> /vol/src/gnu/gdb/hg/master/dist/gdb/procfs.c: In function ‘int >>> find_memory_regions_callback(prmap*, find_memory_region_ftype, void*)’: >>> /vol/src/gnu/gdb/hg/master/dist/gdb/procfs.c:3167:18: error: too few arguments to function >>> 3167 | return (*func) ((CORE_ADDR) map->pr_vaddr, >>> | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ >>> 3168 | map->pr_size, >>> | ~~~~~~~~~~~~~ >>> 3169 | (map->pr_mflags & MA_READ) != 0, >>> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>> 3170 | (map->pr_mflags & MA_WRITE) != 0, >>> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>> 3171 | (map->pr_mflags & MA_EXEC) != 0, >>> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>> 3172 | 1, /* MODIFIED is unknown, pass it as true. */ >>> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>> 3173 | data); >>> | ~~~~~ >>> Again, procfs.c was overlooked when adding the new memory_tagged arg. >>> Unfortunately, it wasn't even documented in gdb/defs.h when it was >>> added in >>> >> >> Sorry, that was an oversight. I failed to updated all the hooks. I think >> there was a BSD one that got fixed after the following commit was pushed. > > no problem: the primary issue was finding/understanding what the new arg > meant/needs to be here. > > Could you take care of updating the defs.h comment to avoid such > confusion in the future? Surely. > > Thanks. > Rainer >