From: Andrew Burgess <andrew.burgess@embecosm.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 09/11] sim/rx: add some missing includes
Date: Mon, 1 Feb 2021 11:44:12 +0000 [thread overview]
Message-ID: <dd2c85bc916211148d9857e2923a092b47577f83.1612179773.git.andrew.burgess@embecosm.com> (raw)
In-Reply-To: <cover.1612179773.git.andrew.burgess@embecosm.com>
In load.c there's some GCC warnings about undefined
functions (bfd_get_elf_phdr_upper_bound and bfd_get_elf_phdrs). To
get the declarations of these functions include 'elf-bfd.h'. This
headers also pulls in other elf related headers, like 'elf/internal.h'
and 'elf/common.h', so these no longer need to be explicitly included
from load.c.
In trace.c and include for trace.h is missing, again this results in
GCC warnings for missing function declarations.
sim/rx/ChangeLog:
* load.c: Replace 'elf/internal.h' and 'elf/common.h' includes
with 'elf-bfd.h' include.
* trace.c: Add 'trace.h' include.
---
sim/rx/ChangeLog | 6 ++++++
sim/rx/load.c | 3 +--
sim/rx/trace.c | 1 +
3 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/sim/rx/load.c b/sim/rx/load.c
index d74f4ff3872..a8a473346c6 100644
--- a/sim/rx/load.c
+++ b/sim/rx/load.c
@@ -28,8 +28,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include "cpu.h"
#include "mem.h"
#include "load.h"
-#include "elf/internal.h"
-#include "elf/common.h"
+#include "elf-bfd.h"
/* Helper function for invoking a GDB-specified printf. */
static void
diff --git a/sim/rx/trace.c b/sim/rx/trace.c
index 9d9f2dfd98d..e5db49b5ca9 100644
--- a/sim/rx/trace.c
+++ b/sim/rx/trace.c
@@ -34,6 +34,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include "cpu.h"
#include "mem.h"
#include "load.h"
+#include "trace.h"
static int
sim_dis_read (bfd_vma memaddr, bfd_byte * ptr, unsigned int length,
--
2.25.4
next prev parent reply other threads:[~2021-02-01 11:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 11:44 [PATCH 00/11] fix build warnings for rx simulator Andrew Burgess
2021-02-01 11:44 ` [PATCH 01/11] sim/rx: define sim_memory_map Andrew Burgess
2021-02-01 14:46 ` Mike Frysinger
2021-02-08 11:01 ` Andrew Burgess
2021-02-01 11:44 ` [PATCH 02/11] sim/rx: fix an issue where we try to modify a const string Andrew Burgess
2021-02-01 11:44 ` [PATCH 03/11] sim/rx: fill in missing 'void' for empty argument lists Andrew Burgess
2021-02-01 11:44 ` [PATCH 04/11] sim/rx: mark some functions as static Andrew Burgess
2021-02-01 11:44 ` [PATCH 05/11] sim/rx: delete an unused function Andrew Burgess
2021-02-01 11:44 ` [PATCH 06/11] sim/rx: use puts instead of printf in a few places Andrew Burgess
2021-02-01 14:49 ` Mike Frysinger
2021-02-08 10:58 ` Andrew Burgess
2021-02-01 11:44 ` [PATCH 07/11] sim/rx: move some variable declarations to the start of the block Andrew Burgess
2021-02-01 11:44 ` [PATCH 08/11] sim/rx: use PRIx64 in printf format string Andrew Burgess
2021-02-01 11:44 ` Andrew Burgess [this message]
2021-02-01 11:44 ` [PATCH 10/11] sim/rx: avoid pointer arithmetic on void * pointers Andrew Burgess
2021-02-01 11:44 ` [PATCH 11/11] sim/rx: enable build with warnings Andrew Burgess
2021-02-01 14:50 ` Mike Frysinger
2021-02-02 4:53 ` [PATCH] sim: erc32/m32c/rl78: add sim_memory_map stub for gdb Mike Frysinger
2021-02-08 10:57 ` [PATCH 11/11] sim/rx: enable build with warnings Andrew Burgess
2021-02-02 4:37 ` [PATCH 00/11] fix build warnings for rx simulator Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd2c85bc916211148d9857e2923a092b47577f83.1612179773.git.andrew.burgess@embecosm.com \
--to=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).