From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19215 invoked by alias); 22 Jul 2018 02:13:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19199 invoked by uid 89); 22 Jul 2018 02:13:57 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 22 Jul 2018 02:13:56 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id D8F561E077; Sat, 21 Jul 2018 22:13:54 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1532225634; bh=zJUoV9SVFWoxqvabTLSlyWAHI3qK6vacV/4olcS6z0s=; h=Subject:To:References:From:Date:In-Reply-To:From; b=SP92FSzs03exz0zdJW3wPRcjTN3KZUzQfZUb7N7hPeQG68gWQvMN0XNxZ06LECAig f3ROsCYSD9/d8yXC7NOxPSVPMAA35WuJUyPsgazd+ciYZmOu3VMXm7OJ48QdZGuqvp +5xDvYk7neunoPbT9ou5MmTlZ4R87NHM6zvTkXDU= Subject: Re: [RFA v2 10/13] Remove unused declaration from value.c To: Tom Tromey , gdb-patches@sourceware.org References: <20180721184720.3263-1-tom@tromey.com> <20180721184720.3263-11-tom@tromey.com> From: Simon Marchi Message-ID: Date: Sun, 22 Jul 2018 02:13:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180721184720.3263-11-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00649.txt.bz2 On 2018-07-21 02:47 PM, Tom Tromey wrote: > This removes an unused declaration from value_fetch_lazy_bitfield. > Because it is not completely clear if the check_typedef call is needed > somewhere beneath this function, this is broken out into a separate > patch. > > gdb/ChangeLog > 2018-07-21 Tom Tromey > > * value.c (value_fetch_lazy_bitfield): Remove unused variable. > --- > gdb/ChangeLog | 4 ++++ > gdb/value.c | 1 - > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/gdb/value.c b/gdb/value.c > index 9f9e78ece2b..af635ba5bc3 100644 > --- a/gdb/value.c > +++ b/gdb/value.c > @@ -3726,7 +3726,6 @@ value_fetch_lazy_bitfield (struct value *val) > per bitfield. It would be even better to read only the containing > word, but we have no way to record that just specific bits of a > value have been fetched. */ > - struct type *type = check_typedef (value_type (val)); > struct value *parent = value_parent (val); > > if (value_lazy (parent)) > LGTM, as discussed in v1: https://sourceware.org/ml/gdb-patches/2018-07/msg00359.html Simon