From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id BDFF1384B13A for ; Fri, 3 Sep 2021 12:37:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BDFF1384B13A Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 183CbNqS002366 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 3 Sep 2021 08:37:28 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 183CbNqS002366 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 86D321EDDB; Fri, 3 Sep 2021 08:37:23 -0400 (EDT) Subject: Re: [PATCH 2/2] gdb: Enable finish command and inferior calls for _Float16 on amd64 and i386. To: Luis Machado , "Willgerodt, Felix" , "gdb-patches@sourceware.org" References: <20210729083833.2483704-1-felix.willgerodt@intel.com> <20210729083833.2483704-3-felix.willgerodt@intel.com> <64bffa82-0520-d0aa-786b-4d81142b977f@linaro.org> <8c1dbaf9-5d1c-a1b6-6e2d-c16f456ecb6f@linaro.org> From: Simon Marchi Message-ID: Date: Fri, 3 Sep 2021 08:37:23 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <8c1dbaf9-5d1c-a1b6-6e2d-c16f456ecb6f@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 3 Sep 2021 12:37:23 +0000 X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Sep 2021 12:37:33 -0000 On 2021-07-30 8:04 a.m., Luis Machado via Gdb-patches wrote: > On 7/30/21 4:52 AM, Willgerodt, Felix wrote: >>> Is _Float16 equivalent to fp16? If so, the presence of yet another name for a >>> fp16 type is a bit unfortunate. >>> >> >> They are the same usually, but on ARM the story is apparently a bit more complex: >> https://gcc.gnu.org/onlinedocs/gcc/Half-Precision.html > > It is. :-) > >> >> But to cite the link: >> " The __fp16 type may only be used as an argument to intrinsics defined in >> , or as a storage format." >> >> And: >> "It is recommended that portable code use the _Float16 type defined by >> ISO/IEC TS 18661-3:2015." >> >> Therefore I don't think it is that unfortunate and not really negotiable by now. >> Both GCC and clang know about both already. > > The unfortunate bit is the lack of enough DWARF information to make the distinction between different float formats of the same size. If the compilers are OK with the naming and already support it, it's not a big deal then. I didn't find anything else to change in addition to what Luis already reported, so the patch is OK what that fixed. Simon