From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81]) by sourceware.org (Postfix) with ESMTPS id 81DA23858D38 for ; Mon, 22 Apr 2024 22:55:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 81DA23858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 81DA23858D38 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=96.47.72.81 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713826539; cv=pass; b=q/0ThcKQ/h/t0ekQtvlfxXz2SAn3Hu+lAOdiRVY0tK0yeiDg5kguIXFh0XmgfMDBYyefWwJ7UzEOaEPO6jcxMuxX1MdqhLDeMnkWRgiaKOGuTwbI+h51OdS9tGKpltIkFyp/35BXDlSTlom94OLjr8+bVjevhfS27DrPCDwZzwo= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713826539; c=relaxed/simple; bh=2cMRXZIqEnqaGf0Cg825p1MQA4aFoYPmFRe5J8RVuFU=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=p9tilud9gxtuTR1rZHlWcZHlyY18I/qpVC8+mh3z+80enoCySHbdsWgN9fqGmHKqlsI8PkDHaxKCYNtvYRZ3urKFcdxuuQqCEzMO99YzQ1qL1KWfCbJ2+d/HwnpREOvVyVhVyknn7GsNnFmUTN0mSE/Oaau5WsqOl8CSa8yIpWY= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4VNgZd1SS7z4ZRQ; Mon, 22 Apr 2024 22:55:37 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VNgZd0CBsz43Mf; Mon, 22 Apr 2024 22:55:37 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713826537; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=laMBs7lGGc/NR9PsudMGm5+aLKu49PkAwMGEgUtJnec=; b=XqqpiQ6lKdnjRRkVoyaoXxzfdi9jgWMN+AC1gDN/Pz4j59Zk5IbcG0QWH3/lJC9hGEe75M z33ZhHPUjp/Fm6/YZv6xNtuzkPhNvdjEw5aSMAMbaQ/k3QOwGko6cyCaNx5GkEzarQ9uXY 5ubf7ZiVKJKSLrOLaXZIjSRzDSe7gWUdnJQ7y1WotuUXWLVr/DiwdlPH7tuIuiJV4KkKdo dUqG9+yb7aKsSmTaO8HWka1U0ngdVgX/C1FPPmSd6oHtCu16W6r95vkHum0qRxN6F/+/vA hyBu+GzspD729KT1iExzU9RJsqDo0+5c9B3KKjXSFbhKtfRMtJLrMC3eSNfDPg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1713826537; a=rsa-sha256; cv=none; b=LoaJgC1OvBgMVz8HD3gigPaUXcgsbqUxQi7iAcBiufkYhQTwcjxZEASGrGiBeQ5gfw1YXr yukh6MfD+vafcEbqFgAQ2YrLy7mh2mpHJsgxTUHOsGctfMXtgP/kklXRAMdJDCWDqLtcDh 0HwqO0A2giGVoEusvg9yT9nZpwQMe+MaSTYcCiw+D28XNqL3iaP1+d7a93BwXh16isU6Pr 7bTN2MYaxh0u1Jr9Au/WMtX4S3TrA2OnWlWj7SSb/1zRHJ9Yi+sZg1ezN6FeVukneNHmYg TOVbNJKuwvmUwIXbXlTGt0Qg99SK2vhv4ppqfuyD6Tggq04+dJzvtu8R1jLe2w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713826537; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=laMBs7lGGc/NR9PsudMGm5+aLKu49PkAwMGEgUtJnec=; b=FYs74awzRqwK6CJvBbOuI+UsfXv8P7CFLpzpdxVMxl7X4dgs231o8PIOjiwhds4qp1xo3l NW5BBBgsGvL+2xRh1I6aMXy3+J3470ZpzbHiBxfVcUZ2wjtfHrEpkvrcsWDqPR5xOgoJBJ +ajI1B7e8f49/T1mEu4jZhLFaC/y7anfaM7GvBwbNgemvL0y20W90Cl7tFfUc3ED5l6yMp +EF0lX4dWP5GC1i3HrPfAELNNfp26dO0Dj5OFYJJiYwJwEQdmaGobzgane+rAdt0hbq96z ndR9Grda1nZkxE+sRJieBZy8mnwlhbBKcjyAcPMnheBSAExbT72U0+HxmikrBQ== Received: from [IPV6:2601:644:937f:4c50:48e:b274:3ff6:85b] (unknown [IPv6:2601:644:937f:4c50:48e:b274:3ff6:85b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4VNgZc4xRnzJ89; Mon, 22 Apr 2024 22:55:36 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Mon, 22 Apr 2024 15:55:34 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/7] First cleanup of defs.h Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <20240422201157.46375-1-simon.marchi@efficios.com> From: John Baldwin In-Reply-To: <20240422201157.46375-1-simon.marchi@efficios.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/22/24 1:10 PM, Simon Marchi wrote: > Here is a first batch of patches that remove things from defs.h, trying > to sort them in more appropriate places. > > Simon Marchi (7): > gdb: move two declarations out of defs.h > gdb: move `enum compile_i_scope_types` to compile/compile.h > gdb: remove extract_long_unsigned_integer > gdb: move store/extract integer functions to > extract-store-integer.{c,h} > gdb: move RequireLongest to gdbsupport/traits.h > gdb: don't include hashtab.h in defs.h > gdb: don't include gdbsupport/array-view.h in defs.h These all look ok to me. Approved-By: John Baldwin -- John Baldwin