From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by sourceware.org (Postfix) with ESMTPS id AEB023858C2B for ; Tue, 31 Jan 2023 17:05:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AEB023858C2B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i4GmSF4addvuizyZVQ/3t8XGS3yz+aRzduwhqczcfYu0QncINBVd5Nqkd3XEwjioCy0iCTpPnyg8zyY6KqLax0Gi6F5VNZ4fMnAMAT4z+gnxni/CYQS/+VgWVX5cnmFM4gOO8xdLvPSAHLxYJNhm4rghYj0Zx4XQpcp07Y901ywYpsdhK3ihhcvBJkWqa7+yFhk6FzpgSSurAizvzUJijhE82dmLL0SOXo5LKRnT3D74HYLOtFiy20up3sNvB8wGh9bi2AVjLtsz1v8NP9C4xgqFi/a9wzo35Ncr1m5Ax3QMIFBkxFdLiYVDTnwjcdnjywa/KNbk3+MF4YzXfW/3Uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S+leC8m0SXN3cUYivaUQcg/b8hDGYjUGL3bC38M1aRs=; b=SXbATKuhYu++ABwO8H4LqwXkgM7qriTPF3Ql1lVWDtUdDzaB78w6L9Ya9HrLW0lgJgB/akUOoCJxTwvzwvQZah7iJ3qzY6nVaTjURLMAxhKox4QY4AcxkyybFW2ssY4f+zc0r3zCvyBChldkjcNqcPYh9dNhsGTm+iaZapMcX/6WshAGd1jJzMYVhIQHmvZ7htHM5QiTpTHOndpppufXODxsh6Pgq20klxe+yCWR9MCwHdqBp48bC8XZoB376rZLvugT2Dzrdw9mumfnp1gWeNnTwQkqTlBJUalww5BnSmMj/YziJ+tLYrG4sI3bvtICqMy1hPv/k0NPgEjaiI2NNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S+leC8m0SXN3cUYivaUQcg/b8hDGYjUGL3bC38M1aRs=; b=T72Y59N5e5uVnmHBKqE4Xy30ZAQUzzKUu3YV7piDDDmfiDo2dh4tn55laNjQlDtv9MRrgkiwhn8xL5eDYzxhwQJH9qAVRMspemVPRa9GUV7LUD+/yMS3+qSGVq1CQO8UmZpC34CkajxUsvh9f7/K7QjC59fpnNW5Y0mlPJar80Oz8NWeaQBQqXpI/r5gsCgC1Xzv2ryql/5y/5KVK/ICiOuA2zLuTlG3Fas1N23bot/RyjfYOz5HuJFFXXOedKZZNFbIQPmtgbZa6FMKBEDH0PqWhzu5J5pi6NtgMsiiQydKl6OZ9cIMDJwzJkho7k7XDq0uWqXTBANwBJfuXNSoSA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) by YT3PR01MB5350.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:62::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.38; Tue, 31 Jan 2023 17:05:23 +0000 Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::ca4c:b759:c2f5:c976]) by YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::ca4c:b759:c2f5:c976%5]) with mapi id 15.20.6043.038; Tue, 31 Jan 2023 17:05:23 +0000 Message-ID: Date: Tue, 31 Jan 2023 12:05:21 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v3 1/8] gdbserver: Add assert in find_register_by_number Content-Language: fr To: Thiago Jung Bauermann , gdb-patches@sourceware.org References: <20230130044518.3322695-1-thiago.bauermann@linaro.org> <20230130044518.3322695-2-thiago.bauermann@linaro.org> From: Simon Marchi In-Reply-To: <20230130044518.3322695-2-thiago.bauermann@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQXP288CA0028.CANP288.PROD.OUTLOOK.COM (2603:10b6:c00:41::40) To YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT1PR01MB2828:EE_|YT3PR01MB5350:EE_ X-MS-Office365-Filtering-Correlation-Id: 34278884-7de6-4fb5-ca96-08db03ad5727 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Fi7HXWd1MQbJmXJOUWtUSdR3Nbtd6YW+DkWveV8YtUiK5FbtCiBBQ/aXjL9WoYdj4LrFBMEkH3ZX/K6wVtnsK0KIIT+yQqjMgqlnlSPz3BmRD/LwUU12oM59efczZM5PLC/Q7q7vIp/AYQ3NjPuCVbqtYVIMDgdSZ2D2hO+gF042lyaEnltevYiOEO7yhajgNsldYqDObxgmzbGnZBNhwVWem+XdXQXrp51RmxnXZ7IwxUkThwevGCQC2U04Xqr9TU6EN83sqK9zPtZgHMhpXINDgkJ3hFfSMz9OWnazO/C2EoqkSs8NWMJJrPsoG7Igmeg72v05n2nT35Blmol/Y17IS2DmcwIjVFjZTSL/UTTOzjg028q06+5MAc/IYDUFmZzvugYV58nXvE7k/lRamlYWLPxcTLXyWjlz8d9Fcn+E3iR3wqacwHNxAlz0GVPFFKGcyP2bbl0VQekTFYTMzcAnEcEjZcpFsbpg3BxrX4gv3GpY2GtBFuvNNv1m68I2R/FvrKCRnJae2bNxXCBrP28aDhG+jUmYLG3NPGMGyY8VrfqAJtQ+aqVE3Ms8iI8ZXe0/xhbL4A0+ga0T5haUfBETwIN8Z2iHE3Yz0u/vGbvv2ggk+6PVStM1UrQO0I3tC9DA1KIVpetJaXWJys3N/mb3lxL9SBGZDKQUflOv0qEPTKM2ppSuJJRjUc2RimkPnxWaVbU+GdvQduQo6UOJCKttXs+Grvyw7tW7rmxVcko= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230025)(376002)(39830400003)(136003)(396003)(346002)(366004)(451199018)(31686004)(83380400001)(31696002)(36756003)(66946007)(8676002)(66476007)(66556008)(44832011)(2906002)(41300700001)(6486002)(6506007)(478600001)(316002)(26005)(5660300002)(8936002)(38100700002)(6512007)(2616005)(53546011)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SC9PK0xGUVplVHV3Zlhla21VT2RtOHJSS0k3eWtUcjhPbFhSRWcxZmc2RVFl?= =?utf-8?B?Ty9NaC9DQUtUNnNOTjZZaWhaaTMwaGVtTkQ4dllHa3o5VmQzYmVNYm9oMHhw?= =?utf-8?B?VTVOOTlXbUFtY2h6TlgrVlZhejBDVjQ2YWhZSzhsM0dUeUpzRHgwSVJrTnpW?= =?utf-8?B?SG1vanNpSW9CanB2RnduRTMwQXFFUEQvWFRmL1BUOUlSSjI4aVZJN0FYUW03?= =?utf-8?B?dnF2RTdWcVU5YTJZYWRacnNnN2N3Zmt2OTRsOHI5a1ErektXZlQycFluRWhH?= =?utf-8?B?czdNRHAzY3VacElTT29vZXkzdDBUV3B6UWkrV1UybStHT1RwYVErQU9OZ1ZS?= =?utf-8?B?TU5FMVV0SVNhRXhDVktacXZwVGNJY2dBajdOTWllTDJubXk4MjRPc2NGaTd2?= =?utf-8?B?MC9OMXVsRDQva3ZFbU5MQThnSEVlNXZpVlNsV3FqRnAwNmNRZHo2dFFqcCtH?= =?utf-8?B?R3lNQXZDK1VLRzZtbzI5Y0N3eU4xN3k0SGdRU3RlVDJ2eEVLREJVM3R4UW1l?= =?utf-8?B?OTdJdWdnd3NodW11MmFpTEp6a0xMQjNaYnd0MXUyd0MxYUVQaXdsSlhSbEx2?= =?utf-8?B?YUxiMUlOY2NEUTBEQ1pCemNnS2grWDdpdnlKL3NMR1BobkxvREo1R05DK0dn?= =?utf-8?B?YUViMnBQZ1FQT3I1VWJOdUtDSGtsTlU1YnpRUS9EbzVtTHlnVFZEMEJiNGdC?= =?utf-8?B?akJWZnBjdGhwTnROUlNVNmNnRCtJeTZTeGNoSytqVjNITVVGSEozZXkzU3pZ?= =?utf-8?B?RzRYZmdYajMzZnozWnVLLzhLV05sVXJnOWEyRXZROXBZdHZhNXJQelk0L2tn?= =?utf-8?B?N2hVYVJSS0VLTTg5bDNNV2hucUluWWwxQS9kWTRtc2pURi9LWklXL1lZOXBL?= =?utf-8?B?SVBXYXMzanFOQ2FHUENqNXhiMmlPZWx3VWt2eERuOFVxakV1RGhYVm8rSTZD?= =?utf-8?B?bWtjQm52NkI4dzNkZXJkbHV2UzQxN1Vmc0tpTENxWTdadmpqUHNTaXo5TmU1?= =?utf-8?B?bkIvd01QTjhiN2tRTDIxLzNJem9Ra3EzNXovaUhGa1VWU1RiMDBnbnRKYnhG?= =?utf-8?B?RW56OFZPNEp0VmNlYnlsVWRYdDdiQngxS2V2S0hFM0UrSlprd3E1RURmWHF5?= =?utf-8?B?UTBoTUJRZEZuUVFpT1NnbzlyNFQyUU12b2FZNzl6bkdvbXcwYXZmaG80ZE4r?= =?utf-8?B?TnVRaXpiQjV5dzNZZU5Xd053RWZaZTYwUmhLckNBSXBWK2ZTM2owNWc3V2RO?= =?utf-8?B?cG8vU2JvdG1oVDgva1FNZms1bzM1TC9FcWJ6Z1dBL1EzL0dqS3dJOTI3SjAz?= =?utf-8?B?dXZRTGxNVkV4VHRubmNDVDJsaS81SlJKLy9wNEY1Y1BLbHA2NFBGT2lmUXY5?= =?utf-8?B?MDZiVE9NVkE0elNMUlNWTHd2TzZKNENraERDMUZBNTFuaE8zelEyVVZOQS9a?= =?utf-8?B?SUhLOHdiRWJCODExZTEzc2J1Rk41cGJTNGM2UmZtWW5wUnFITTRSSkN4bHpZ?= =?utf-8?B?WS9BV3dWalFGTEpVNG44Z0VEMlVLY1VtQ1ZpQlRrbHhCeWJ6d0dlSUpWc2Za?= =?utf-8?B?QUhjY1lrWGY5MkdvWlV4TUVFVTVPVFBJUlFNMm9mN2pXNVg5dzhhOXpiVktZ?= =?utf-8?B?YUhTekZYdGlsVEY3enFuUGZHNUVjN3ArNXZlcmVSSWhzNE5DOXZSTDNQUmpR?= =?utf-8?B?WGhwbW90c2Z0N1lRZHM2QlhRQlBOT1ZpU3pKOGgwVlc5dXBSamliYUxXUWpK?= =?utf-8?B?bEZNcUEybVMrcmJ3aHU3Uk5pWWcxLzhNK0RKY3phWjhJUitvdVhlTWxlMXlR?= =?utf-8?B?c3pkZC9XVGZFUjhyOUxnTzBxbVBLZXZKMytyd2NpZXh5Mm5jVXNQTGRwZUsr?= =?utf-8?B?djdTVUhEeHBUUS80dUxUUGZSNitMOFhjRTR0ekczMXF2a0Q1YzAyWGJSQ0lk?= =?utf-8?B?bEs1VEx1SkdyQlNRQmhLZDhOWGZZV1pVWFpkekNCUWhrd2JwWWFKYTNTbXZB?= =?utf-8?B?TXEyS2JZcFdJSXpPdXFxUmhhYnRWdEpycGJodGNLTjZieStRV2lsK2ZrSnlM?= =?utf-8?B?c1NhTFBuOUppUzRuYjl0V083UmpHcHB3bW5uVzBVcjcvcUpCZ3NJZnBqSnhF?= =?utf-8?B?RHNNcGVpUUVTaXgvTEFLNW84NVk5cGZ5cDdoLzZ5MWxqSnBwdmZGSXdQUXg3?= =?utf-8?B?eFE9PQ==?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 34278884-7de6-4fb5-ca96-08db03ad5727 X-MS-Exchange-CrossTenant-AuthSource: YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2023 17:05:23.1539 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: p8aJvHLLYebW2NWaoseJtWN4BfYHajWQRcFxbHqJkVLGIin3Hx67PgkFntjpfOygfg2TKsL06nABTHU8L2zRcw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT3PR01MB5350 X-Spam-Status: No, score=-3039.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/29/23 23:45, Thiago Jung Bauermann wrote: > It helped me during development, catching bugs closer to when they actually > happened. > > Also remove the equivalent gdb_assert in regcache_raw_read_unsigned, since > it's checking the same condition a few frames above. > > Suggested-By: Simon Marchi > --- > gdbserver/regcache.cc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gdbserver/regcache.cc b/gdbserver/regcache.cc > index 3aeefcc79a37..7b896a19767d 100644 > --- a/gdbserver/regcache.cc > +++ b/gdbserver/regcache.cc > @@ -199,6 +199,8 @@ regcache_cpy (struct regcache *dst, struct regcache *src) > static const struct gdb::reg & > find_register_by_number (const struct target_desc *tdesc, int n) > { > + gdb_assert (n >= 0 && n < tdesc->reg_defs.size ()); Since you're moving this assertion, I would suggest breaking it up in two. I general, I suggest avoiding multiple checks in a single gdb_assert. It makes it a little less obvious from the crash report which condition failed exactly. So: gdb_assert (n >= 0); gdb_assert (n < tdesc->reg_defs.size ()); The patch is fine to push right away in any case, it's good independently from the rest of the series: Approved-By: Simon Marchi Simon