From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by sourceware.org (Postfix) with ESMTPS id 0F4A63858C66 for ; Thu, 13 Apr 2023 11:56:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0F4A63858C66 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f54.google.com with SMTP id o29so2884046wro.0 for ; Thu, 13 Apr 2023 04:56:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681386978; x=1683978978; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vcrelzteOwFrSawnYvuKhS/cb7cKQ/wo9P6y3wDjQfI=; b=jPrWfo2OzEvpp+natLqq3rumLudieu7aNdFcKdMeDhVB48LxgJz6SzpR8NLomCX8+0 QTy3hS5wkNg6fD+oM/eMTpVQ2kP8cxUkhu9IAfU2lnQYO+JJ9GVCyE2NWt92iq+BcV7G 7u6ADSc1Zzt9E/EjEzAILfhkoSGcM9rkankRMCj5FeeMqHoW2cLUpRZFOHnsvHMeEWzz 6+oH9sLj9VKKJRR48wgPa67RLW2FAncQahuF8CJjk1M9F12x/AzGYKtZx5Fe5dXZgouR r+bq/wevuELwcZYvvY89Pw49w3ULGfI4UOQ3xEsDLU77KiXbVG7c0PDVKAljGPpgT/SS uWFw== X-Gm-Message-State: AAQBX9fPzTO1XrLxvGvkowOuWHjY86pzQdxsWQL7qN9pZCqE2dg4z5hA OBqzMCgywV8wYBhE6Ued/OCJNhnpT6D2pQ== X-Google-Smtp-Source: AKy350aueuV2nZ3QL8X+spqGuOyD6uOjLRAkZcvKy96VSHLPIuXIWknJqnXNVLZSrLO8tWYkA/ycNw== X-Received: by 2002:adf:e902:0:b0:2ef:ebf3:db20 with SMTP id f2-20020adfe902000000b002efebf3db20mr1580388wrm.10.1681386978384; Thu, 13 Apr 2023 04:56:18 -0700 (PDT) Received: from ?IPv6:2001:8a0:f90a:9800::1fe? ([2001:8a0:f90a:9800::1fe]) by smtp.gmail.com with ESMTPSA id l10-20020a7bc34a000000b003eeb1d6a470sm1630494wmj.13.2023.04.13.04.56.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Apr 2023 04:56:17 -0700 (PDT) Subject: Re: [PATCH] gdb: fix missing null-character when using value_cstring To: Andrew Burgess , Simon Marchi , gdb-patches@sourceware.org References: <3d7197c2-424c-1458-93aa-d23fedac3d70@simark.ca> <87r0sxb0zy.fsf@redhat.com> <56b5d8f3-463e-7a73-3cf6-4da661172d4f@palves.net> <87o7nsakuf.fsf@redhat.com> From: Pedro Alves Message-ID: Date: Thu, 13 Apr 2023 12:56:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <87o7nsakuf.fsf@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-04-12 9:47 p.m., Andrew Burgess wrote: > Pedro Alves writes: >> Hmm, this rang a bell. See this patch and following discussion: >> >> https://inbox.sourceware.org/gdb-patches/20210713153142.3957666-1-simon.marchi@efficios.com/ >> > > Thanks for pointing that out. > > I guess from the age of that patch it's not something you're planning to > get back to anytime soon. I assume you'd have no objections if I > rebased your patch and merged it with my tests and reposted it? > No objections at all. Please feel free to use anything from it.