From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 6536F3842435 for ; Mon, 20 Feb 2023 09:55:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6536F3842435 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676886916; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QIDCzX3+ugyPwmZoCeLAWnG+fWc4yEHFPi7e4tVncq4=; b=dipi4+9bsy1hzicPhL6sb3YpvLKF+A9EsanPj79kwnK/pAEcptIrXWXUpVelHdeL15nytV nKddE5MSYIvj+TcNQ6LVE3zX0ytQvhW1fLKjvAfV8P/C7Ju0SfHpwunLJhmOFgwcUQ6UOx jfWysOeO/+tca/Zvxoj/nmwf9TlMOs0= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-318-YKlMCUuzMeOHkHqKm_uUVg-1; Mon, 20 Feb 2023 04:55:15 -0500 X-MC-Unique: YKlMCUuzMeOHkHqKm_uUVg-1 Received: by mail-qv1-f69.google.com with SMTP id s13-20020ad44b2d000000b00570ccb820abso358495qvw.5 for ; Mon, 20 Feb 2023 01:55:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QIDCzX3+ugyPwmZoCeLAWnG+fWc4yEHFPi7e4tVncq4=; b=CoDtpYxT9BWhu4BF7Icvbq8XILxm9fjxFgVOePTh8XIxy0pfE4gqDFiVKNZv0MQ5I0 5M1F1N0v6Rguxo5zn9v939nEtvx1qsRfnrKJKxjc/GNn5vNN0VIc/XdfgMQeA5myxm8p P267sqH/gC36lE53G3ppzEb0FWW6iojO1SQRrJOnbjFqBGpNwziLJUtxwExNuJ132M0l 1hRdVylE3QXFB/u9FgDGTZjXBIfmXm/LA9vWGg0bQY6ujpGl9XqB4kL/4sn0xz1MfoDj ENfp9tmUSswHYVJ1vwNz4wIzZxo7YU971AWSQC4ktWIunKRFKQzazk/c4XHD7mB3xKlA p30A== X-Gm-Message-State: AO0yUKWNVO/hrAl0fjbj0R5tvK5H/Kf6knUrRlsCVDNoDeqqbmEbZ3se X2xNVeBucI47Y5QSGX0nCPpGpS/Xxm6UtlBPH7ruQflofmC5lHFdVvpJ948q5wNge3PUFZXlgvQ /MzrwU5WPixJYgq9W8MEpChsGOIE= X-Received: by 2002:ac8:5e4c:0:b0:3bd:7a6:67a2 with SMTP id i12-20020ac85e4c000000b003bd07a667a2mr24549782qtx.27.1676886914443; Mon, 20 Feb 2023 01:55:14 -0800 (PST) X-Google-Smtp-Source: AK7set8FKp2+7W9ExPk2Q6t1DZeN5g3OvMwX23CE2j0FLUMASHVxZCmwOpgCGRziR1bckbj3kdKfkQ== X-Received: by 2002:ac8:5e4c:0:b0:3bd:7a6:67a2 with SMTP id i12-20020ac85e4c000000b003bd07a667a2mr24549778qtx.27.1676886914250; Mon, 20 Feb 2023 01:55:14 -0800 (PST) Received: from [192.168.0.45] (ip-94-112-225-44.bb.vodafone.cz. [94.112.225.44]) by smtp.gmail.com with ESMTPSA id d1-20020ac84e21000000b003b82489d8acsm8487386qtw.21.2023.02.20.01.55.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Feb 2023 01:55:13 -0800 (PST) Message-ID: Date: Mon, 20 Feb 2023 10:55:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] Issue error on erroneous expression To: Tom Tromey , gdb-patches@sourceware.org References: <20230218155747.3723021-1-tom@tromey.com> From: Bruno Larsen In-Reply-To: <20230218155747.3723021-1-tom@tromey.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 18/02/2023 16:57, Tom Tromey wrote: > A while back I discovered that this does not issue an error: > > (gdb) p $x = (void * ) 57 > $3 = (void *) 0x39 > (gdb) p $x + 7 = 3 > $6 = (void *) 0x3 > > This patch fixes the bug. > Regression tested on x86-64 Fedora 36. > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=19312 Hi Tom, This seems like a pretty obvious fix, and I also don't see any regressions. Reviewed-By: Bruno Larsen -- Cheers, Bruno