From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 70DAE3858D37 for ; Tue, 4 Oct 2022 16:43:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 70DAE3858D37 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A30151F8C4 for ; Tue, 4 Oct 2022 16:43:08 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 92E95139EF for ; Tue, 4 Oct 2022 16:43:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id qbudIpxiPGNjMAAAMHmgww (envelope-from ) for ; Tue, 04 Oct 2022 16:43:08 +0000 Content-Type: multipart/mixed; boundary="------------x02ezhdlMfJp0b3OhomP9Vmo" Message-ID: Date: Tue, 4 Oct 2022 18:43:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH][gdb/symtab] Factor out have_complaint Content-Language: en-US From: Tom de Vries To: gdb-patches@sourceware.org References: <20221004151058.GA20304@delia.home> <6eee2cfa-f428-12fe-4808-039373ef7bd0@suse.de> In-Reply-To: <6eee2cfa-f428-12fe-4808-039373ef7bd0@suse.de> X-Spam-Status: No, score=-13.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Oct 2022 16:43:11 -0000 This is a multi-part message in MIME format. --------------x02ezhdlMfJp0b3OhomP9Vmo Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/4/22 17:51, Tom de Vries wrote: > On 10/4/22 17:10, Tom de Vries via Gdb-patches wrote: >> Hi, >> >> After committing 8ba677d3560 ("[gdb/symtab] Don't complain about function >> decls") I noticed that quite a bit of code in read_func_scope is used >> to decide >> whether to issue the "cannot get low and high bounds for subprogram >> DIE at >> $hex" complaint, which executes unnecessarily if we have the default >> "set complaints 0". >> >> Fix this by (NFC): >> - factoring out new static function have_complaint from macro >> complaint, and >> - using it to wrap the relevant code in read_func_scope. >> >> Tested on x86_64-linux. >> >> Any comments? >> > > Well, I didn't check properly, this doesn't even build, I'll repost once > I got a properly build & tested version. And here it is. Thanks, - Tom --------------x02ezhdlMfJp0b3OhomP9Vmo Content-Type: text/x-patch; charset=UTF-8; name="0001-gdb-symtab-Factor-out-have_complaint.patch" Content-Disposition: attachment; filename="0001-gdb-symtab-Factor-out-have_complaint.patch" Content-Transfer-Encoding: base64 W2dkYi9zeW10YWJdIEZhY3RvciBvdXQgaGF2ZV9jb21wbGFpbnQKCkFmdGVyIGNvbW1pdHRp bmcgOGJhNjc3ZDM1NjAgKCJbZ2RiL3N5bXRhYl0gRG9uJ3QgY29tcGxhaW4gYWJvdXQgZnVu Y3Rpb24KZGVjbHMiKSBJIG5vdGljZWQgdGhhdCBxdWl0ZSBhIGJpdCBvZiBjb2RlIGluIHJl YWRfZnVuY19zY29wZSBpcyB1c2VkIHRvIGRlY2lkZQp3aGV0aGVyIHRvIGlzc3VlIHRoZSAi Y2Fubm90IGdldCBsb3cgYW5kIGhpZ2ggYm91bmRzIGZvciBzdWJwcm9ncmFtIERJRSBhdAok aGV4IiBjb21wbGFpbnQsIHdoaWNoIGV4ZWN1dGVzIHVubmVjZXNzYXJpbHkgaWYgd2UgaGF2 ZSB0aGUgZGVmYXVsdAoic2V0IGNvbXBsYWludHMgMCIuCgpGaXggdGhpcyBieSAoTkZDKToK LSBmYWN0b3Jpbmcgb3V0IG5ldyBzdGF0aWMgZnVuY3Rpb24gaGF2ZV9jb21wbGFpbnQgZnJv bSBtYWNybyBjb21wbGFpbnQsIGFuZAotIHVzaW5nIGl0IHRvIHdyYXAgdGhlIHJlbGV2YW50 IGNvZGUgaW4gcmVhZF9mdW5jX3Njb3BlLgoKVGVzdGVkIG9uIHg4Nl82NC1saW51eC4KCi0t LQogZ2RiL2NvbXBsYWludHMuaCAgfCAxMSArKysrKysrKysrLQogZ2RiL2R3YXJmMi9yZWFk LmMgfCAzMSArKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tCiAyIGZpbGVzIGNoYW5n ZWQsIDI3IGluc2VydGlvbnMoKyksIDE1IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2dk Yi9jb21wbGFpbnRzLmggYi9nZGIvY29tcGxhaW50cy5oCmluZGV4IDY4Yzc5YmQ2ZDBhLi4w MmM4YzJjNTU4YiAxMDA2NDQKLS0tIGEvZ2RiL2NvbXBsYWludHMuaAorKysgYi9nZGIvY29t cGxhaW50cy5oCkBAIC0zMSw2ICszMSwxNSBAQCBleHRlcm4gdm9pZCBjb21wbGFpbnRfaW50 ZXJuYWwgKGNvbnN0IGNoYXIgKmZtdCwgLi4uKQogCiBleHRlcm4gaW50IHN0b3Bfd2hpbmlu ZzsKIAorLyogUmV0dXJuIHRydWUgaWYgY29tcGxhaW50cyBhcmUgZW5hYmxlZC4gIFRoaXMg Y2FuIGJlIHVzZWQgdG8gZ3VhcmQgY29kZQorICAgdGhhdCBpcyB1c2VkIG9ubHkgdG8gZGVj aWRlIHdoZXRoZXIgdG8gaXNzdWUgYSBjb21wbGFpbnQuICAqLworCitzdGF0aWMgaW5saW5l IGJvb2wKK2hhdmVfY29tcGxhaW50ICgpCit7CisgIHJldHVybiBzdG9wX3doaW5pbmcgPiAw OworfQorCiAvKiBSZWdpc3RlciBhIGNvbXBsYWludC4gIFRoaXMgaXMgYSBtYWNybyBhcm91 bmQgY29tcGxhaW50X2ludGVybmFsIHRvCiAgICBhdm9pZCBjb21wdXRpbmcgY29tcGxhaW50 J3MgYXJndW1lbnRzIHdoZW4gY29tcGxhaW50cyBhcmUgZGlzYWJsZWQuCiAgICBSdW5uaW5n IEZNVCB2aWEgZ2V0dGV4dCBbaS5lLiwgXyhGTVQpXSBjYW4gYmUgcXVpdGUgZXhwZW5zaXZl LCBmb3IKQEAgLTM4LDcgKzQ3LDcgQEAgZXh0ZXJuIGludCBzdG9wX3doaW5pbmc7CiAjZGVm aW5lIGNvbXBsYWludChGTVQsIC4uLikJCQkJCVwKICAgZG8JCQkJCQkJCVwKICAgICB7CQkJ CQkJCQlcCi0gICAgICBpZiAoc3RvcF93aGluaW5nID4gMCkJCQkJCVwKKyAgICAgIGlmICho YXZlX2NvbXBsYWludCAoKSkJCQkJCVwKIAljb21wbGFpbnRfaW50ZXJuYWwgKEZNVCwgIyNf X1ZBX0FSR1NfXyk7CQlcCiAgICAgfQkJCQkJCQkJXAogICB3aGlsZSAoMCkKZGlmZiAtLWdp dCBhL2dkYi9kd2FyZjIvcmVhZC5jIGIvZ2RiL2R3YXJmMi9yZWFkLmMKaW5kZXggOGU0MmMw ZjRkOGQuLjc4ZjRjYzFmNjBkIDEwMDY0NAotLS0gYS9nZGIvZHdhcmYyL3JlYWQuYworKysg Yi9nZGIvZHdhcmYyL3JlYWQuYwpAQCAtMTIwNDMsMjAgKzEyMDQzLDIzIEBAIHJlYWRfZnVu Y19zY29wZSAoc3RydWN0IGRpZV9pbmZvICpkaWUsIHN0cnVjdCBkd2FyZjJfY3UgKmN1KQog ICBpZiAoZHdhcmYyX2dldF9wY19ib3VuZHMgKGRpZSwgJmxvd3BjLCAmaGlnaHBjLCBjdSwg bnVsbHB0ciwgbnVsbHB0cikKICAgICAgIDw9IFBDX0JPVU5EU19JTlZBTElEKQogICAgIHsK LSAgICAgIGF0dHIgPSBkd2FyZjJfYXR0ciAoZGllLCBEV19BVF9leHRlcm5hbCwgY3UpOwot ICAgICAgYm9vbCBleHRlcm5hbF9wID0gYXR0ciAhPSBudWxscHRyICYmIGF0dHItPmFzX2Jv b2xlYW4gKCk7Ci0gICAgICBhdHRyID0gZHdhcmYyX2F0dHIgKGRpZSwgRFdfQVRfaW5saW5l LCBjdSk7Ci0gICAgICBib29sIGlubGluZWRfcAotCT0gKGF0dHIgIT0gbnVsbHB0cgotCSAg ICYmIGF0dHItPmlzX25vbm5lZ2F0aXZlICgpCi0JICAgJiYgKGF0dHItPmFzX25vbm5lZ2F0 aXZlICgpID09IERXX0lOTF9pbmxpbmVkCi0JICAgICAgIHx8IGF0dHItPmFzX25vbm5lZ2F0 aXZlICgpID09IERXX0lOTF9kZWNsYXJlZF9pbmxpbmVkKSk7Ci0gICAgICBhdHRyID0gZHdh cmYyX2F0dHIgKGRpZSwgRFdfQVRfZGVjbGFyYXRpb24sIGN1KTsKLSAgICAgIGJvb2wgZGVj bF9wID0gYXR0ciAhPSBudWxscHRyICYmIGF0dHItPmFzX2Jvb2xlYW4gKCk7Ci0gICAgICBp ZiAoIWV4dGVybmFsX3AgJiYgIWlubGluZWRfcCAmJiAhZGVjbF9wKQotCWNvbXBsYWludCAo XygiY2Fubm90IGdldCBsb3cgYW5kIGhpZ2ggYm91bmRzICIKLQkJICAgICAiZm9yIHN1YnBy b2dyYW0gRElFIGF0ICVzIiksCi0JCSAgIHNlY3Rfb2Zmc2V0X3N0ciAoZGllLT5zZWN0X29m ZikpOworICAgICAgaWYgKGhhdmVfY29tcGxhaW50ICgpKQorCXsKKwkgIGF0dHIgPSBkd2Fy ZjJfYXR0ciAoZGllLCBEV19BVF9leHRlcm5hbCwgY3UpOworCSAgYm9vbCBleHRlcm5hbF9w ID0gYXR0ciAhPSBudWxscHRyICYmIGF0dHItPmFzX2Jvb2xlYW4gKCk7CisJICBhdHRyID0g ZHdhcmYyX2F0dHIgKGRpZSwgRFdfQVRfaW5saW5lLCBjdSk7CisJICBib29sIGlubGluZWRf cAorCSAgICA9IChhdHRyICE9IG51bGxwdHIKKwkgICAgICAgJiYgYXR0ci0+aXNfbm9ubmVn YXRpdmUgKCkKKwkgICAgICAgJiYgKGF0dHItPmFzX25vbm5lZ2F0aXZlICgpID09IERXX0lO TF9pbmxpbmVkCisJCSAgIHx8IGF0dHItPmFzX25vbm5lZ2F0aXZlICgpID09IERXX0lOTF9k ZWNsYXJlZF9pbmxpbmVkKSk7CisJICBhdHRyID0gZHdhcmYyX2F0dHIgKGRpZSwgRFdfQVRf ZGVjbGFyYXRpb24sIGN1KTsKKwkgIGJvb2wgZGVjbF9wID0gYXR0ciAhPSBudWxscHRyICYm IGF0dHItPmFzX2Jvb2xlYW4gKCk7CisJICBpZiAoIWV4dGVybmFsX3AgJiYgIWlubGluZWRf cCAmJiAhZGVjbF9wKQorCSAgICBjb21wbGFpbnQgKF8oImNhbm5vdCBnZXQgbG93IGFuZCBo aWdoIGJvdW5kcyAiCisJCQkgImZvciBzdWJwcm9ncmFtIERJRSBhdCAlcyIpLAorCQkgICAg ICAgc2VjdF9vZmZzZXRfc3RyIChkaWUtPnNlY3Rfb2ZmKSk7CisJfQogICAgICAgcmV0dXJu OwogICAgIH0KIAo= --------------x02ezhdlMfJp0b3OhomP9Vmo--