From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50225 invoked by alias); 21 May 2018 13:19:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 49761 invoked by uid 89); 21 May 2018 13:19:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:513 X-Spam-User: qpsmtpd, 2 recipients X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 21 May 2018 13:19:27 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w4LDJLuS003781 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 21 May 2018 09:19:25 -0400 Received: by simark.ca (Postfix, from userid 112) id 2C38A1F21B; Mon, 21 May 2018 09:19:21 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id B2CA21E512; Mon, 21 May 2018 09:19:20 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 21 May 2018 14:12:00 -0000 From: Simon Marchi To: "H.J. Lu" Cc: binutils@sourceware.org, gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] Move gdb/common/diagnostics.h to include/diagnostics.h In-Reply-To: <20180521121557.16535-1-hjl.tools@gmail.com> References: <20180521121557.16535-1-hjl.tools@gmail.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 21 May 2018 13:19:21 +0000 X-IsSubscribed: yes X-SW-Source: 2018-05/txt/msg00479.txt.bz2 On 2018-05-21 08:15, H.J. Lu wrote: > Move gdb/common/diagnostics.h to include/diagnostics.h so that it can > be used in binutils. > > gdb/ > > * ada-lex.l: Include "diagnostics.h" instead of > "common/diagnostics.h". > * unittests/environ-selftests.c: Likewise. > * common/diagnostics.h: Moved to ../include. > > include/ > > * diagnostics.h: Moved from ../gdb/common/diagnostics.h. This series looks OK from the GDB side. Thanks, Simon