From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id B39453858D3C for ; Sun, 27 Nov 2022 18:41:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B39453858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 2CFB71E0D3; Sun, 27 Nov 2022 13:41:19 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1669574479; bh=qSIkUYFB59eRtncZX6aurvvJyoPbt1vBnHqkHZhfLZQ=; h=Date:Subject:To:References:From:In-Reply-To:From; b=TlcbpdHKp9BZn2DDgQlZocTz89jgtvrpIhU31V1FZqap6sBW8ht/KsE+ftpCz5Fbt sGVm7Lqd/UADjtH5AQ2IDLEd43sSE0NukqnC/a0Z0BEbhugxr5mbMnKICZGOjKOVJ4 PlTcCGHE0vLBJjn+mv0IAXuaH2dwuyLejIXbSRtI= Message-ID: Date: Sun, 27 Nov 2022 13:41:18 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [RFA] fix leak in gdb_environ Content-Language: en-US To: Philippe Waroquiers , gdb-patches@sourceware.org References: <20221127182504.867308-1-philippe.waroquiers@skynet.be> From: Simon Marchi In-Reply-To: <20221127182504.867308-1-philippe.waroquiers@skynet.be> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/27/22 13:25, Philippe Waroquiers via Gdb-patches wrote: > valgrind reports a leak when assigning a gdb_environ to another gdb_environ. > The memory allocated for the target gdb_environ env variables is not released. > The gdb_environ selftest reproduces the leak (see below). > Fix the leak by clearing the target gbd_environ before std::move-ing the gbd_environ -> gdb_environ Otherwise: Approved-By: Simon Marchi Simon