From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2068.outbound.protection.outlook.com [40.107.21.68]) by sourceware.org (Postfix) with ESMTPS id 7432E3857BB2 for ; Thu, 26 May 2022 07:22:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7432E3857BB2 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=S7GnF3Npc69zeX92yXwoKJkJG5q6sw9ibiKs+hXCvwBiaRXIxuNoYWBbdZFetWCMElom0V0rRxAwveqjiuEwBbYFOznuxU9jVYiNYyVdCk6XOap872Slbh4bgJJ9R6QNyzEny9kI3S5XLryRWNI40RUOq5r/X4nrW02srpNBsXQYKGAoggT1tIXjxNM8rRsJqpDFD8hw9uaiXmHuhCJ8onxTINzhUBTKnxo8C2/zCIG7vKDltXYQSolcNqSrMk9n9YfJBCkjSQOxqJHH0OtuAMLoTVzWjaEXNbvLbfrf4njZNvcBj6huWM4nDecLuwNpT1Ka0A0yvReDYqATqhfMwg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7H73ALXkCn9KAHvfru0TYo4kAxxEoiOz82KlTUqrQ6Y=; b=F58sXs+evRqDDkZvDZ7K1pYcrsxAlGwQoPXRUYcN58W0nebKe22X1MZQhTyTFQ81OR3jx8rllz/YJNO9IdfVs8npdcpwegFzzYQpPXXGSXM6mm+esJtCCO3Fsv5se7nMDhyM54mTil8S7uk4Tqsml33AKX0IuGeW8wxBAcjtiEU0RRA4ebzGif2dwMC0op7Iu1o5jXmBgNUfUJrMfy3HBmtdQkKkYYdSKBPS9gbRJkFJ6Bk14eqVKdyfziB7LQLg/jC7MFGg6+GYWZtpxrgYSu/g+IVkNL2anobV5qNeizO2uCHGziy0iDHJasqVwx5FoU5Jfmk1g/Qf/P3nfLe1MA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from AS8PR04CA0081.eurprd04.prod.outlook.com (2603:10a6:20b:313::26) by VI1PR08MB2783.eurprd08.prod.outlook.com (2603:10a6:802:19::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17; Thu, 26 May 2022 07:22:19 +0000 Received: from AM5EUR03FT019.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:313:cafe::d9) by AS8PR04CA0081.outlook.office365.com (2603:10a6:20b:313::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Thu, 26 May 2022 07:22:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT019.mail.protection.outlook.com (10.152.16.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Thu, 26 May 2022 07:22:19 +0000 Received: ("Tessian outbound 07c1c99345b0:v119"); Thu, 26 May 2022 07:22:18 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 49ddb04fdbc5a685 X-CR-MTA-TID: 64aa7808 Received: from b9e577e6da21.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2D4AA76E-41E6-46CE-8C73-D6ABD67250D8.1; Thu, 26 May 2022 07:22:13 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b9e577e6da21.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 26 May 2022 07:22:12 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HH0jDVyK/+9D57q4PRibHUcPka3I/JMi1LpQGKx67NCwawVvGGSPQmzEA4cbCh0Y8HEqjEjOb8o31FHoh4YYrurd3FLOiihcTHm+hzYupz8Bu1IKPJ6M8W9ZT7OKgHY8soAmbfW++f9W/UQuDVFqIGH5TLmLh1y2L90l+C8kFmO6Gw0Il2pwkg/i2yp/Q3dd8r1xUD/hA6jBrB3vNTkYN5oCG/KLgvwYVVONHecRiti4gT+dJLoEYT4vzN5Z38FJVulixcvjxE90EYDtI4lCVq2+k0PMBAcpfDwq68E3hNKATqeeXiJq2jdLBxToNC8Am6FzTfsHEl9m/8Z2lovC8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7H73ALXkCn9KAHvfru0TYo4kAxxEoiOz82KlTUqrQ6Y=; b=m7Ulp2evfCDEaUl2WOnVXC/fDISWv2a19MdU/jHW475txO9kClwH0sARo8ptSJeX7Xr+Dtf3aRSthweLBStiGVYKZ1arkx33XTkJAEujGNMBbr5km6RlovQsUdbUurE94QBYBCcfvCieiMpUoavqvdbxm8qvjFMr6WttBRYsQMAASkwulLSPdHHzULdmtQ13H58LYZhgv5AmrSjL3hV3EUj0PVjVKJCdYfm0kbPI4iB9rmYf2FO07fyfsIP2yYViamHX/6LWYf7CgTFSfSZOKQ8R8xAOyop2avxMd88dlbTg9a8oXy84QAqBkJ4QCYaXb1oolOaB4LNpBFy7fxCqcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AM0PR08MB5123.eurprd08.prod.outlook.com (2603:10a6:208:15b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 26 May 2022 07:22:11 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::7080:6233:cf8f:a8a6]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::7080:6233:cf8f:a8a6%7]) with mapi id 15.20.5273.023; Thu, 26 May 2022 07:22:11 +0000 Message-ID: Date: Thu, 26 May 2022 08:22:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] Move 64-bit BFD files from ALL_TARGET_OBS to ALL_64_TARGET_OBS Content-Language: en-US To: Pedro Alves , gdb-patches@sourceware.org References: <20220503111913.563509-1-luis.machado@arm.com> <4099d8e4-54e1-0579-a4f4-15a40d4942a5@arm.com> <715abbd2-18bb-28b5-f30b-6d92ca42e8ca@arm.com> <4a965c5f-0ddf-f6e6-2578-8b45fb526611@arm.com> From: Luis Machado In-Reply-To: <4a965c5f-0ddf-f6e6-2578-8b45fb526611@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0080.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:190::13) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 8d35155c-10de-4908-7149-08da3ee877f5 X-MS-TrafficTypeDiagnostic: AM0PR08MB5123:EE_|AM5EUR03FT019:EE_|VI1PR08MB2783:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 0g0Hs3hU2rm2lL0QgvnHckB4UwV0vNYd2nl6vWV9UtkLaS9+fHkg1V8EY/8+Udz4Vdi1joGvUeoKSVh534zJWvRK3WkHzZegB8/VUN/LHkHf1RCFxbF68A99fG7uJUH+1Vu9GWkLptHu9KvwOEu5da6BqxbIrxx5/sAXJC81LsqHkLEzpOngev3YGnSCQA4Uefqv7ROmxmziXYLwga9ms8hnNW0MA6cfd8NbFTtmenAB35oD5OVP1INf/8VWW9V3Td0dd9PGIGH5N5/RgYiXh0BEUA5h0d4CdOAarolv1i2Uzm6B1ELKEN20Nvgr/YvVJHi/Zs5sNxQr5CGdA7ixW9tvmGOXTq2A6QJL8L/bOvT9MSsXR5XAoN85Gq12aWcNvISzdFM+P0sF+aeNrHLeuGlXKo5qRYoIj+Bpw93zYsKSPX0bjwAPibwPkGqtNGRpl8U2Eo42kBXgvT6lTY6VDnleshn9EfkW0q2byGzJ4DSCyBSPUDuZn32+bBdaE/AInjUJmhs+7eMOyHyAwzG8ZXapxvGQwtibRQ5dKbvFPTjRZFyQ/LRCXN8XIFb57kKKvtSAsgRusJ1pfZuqKRnVkgomWIYclSXKdJw15ccvrd91wNJbWNfpKMCZtHNWC1Nk+EcK1T6WnphzdkfBwhA6BbElFOm+DYiBs2fljQST8mmvqTF1EyMR+mZWpnRSUNm1Z2LtVTHDPSg0hxG2ovM2gJ9mEEUMKkRjNhT+1g0JnTHLzYxNVUosWLHfHv8NLaWIZSapk8hLE9b+X7iOeh9KpVTA6/ep9Qve1iz4F9q3vBYoWXtdiA6pPyWbA0I0evGPChq0LF2cJZZQI+gvI3rCXyAI61FPl3BxuXdi/XUMZkk= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(6486002)(186003)(6512007)(26005)(508600001)(966005)(36756003)(2906002)(31686004)(66476007)(66946007)(83380400001)(66556008)(38100700002)(5660300002)(86362001)(2616005)(8676002)(316002)(53546011)(8936002)(6506007)(31696002)(44832011)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5123 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b80558b1-a4e4-45b1-cdcf-08da3ee872ef X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ndbpha7l+0e1RaXpo3kx7GficPK1a8Woomq8McaJBYUTt+pjgtg+efQ16X2vdKXY9c3Ddv0PiDx0HSIIyNQhDr80KfP2NtN7VFDMSiVF1NHTQzXfkX4x9jpSwvqI4GwCVMeplIcPVFWOaf+K/4lHZ+XpS9fHBTd89UiNxmDfDk1t4+SmI55RWfTwHog/tf26xDyoJn0lJpZDdnKsbmu4C0NsNMi1rpR96PpXgh7GFUeoCnsIx3LcSBLoBXWzwlJQXdPE0AFn5ZNSIv16Y2NZW8L7GiZhvkrJkg4Y89u638Vq4fQO7SdnHkaZOYZEF8y+9a0slb9ZQfeWq7iLTZrBTwQBN+axzAogKAUWsiU/REsQ+8/b6JlcEaChRE49v49kvQ8+cY4ipiXBy8mEOme7KR2/xwwaxs9mrh2vUU8BePsx7zwOVw1ZGhB5a0TgOc9/iHMb5FIQxpAlvNr+Lw2/MhJv3YtKC3eMgHLCtyzHPJ/wELP2q6tAabYpXdSjwFomy7uBUTQ5tkUY/6JhkV8VF32/r2vPyTCuxh/jOHDyGZ7gbYsWt6Xd92mfUT0KCzjinFmMQI3ZoZh+JcQHr6RX4MK6fvhhkMu5BctV5gkQZPx82jlsJklzDo7HXuB73GgLwLPqg/9mCuMZnS9LvcHgWeCVaCQtOtD86enTW/z2rUj9WJPcPRk2x30aJFPinnOgK+WiQp9OHrOCFrP+AMV48cRwm1u1pE0PUSK2eYrVmf2ldsIX2/sngegwVA0ilY3NvyhYgcpbXV3mmoy7b0yPfONy4a2VcqgCVQzRqDfPbN6GONG+hPPc+Pdr+5gX+LwMVIH/QslMDroJQlEo2h19kA== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(82310400005)(316002)(44832011)(6512007)(36860700001)(36756003)(2616005)(70206006)(70586007)(47076005)(336012)(31686004)(186003)(6506007)(86362001)(81166007)(8676002)(26005)(31696002)(508600001)(8936002)(966005)(6486002)(53546011)(2906002)(40460700003)(83380400001)(5660300002)(356005)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2022 07:22:19.1636 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8d35155c-10de-4908-7149-08da3ee877f5 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB2783 X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 May 2022 07:22:24 -0000 On 5/5/22 10:06, Luis Machado via Gdb-patches wrote: > On 5/3/22 22:51, Luis Machado via Gdb-patches wrote: >> On 5/3/22 12:30, Luis Machado via Gdb-patches wrote: >>> On 5/3/22 12:24, Pedro Alves wrote: >>>> On 2022-05-03 12:19, Luis Machado via Gdb-patches wrote: >>>> >>>>> --- >>>>>   gdb/Makefile.in | 13 +++++++------ >>>>>   1 file changed, 7 insertions(+), 6 deletions(-) >>>>> >>>>> diff --git a/gdb/Makefile.in b/gdb/Makefile.in >>>>> index 418094775a5..d80087749de 100644 >>>>> --- a/gdb/Makefile.in >>>>> +++ b/gdb/Makefile.in >>>>> @@ -715,9 +715,12 @@ ALL_64_TARGET_OBS = \ >>>>>       arch/aarch64-mte-linux.o \ >>>>>       arch/amd64.o \ >>>>>       arch/riscv.o \ >>>>> +    bpf-tdep.o \ >>>>>       ia64-linux-tdep.o \ >>>>>       ia64-tdep.o \ >>>>>       ia64-vms-tdep.o \ >>>>> +    loongarch-linux-tdep.o \ >>>>> +    loongarch-tdep.o \ >>>>>       mips-fbsd-tdep.o \ >>>>>       mips-linux-tdep.o \ >>>>>       mips-netbsd-tdep.o \ >>>>> @@ -734,7 +737,10 @@ ALL_64_TARGET_OBS = \ >>>>>       sparc64-netbsd-tdep.o \ >>>>>       sparc64-obsd-tdep.o \ >>>>>       sparc64-sol2-tdep.o \ >>>>> -    sparc64-tdep.o >>>>> +    sparc64-tdep.o \ >>>>> +    tilegx-linux-tdep.o \ >>>>> +    tilegx-tdep.o >>>>> + >>>> >>>> Spurious empty line. >>> >>> Fixed now. >>> >>>> >>>> In opcodes, tilegx is in TARGET32_LIBOPCODES_CFILES.  So why did we need to move that one? >>> >>> *sigh*... I think that needs to be fixed as well. >>> >>> opcodes/disassemble.c defines ARCH_tilegx if BFD64 is defined, which makes it a 64-bit BFD target. So a 32-bit build makes it not register a disassembler function (leading to GDB internal errors). >>> >>> TILE-Gx is a 64-bit core according to https://en.wikipedia.org/wiki/TILE-Gx. So I suppose we need to move it from TARGET32_LIBOPCODES_CFILES to TARGET64_LIBOPCODES_CFILES. >> >> Patch to binutils sent here: https://sourceware.org/pipermail/binutils/2022-May/120651.html > > I've pushed the binutils patch. Are there any objections to the gdb-side patch? Ping? 32-bit builds with --enable-targets=all are still failing due to the misplacement of these places. If we drop the tilegx change, would that be acceptable?