From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9793 invoked by alias); 9 Apr 2018 19:35:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9726 invoked by uid 89); 9 Apr 2018 19:35:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=yours X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Apr 2018 19:35:31 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3EDA2EBFEA; Mon, 9 Apr 2018 19:35:30 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 92F3C16791; Mon, 9 Apr 2018 19:35:29 +0000 (UTC) Subject: Re: [PATCH] Add selftests for range_contains and insert_into_bit_range_vector To: Simon Marchi , Simon Marchi , gdb-patches@sourceware.org References: <20180407143801.19596-1-simon.marchi@polymtl.ca> <09d2a032-8726-6351-ab9a-63574734a3e5@ericsson.com> From: Pedro Alves Message-ID: Date: Mon, 09 Apr 2018 19:35:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <09d2a032-8726-6351-ab9a-63574734a3e5@ericsson.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-04/txt/msg00165.txt.bz2 On 04/09/2018 08:01 PM, Simon Marchi wrote: > On 2018-04-07 02:33 PM, Pedro Alves wrote: >> See patch below on top of yours implementing most of the suggestions >> above, except the missing comments. >> >> WDYT? > > I agree with all your suggested changes. Here is the merged patch I would push. > I also changed "test_range_contains" to "test_ranges_contain" to match the name > of the function. Thanks, please push. Pedro Alves