From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by sourceware.org (Postfix) with ESMTPS id AF711385840B for ; Thu, 4 Nov 2021 13:04:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AF711385840B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f45.google.com with SMTP id 71so4448662wma.4 for ; Thu, 04 Nov 2021 06:04:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=Hgt2BrA+Pc6w1+zM88M2iBEEdMRq+pYK9dbLyZ0uL8E=; b=xYHdXtYR/gotv2sS4A4goNUMp4gSkCFuJzOKJKhYNS1kxSWlpipIUpjHQOsLqrFdA3 VyAhK+bur3pQ5iqCrXY4oORCS4okH8xMC6wbbzjyqG0Ci71m6FdlGGGJBRqrCln3Zzny UXT1E61XhFEeoReSYJb6dbgRy67aPKSunYyHCOOQUnRqhYySpfG03bzMcI3rPpoIz1cf ZagtiEuzUMzDYL+hsHt2GxlkVolM7dT3gmTzNuYluAhYz31swROscR5NIyLwUM8W4ntZ YCLHBFGqtIcVa1NnPCw14EkxyI1OG/PsUxPckZkreXGmMgiNkZ9ZPhkGOp/BR/z22tFS 11kg== X-Gm-Message-State: AOAM530O6VGHfIAMd48aKy4l5ozFbqcrP0Vt4pHYOV3YlmR7LoEoOTUM 1e462lFh9bALgrkS0Rk57vXfDC25WB4Vhw== X-Google-Smtp-Source: ABdhPJwoggDXrH+Gg4+Nd+FocZVskk3XPWa8tehim69AAdmZdNxkd7ttMh86f6mRDM0O0cGJKWddeQ== X-Received: by 2002:a05:600c:b52:: with SMTP id k18mr22812416wmr.167.1636031065671; Thu, 04 Nov 2021 06:04:25 -0700 (PDT) Received: from ?IPV6:2001:8a0:f912:1a00:fb57:3faf:e98:b979? ([2001:8a0:f912:1a00:fb57:3faf:e98:b979]) by smtp.gmail.com with ESMTPSA id g13sm4632746wmk.37.2021.11.04.06.04.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Nov 2021 06:04:24 -0700 (PDT) Message-ID: Date: Thu, 4 Nov 2021 13:04:23 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH v2 2/2] Improve gdb::array_view ctor from contiguous containers Content-Language: en-US To: Lancelot SIX , gdb-patches@sourceware.org References: <8acafb4f-ef32-2de8-e71f-8243386b8159@palves.net> <20211103222015.50988-1-lsix@lancelotsix.com> From: Pedro Alves In-Reply-To: <20211103222015.50988-1-lsix@lancelotsix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2021 13:04:32 -0000 On 2021-11-03 22:20, Lancelot SIX wrote: > +/* Check that there is no slicing when build a view from a contiguous > + container. */ > + The sentence is slightly ungrammatical. I guess that with "when build a view", you meant either: -> "when building a view", or, -> "when we build a view" Alternatively, you could mirror the comment from the built-in array tests: /* Check that there's no container->view conversion for containers of derived types or subclasses. */ In any case, this is OK. Thanks for fixing this!