From: Pedro Alves <palves@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] Add gdb.ada/info_addr_mixed_case new testcase
Date: Fri, 05 Jan 2018 16:06:00 -0000 [thread overview]
Message-ID: <df24ad9b-c3ab-5d83-a213-91847b9d6ad5@redhat.com> (raw)
In-Reply-To: <20180105032155.kn553rit4365f6bb@adacore.com>
On 01/05/2018 03:21 AM, Joel Brobecker wrote:
> Patch looks good to me. Intuitively, it looks like a more logical
> way to perform things too. And with the new SEARCH_SYMBOL searching
> mechanism coming, I can see us being able later to to avoid the "<...>"
> wrapping too.
>
> Just in case, I tested that patch against our testsuite, and I can
> confirm it fixes the issue without introducing regressions :).
>
> Thanks for having looked into this, Pedro. I will focus my attention
> on creating the branch, do a review or two, and then continue analyzing
> my testsuite report.
Great, I've pushed this one in, both master and branch.
I have fixes for the other testcases / regressions. I'll post them
in a bit.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2018-01-05 16:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-04 8:36 FYI/pushed: Additional tests showing regression post C++ wild matching Joel Brobecker
2018-01-04 8:36 ` [PATCH 1/3] Add gdb.ada/info_addr_mixed_case new testcase Joel Brobecker
2018-01-04 13:25 ` Pedro Alves
2018-01-04 18:33 ` Pedro Alves
2018-01-05 3:22 ` Joel Brobecker
2018-01-05 16:06 ` Pedro Alves [this message]
2018-01-04 8:36 ` [PATCH 2/3] Add "complete break ada" test to gdb.ada/complete.exp Joel Brobecker
2018-01-05 16:37 ` [PATCH] Fix gdb.ada/complete.exp's "complete break ada" test (PR, gdb/22670) (Re: [PATCH 2/3] Add "complete break ada" test to gdb.ada/complete.exp) Pedro Alves
2018-01-08 4:05 ` Joel Brobecker
2018-01-04 8:36 ` [PATCH 3/3] Add new gdb.ada/bp_c_mixed_case testcase for PR gdb/22670 Joel Brobecker
2018-01-05 16:34 ` Fix gdb.ada/bp_c_mixed_case.exp (PR gdb/22670) (Re: [PATCH 3/3] Add new gdb.ada/bp_c_mixed_case testcase for PR gdb/22670) Pedro Alves
2018-01-08 3:57 ` Joel Brobecker
2018-01-08 15:00 ` Pedro Alves
2018-01-09 9:46 ` Joel Brobecker
2018-01-09 14:59 ` Pedro Alves
2018-01-09 16:45 ` Pedro Alves
2018-01-09 17:22 ` Pedro Alves
2018-01-10 3:36 ` Joel Brobecker
2018-01-10 23:41 ` Pedro Alves
2018-01-11 4:00 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df24ad9b-c3ab-5d83-a213-91847b9d6ad5@redhat.com \
--to=palves@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).