From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82518 invoked by alias); 5 Jan 2018 16:06:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 82508 invoked by uid 89); 5 Jan 2018 16:06:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=our X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 05 Jan 2018 16:06:50 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 591CE61D0D; Fri, 5 Jan 2018 16:06:49 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 09F025D9C7; Fri, 5 Jan 2018 16:06:46 +0000 (UTC) Subject: Re: [PATCH 1/3] Add gdb.ada/info_addr_mixed_case new testcase To: Joel Brobecker References: <1515054953-81012-1-git-send-email-brobecker@adacore.com> <1515054953-81012-2-git-send-email-brobecker@adacore.com> <5c1398c0-0b8a-f480-551c-d1c2c65daed8@redhat.com> <20180105032155.kn553rit4365f6bb@adacore.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Fri, 05 Jan 2018 16:06:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180105032155.kn553rit4365f6bb@adacore.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-01/txt/msg00098.txt.bz2 On 01/05/2018 03:21 AM, Joel Brobecker wrote: > Patch looks good to me. Intuitively, it looks like a more logical > way to perform things too. And with the new SEARCH_SYMBOL searching > mechanism coming, I can see us being able later to to avoid the "<...>" > wrapping too. > > Just in case, I tested that patch against our testsuite, and I can > confirm it fixes the issue without introducing regressions :). > > Thanks for having looked into this, Pedro. I will focus my attention > on creating the branch, do a review or two, and then continue analyzing > my testsuite report. Great, I've pushed this one in, both master and branch. I have fixes for the other testcases / regressions. I'll post them in a bit. Thanks, Pedro Alves