From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89620 invoked by alias); 7 Jul 2018 02:01:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 89459 invoked by uid 89); 7 Jul 2018 02:01:02 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=remotec, remote.c, UD:remote.c, from_tty X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 07 Jul 2018 02:01:01 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id BBC811E08D; Fri, 6 Jul 2018 22:00:59 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1530928859; bh=oCnVQFcth0BWCzGyQaFGlD2pOAm5QgC1glULJ9pM40M=; h=Subject:To:References:From:Date:In-Reply-To:From; b=QOauS0FusV/zZi7glC4LjNDqZtQjHsEEutNTP7gLXyCNmoVHGXph+a+1ADk9PuJ/o W5c1E4KDvu0hwrm0rr89KK0FY/EKyZgdArsdKhaIb4U+IexfS9+2zfLOmpA4E7Qxcr yA6R4pM3t9yq8RiTpgIp12zwX2H3QNVQIU7LO60w= Subject: Re: [PATCH] gdb: Use add_setshow_zuinteger_unlimited_cmd in remote.c To: Andrew Burgess , gdb-patches@sourceware.org References: <20180702221146.20201-1-andrew.burgess@embecosm.com> From: Simon Marchi Message-ID: Date: Sat, 07 Jul 2018 02:01:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180702221146.20201-1-andrew.burgess@embecosm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00160.txt.bz2 On 2018-07-02 06:11 PM, Andrew Burgess wrote: > @@ -1728,6 +1728,36 @@ show_memory_write_packet_size (const char *args, int from_tty) > show_memory_packet_size (&memory_write_packet_config); > } > > +/* Show the number of hardware watchpoints that can be used. */ > + > +static void > +show_hardware_watchpoint_limit (struct ui_file *file, int from_tty, > + struct cmd_list_element *c, const char *value) > +{ > + fprintf_filtered (file, _("The maximum number of target hardware " > + "watchpoints is %s.\n"), value); > +} > + > +/* Show the length limit (in bytes) for hardware watchpoints. */ > + > +static void > +show_hardware_watchpoint_length_limit (struct ui_file *file, int from_tty, > + struct cmd_list_element *c, const char *value) This line is too long. Otherwise, LGTM. Thanks! Simon