public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: Patrick Monnerat <patrick@monnerat.net>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Notify observer of breakpoint auto-disabling
Date: Mon, 16 Aug 2021 10:04:34 -0400	[thread overview]
Message-ID: <df9896b0-706d-c11f-bf04-62d492e38c31@polymtl.ca> (raw)
In-Reply-To: <20210816124420.255018-1-patrick@monnerat.net>

On 2021-08-16 8:44 a.m., Patrick Monnerat via Gdb-patches wrote:
> As breakpoint_modified observer is currently notified upon breakpoint stop
> before handling auto-disabling when enable count is reached, the observer
> is never notified of the disabling.
> 
> The problem affects:
> - The MI interpreter enabled= value when reporting =breakpoint-modified
> - A Python event handler for breakpoint_modified using the "enabled"
>   member of its parameter
> - insight: breakpoint GUI window is not properly updated upon auto-disable
> 
> This patch moves the observer notification after the auto-disabling
> code and implements corresponding tests for the MI and Python cases.
> 
> Fixes https://sourceware.org/bugzilla/show_bug.cgi?id=23336

Thanks, this is ok to push.  Do you have push access?  Would you like to
push this on your behalf?

Simon

  reply	other threads:[~2021-08-16 14:04 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-16 12:44 Patrick Monnerat
2021-08-16 14:04 ` Simon Marchi [this message]
2021-08-16 14:09   ` Patrick Monnerat
2021-08-16 15:10     ` Simon Marchi
2021-08-16 16:18       ` Patrick Monnerat
  -- strict thread matches above, loose matches on Subject: below --
2021-08-15  0:33 Patrick Monnerat
2021-08-16  1:32 ` Simon Marchi
2021-08-13 22:24 Patrick Monnerat
2021-08-14  4:05 ` Simon Marchi
2021-08-15  0:30   ` Patrick Monnerat
2021-08-13 15:31 Patrick Monnerat
2021-08-13 15:45 ` Simon Marchi
2021-08-13 16:27   ` Patrick Monnerat
2021-08-13 18:59     ` Simon Marchi
2021-08-13 22:15       ` Patrick Monnerat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=df9896b0-706d-c11f-bf04-62d492e38c31@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=patrick@monnerat.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).