* [RFA] Remove exit_inferior_num_silent
@ 2018-07-03 15:54 Tom Tromey
2018-07-03 16:44 ` Pedro Alves
0 siblings, 1 reply; 2+ messages in thread
From: Tom Tromey @ 2018-07-03 15:54 UTC (permalink / raw)
To: gdb-patches; +Cc: Tom Tromey
The sole caller of exit_inferior_num_silent was getting the inferior's
number to then use the number to look up the inferior again. I think
it's better to simply not have exit_inferior_num_silent; any potential
callers that only have the inferior's number should probably be
converted to pass the inferior itself around instead.
Tested by the buildbot.
gdb/ChangeLog
2018-07-03 Tom Tromey <tom@tromey.com>
* infrun.c (follow_exec): Use exit_inferior_silent.
* inferior.c (exit_inferior_num_silent): Remove.
* inferior.h (exit_inferior_num_silent): Don't declare.
---
gdb/ChangeLog | 6 ++++++
gdb/inferior.c | 8 --------
gdb/infrun.c | 2 +-
3 files changed, 7 insertions(+), 9 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 8ecf370e599..0841703435f 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2018-07-03 Tom Tromey <tom@tromey.com>
+
+ * infrun.c (follow_exec): Use exit_inferior_silent.
+ * inferior.c (exit_inferior_num_silent): Remove.
+ * inferior.h (exit_inferior_num_silent): Don't declare.
+
2018-07-03 Tom Tromey <tom@tromey.com>
PR cli/23340:
diff --git a/gdb/inferior.c b/gdb/inferior.c
index ab506f6aec5..22beea58a0c 100644
--- a/gdb/inferior.c
+++ b/gdb/inferior.c
@@ -250,14 +250,6 @@ exit_inferior_silent (inferior *inf)
exit_inferior_1 (inf, 1);
}
-void
-exit_inferior_num_silent (int num)
-{
- struct inferior *inf = find_inferior_id (num);
-
- exit_inferior_1 (inf, 1);
-}
-
/* See inferior.h. */
void
diff --git a/gdb/infrun.c b/gdb/infrun.c
index 28a4391c358..2eb25c03cda 100644
--- a/gdb/infrun.c
+++ b/gdb/infrun.c
@@ -1190,7 +1190,7 @@ follow_exec (ptid_t ptid, char *exec_file_target)
/* Do exit processing for the original inferior before adding
the new inferior so we don't have two active inferiors with
the same ptid, which can confuse find_inferior_ptid. */
- exit_inferior_num_silent (current_inferior ()->num);
+ exit_inferior_silent (current_inferior ());
inf = add_inferior_with_spaces ();
inf->pid = pid;
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [RFA] Remove exit_inferior_num_silent
2018-07-03 15:54 [RFA] Remove exit_inferior_num_silent Tom Tromey
@ 2018-07-03 16:44 ` Pedro Alves
0 siblings, 0 replies; 2+ messages in thread
From: Pedro Alves @ 2018-07-03 16:44 UTC (permalink / raw)
To: Tom Tromey, gdb-patches
On 07/03/2018 04:53 PM, Tom Tromey wrote:
> The sole caller of exit_inferior_num_silent was getting the inferior's
> number to then use the number to look up the inferior again. I think
> it's better to simply not have exit_inferior_num_silent; any potential
> callers that only have the inferior's number should probably be
> converted to pass the inferior itself around instead.
>
> Tested by the buildbot.
>
> gdb/ChangeLog
> 2018-07-03 Tom Tromey <tom@tromey.com>
>
> * infrun.c (follow_exec): Use exit_inferior_silent.
> * inferior.c (exit_inferior_num_silent): Remove.
> * inferior.h (exit_inferior_num_silent): Don't declare.
OK.
Thanks,
Pedro Alves
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-03 16:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-03 15:54 [RFA] Remove exit_inferior_num_silent Tom Tromey
2018-07-03 16:44 ` Pedro Alves
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).