From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72942 invoked by alias); 3 Jul 2018 16:44:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 72928 invoked by uid 89); 3 Jul 2018 16:44:58 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Jul 2018 16:44:57 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D288B406C7A9; Tue, 3 Jul 2018 16:44:55 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5E56C2026D76; Tue, 3 Jul 2018 16:44:55 +0000 (UTC) Subject: Re: [RFA] Remove exit_inferior_num_silent To: Tom Tromey , gdb-patches@sourceware.org References: <20180703155355.23180-1-tom@tromey.com> From: Pedro Alves Message-ID: Date: Tue, 03 Jul 2018 16:44:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180703155355.23180-1-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00058.txt.bz2 On 07/03/2018 04:53 PM, Tom Tromey wrote: > The sole caller of exit_inferior_num_silent was getting the inferior's > number to then use the number to look up the inferior again. I think > it's better to simply not have exit_inferior_num_silent; any potential > callers that only have the inferior's number should probably be > converted to pass the inferior itself around instead. > > Tested by the buildbot. > > gdb/ChangeLog > 2018-07-03 Tom Tromey > > * infrun.c (follow_exec): Use exit_inferior_silent. > * inferior.c (exit_inferior_num_silent): Remove. > * inferior.h (exit_inferior_num_silent): Don't declare. OK. Thanks, Pedro Alves