From: Pedro Alves <palves@redhat.com>
To: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Move DWARF index-related things to a separate file
Date: Mon, 26 Mar 2018 22:23:00 -0000 [thread overview]
Message-ID: <e019a36f-543e-ba6f-bb16-e9d2726ad1f3@redhat.com> (raw)
In-Reply-To: <1522098518-30931-1-git-send-email-simon.marchi@ericsson.com>
On 03/26/2018 10:08 PM, Simon Marchi wrote:
> I want to add a DWARF index-related feature (automatically produce index
> files when loading objfiles in GDB), but I don't want to add many
> hundred lines to the already too big dwarf2read.c. I thought it would
> be a logical split to move everything related to the DWARF index to its
> own file.
>
> I first tried to move everything that reads and writes DWARF indices to
> a separate file, but found that the "read" part is a little bit
> entangled with the rest of dwarf2read.c, so the line is hard to draw
> about where to split. The write part is quite isolated though, so I
> moved this part to a new file, dwarf-index-write.c. Some things are
> necessary to both reading and writing indices, so I placed them in
> dwarf-index-common.{c,h}. The idea would be to have a
> dwarf-index-read.c eventually that would use it too (for now that code
> is still in dwarf2read.c).
>
> This required moving some things to a new dwarf2read.h header, so they
> can be read by the code that writes the index.
>
> The patch is big in number of lines, but it's all existing code being
> moved around. The only changes are that some functions are not static
> anymore, a declaration is added in a .h file, and therefore the comment
> is moved there.
>
> I built-tested it with a little and big endian target.
>
> This patch is also available on the users/simark/split-dwarf2read
> branch.
+1 for splitting dwarf2read.c.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2018-03-26 22:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-26 21:09 Simon Marchi
2018-03-26 22:23 ` Pedro Alves [this message]
2018-03-27 12:46 ` Joel Brobecker
2018-03-27 14:12 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e019a36f-543e-ba6f-bb16-e9d2726ad1f3@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).