From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54722 invoked by alias); 30 Apr 2019 16:31:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 54658 invoked by uid 89); 30 Apr 2019 16:31:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy= X-HELO: mail-wm1-f43.google.com Received: from mail-wm1-f43.google.com (HELO mail-wm1-f43.google.com) (209.85.128.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 30 Apr 2019 16:31:25 +0000 Received: by mail-wm1-f43.google.com with SMTP id h18so4546338wml.1 for ; Tue, 30 Apr 2019 09:31:25 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id b11sm5348560wmh.29.2019.04.30.09.31.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Apr 2019 09:31:22 -0700 (PDT) Subject: Re: Fix compilation using mingw.org's MinGW To: Eli Zaretskii References: <835zrbe36c.fsf@gnu.org> <250801eb-14f6-5a35-0556-cf5797dd8a7b@redhat.com> <83y347cfbu.fsf@gnu.org> <556cefd7-47ce-54ab-a228-2c727aab4179@redhat.com> <83d0lick7o.fsf@gnu.org> <93ccb0fa-8a05-60ff-d1a8-85d5663b8d16@redhat.com> <831s1murm2.fsf@gnu.org> <83k1fbseiw.fsf@gnu.org> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Tue, 30 Apr 2019 16:31:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <83k1fbseiw.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-04/txt/msg00657.txt.bz2 On 4/30/19 4:23 PM, Eli Zaretskii wrote: >> Cc: gdb-patches@sourceware.org >> From: Pedro Alves >> Date: Tue, 30 Apr 2019 14:10:53 +0100 >> >>> - The override in _WIN32_WINNT is no longer necessary. It could >>> be removed at the same time. >> >> I meant the _WIN32_WINNT override in common/netstuff.c. >> >> I see now that there are more of those in other files too. > > I will review them for the changeset on master, but I don't think we > should change them on the 8.3 branch. OK? Yes, my comments were for master, since changing removing the overrides in the other files only makes sense with the _WIN32_WINNT definition in common-defs.h. Thanks, Pedro Alves