From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by sourceware.org (Postfix) with ESMTPS id 96E25385480D for ; Wed, 8 Jun 2022 10:17:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 96E25385480D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f44.google.com with SMTP id u3so27708953wrg.3 for ; Wed, 08 Jun 2022 03:17:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=csg+gUNkXdhJD2cpGBn5vOIQjP2X7AI2mUGBTciLcQU=; b=OEGmhL5fVV4iIFZXX+f4MzJ+LF6NLeRwydUfXlGVP827a9j0+MHMUTLD+GFGDl3Fjv 7dhrm954grZgAeDl4GkWEJvAMUVnGaQPTKwLR5okLhb/2AhXFy7pNU9PspGheepkAiqG ZD2CLKjKnpMdmMnc/EkOJpz1cRJxc3EwQl/EMEZC0QDAFI7Kw72fVJgrCvUdJHo02P8U ULsYK6OAYWJvfozyuhJMGWf7nzSTlNbdkYbGa1NlrI4D8U7i9Hbf5hcDUo69ai5DW26f lVZfxNL3g0+PvmhLIaaH9tazXB4zrpqnGeWPFK4edfL7R5CoAaH9XEYR3DiZw9u5RBge /SOA== X-Gm-Message-State: AOAM532z1uXmCcP6zNbTM1PQJdGHLEujVIAvn4N9++8RwQeR87KfXVRj e0iyh2Ma0TbjTTwNGIbKaA0= X-Google-Smtp-Source: ABdhPJx8bBhrSvrQlHZLJsId3djk0asdqLsfpulVnE96trbkth7XNx8p01TVcqwFagah3PZRp8XIVQ== X-Received: by 2002:a5d:5046:0:b0:210:20ba:843b with SMTP id h6-20020a5d5046000000b0021020ba843bmr32277159wrt.447.1654683452586; Wed, 08 Jun 2022 03:17:32 -0700 (PDT) Received: from ?IPV6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id p5-20020adfce05000000b002102739add8sm25525608wrn.54.2022.06.08.03.17.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jun 2022 03:17:31 -0700 (PDT) Message-ID: Date: Wed, 8 Jun 2022 11:17:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 5/5] gdb: native target invalid architecture detection Content-Language: en-US To: Luis Machado , Andrew Burgess , John Baldwin , gdb-patches@sourceware.org References: <71a986a5-2cfa-543e-4034-70f3af7dfecf@FreeBSD.org> <87ee09d4rt.fsf@redhat.com> <09afe250-9573-45e1-993b-a2f911f03630@arm.com> <87ilpdhn73.fsf@redhat.com> <87ee01hed4.fsf@redhat.com> <12c3913e-186d-b676-fe52-cc3322b00926@arm.com> <5c316bab-c2d3-309e-f938-7480e861b444@palves.net> <49bdabab-414e-85c7-4fd3-bec68ac9822a@arm.com> From: Pedro Alves In-Reply-To: <49bdabab-414e-85c7-4fd3-bec68ac9822a@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00, BODY_8BITS, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jun 2022 10:17:35 -0000 On 2022-06-08 09:18, Luis Machado wrote: > On 6/7/22 21:15, Pedro Alves wrote: >> On 2022-06-07 19:42, Pedro Alves wrote: >> >>>      When we use gcc for arm-linux target, its file name can be different, >>>      arm-linux-gnueabihf-gcc, arm-linux-gnueabi-gcc, or arm-none-linux-gnueabi-gcc, >>>      so I add a variable ARM_CC_FOR_TARGET, so that user can set the name >>>      of gcc for arm-linux target on aarch64, like: >> >> ... >> >>> Maybe it would be possible to come up with a way to default ARM_CC_FOR_TARGET to >>> something that works for most people when testing aarch64, somehow. >> >> Maybe something like this?  Completely untested, other than hacking it such that >> the aarch64 linux path is taken on my x86-64 box, to ensure the tcl at least parses >> as expected. >> > > Thanks for the patch. I think it is fine to have some of these tests run conditionally > based on the presence of an environment variable. What we're really missing is proper > documentation of ARM_CC_FOR_TARGET, explaining what it does, when it should be enabled > and under what conditions. I agree we're missing documentation of that option, but I don't think fixing that should prevent making "make check" with no options Just Work, with the ARM_CC_FOR_TARGET option being there as an escape hatch for the less common scenario. I think I should be able to e.g., log in some aarch64 machine on the compile farm to test something, and not have to remember to pass arch specific options to make check. > > I wonder if putting that on the GDB manual, under a testing section, would work. The Wiki > has an entry for testing, but I find it a bit chaotic. What do you say? Testsuite options are documented in gdb/testsuite/README.